From: "Mario Bălănică" <mariobalanica02@gmail.com>
To: Jeremy Linton <jeremy.linton@arm.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v2 2/2] Platform/RaspberryPi: Enable Bluetooth and UART in Windows OS
Date: Fri, 26 Mar 2021 07:33:12 -0700 [thread overview]
Message-ID: <19815.1616769192750324928@groups.io> (raw)
In-Reply-To: <c737cf99-ddb1-9a02-e1f0-9dc7e8a4d1ba@arm.com>
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
>
> - GpioIO (Shared, PullUp, 0, 0, IoRestrictionNone, "\\_SB.GDV0.RPIQ", 0,
> ResourceConsumer, , ) { 128 }
> + //GpioIO (Shared, PullUp, 0, 0, IoRestrictionNone, "\\_SB.GDV0.RPIQ", 0,
> ResourceConsumer, , ) { 128 }
>
This line should be completely removed.
BT_ON is configured by the firmware, and the Windows driver doesn't touch it.
>
> +
> + PinFunction (Exclusive, PullDown, BCM_ALT3, "\\_SB.GDV0.GPI0", 0,
> ResourceConsumer, , ) { 32, 33 }
> +
> + // fake the CTS signal as we don't support HW flow control yet
> + // BCM_ALT2 is set as output (low) by default
> + PinFunction (Exclusive, PullNone, BCM_ALT2, "\\_SB.GDV0.GPI0", 0,
> ResourceConsumer, , ) { 31 }
>
This always assumes that PL011 is used for Bluetooth. The pin muxing could be done in ConfigDxe depending on which UART is unused.
Also, pin 31 should be set as a LOW output pin rather than relying on the default configuration of BCM_ALT2.
[-- Attachment #2: Type: text/html, Size: 1543 bytes --]
next prev parent reply other threads:[~2021-03-26 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 9:45 [PATCH v2 1/2] Platform/RaspberryPi: Dynamically build UARTs info in ACPI Sunny Wang
2021-03-24 9:45 ` [PATCH v2 2/2] Platform/RaspberryPi: Enable Bluetooth and UART in Windows OS Sunny Wang
2021-03-24 19:50 ` Jeremy Linton
2021-03-26 14:33 ` Mario Bălănică [this message]
2021-03-24 12:44 ` [PATCH v2 1/2] Platform/RaspberryPi: Dynamically build UARTs info in ACPI Pete Batard
2021-03-24 19:40 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19815.1616769192750324928@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox