From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] [PATCH v2 2/2] Platform/RaspberryPi: Enable Bluetooth and UART in Windows OS
To: Jeremy Linton <jeremy.linton@arm.com>,devel@edk2.groups.io
From: =?UTF-8?B?TWFyaW8gQsSDbMSDbmljxIM=?= <mariobalanica02@gmail.com>
X-Originating-Location: Galati, RO (5.13.204.103)
X-Originating-Platform: Windows Chrome 89
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Fri, 26 Mar 2021 07:33:12 -0700
References: <c737cf99-ddb1-9a02-e1f0-9dc7e8a4d1ba@arm.com>
In-Reply-To: <c737cf99-ddb1-9a02-e1f0-9dc7e8a4d1ba@arm.com>
Message-ID: <19815.1616769192750324928@groups.io>
Content-Type: multipart/alternative; boundary="OrgYdQopz9zcgUAqbqTh"

--OrgYdQopz9zcgUAqbqTh
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

>=20
> - GpioIO (Shared, PullUp, 0, 0, IoRestrictionNone, "\\_SB.GDV0.RPIQ", 0,
> ResourceConsumer, , ) { 128 }
> + //GpioIO (Shared, PullUp, 0, 0, IoRestrictionNone, "\\_SB.GDV0.RPIQ", =
0,
> ResourceConsumer, , ) { 128 }
>=20

This line should be completely removed.
BT_ON is configured by the firmware, and the Windows driver doesn't touch =
it.

>=20
> +
> + PinFunction (Exclusive, PullDown, BCM_ALT3, "\\_SB.GDV0.GPI0", 0,
> ResourceConsumer, , ) { 32, 33 }
> +
> + // fake the CTS signal as we don't support HW flow control yet
> + // BCM_ALT2 is set as output (low) by default
> + PinFunction (Exclusive, PullNone, BCM_ALT2, "\\_SB.GDV0.GPI0", 0,
> ResourceConsumer, , ) { 31 }
>=20

This always assumes that PL011 is used for Bluetooth. The pin muxing could=
 be done in ConfigDxe depending on which UART is unused.
Also, pin 31 should be set as a LOW output pin rather than relying on the =
default configuration of BCM_ALT2.

--OrgYdQopz9zcgUAqbqTh
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

<blockquote><span style=3D"white-space: pre-wrap;">- GpioIO (Shared, PullUp=
, 0, 0, IoRestrictionNone, "\\_SB.GDV0.RPIQ", 0, ResourceConsumer, , ) { 12=
8 }</span><br style=3D"white-space: pre-wrap;" /><span style=3D"white-space=
: pre-wrap;">+ //GpioIO (Shared, PullUp, 0, 0, IoRestrictionNone, "\\_SB.GD=
V0.RPIQ", 0, ResourceConsumer, , ) { 128 }<br /></span></blockquote>
This line should be completely removed.&nbsp;<br />BT_ON is configured by =
the firmware, and the Windows driver doesn't touch it.<br /><br />
<blockquote><span style=3D"white-space: pre-wrap;">+</span><br style=3D"wh=
ite-space: pre-wrap;" /><span style=3D"white-space: pre-wrap;">+ PinFunctio=
n (Exclusive, PullDown, BCM_ALT3, "\\_SB.GDV0.GPI0", 0, ResourceConsumer, ,=
 ) { 32, 33 }</span><br style=3D"white-space: pre-wrap;" /><span style=3D"w=
hite-space: pre-wrap;">+</span><br style=3D"white-space: pre-wrap;" /><span=
 style=3D"white-space: pre-wrap;">+ // fake the CTS signal as we don't supp=
ort HW flow control yet</span><br style=3D"white-space: pre-wrap;" /><span =
style=3D"white-space: pre-wrap;">+ // BCM_ALT2 is set as output (low) by de=
fault</span><br style=3D"white-space: pre-wrap;" /><span style=3D"white-spa=
ce: pre-wrap;">+ PinFunction (Exclusive, PullNone, BCM_ALT2, "\\_SB.GDV0.GP=
I0", 0, ResourceConsumer, , ) { 31 }<br /></span></blockquote>
This always assumes that PL011 is used for Bluetooth. The pin muxing could=
 be done in ConfigDxe depending on which UART is unused.<br />Also, pin 31 =
should be set as a LOW output pin rather than relying on the default config=
uration of BCM_ALT2.

--OrgYdQopz9zcgUAqbqTh--