Re: [edk2-devel] [PATCH edk2-platforms 2/2] SbsaQemu: set CPU model in SMBIOS

["Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>]

On 12.07.2024 12:01, Ard Biesheuvel wrote:
>> SbsaQemu platform have several cpu models available. Since start it
>> reported "arm-virt" one in SMBIOS instead of real one.
>>
>> This change replaces it with the real cpu model like Cortex-A57,
>> Neoverse-N2 etc.
>>
>> Requires change in EDK2 to make PcdProcessorVersion dynamic.
>>
>> Signed-off-by: Marcin Juszkiewicz<marcin.juszkiewicz@linaro.org>
> I am going to make the same remark as I did before in a different
> context: how is it guaranteed that the code that sets the PCD executes
> before the code that consumes it?
> 
> Making PCDs dynamic is usually not the solution here, unless they are
> set in the PEI phase and consumed in the DXE phase or after.
> 
> The EFI SMBIOS protocol has an 'update string' method that you can
> call from a platform driver. That might be a better fit here, and the
> PCD can remain fixed, and carry a fallback default value.

Thanks. Will take a look.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119910): https://edk2.groups.io/g/devel/message/119910
Mute This Topic: https://groups.io/mt/107179083/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-