From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 36621940F44 for ; Fri, 12 Jul 2024 10:58:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DoqgIoVIHahgPOqClbFVPhcqT35fTVy43J+fUpix/J0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:Organization:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1720781905; v=1; b=rzWMJrGkVO4Ugs1X/26kaoINJ3CjBQuGuvqBDRoRQ/VFnCXp+aXWvlI4XDRDfaCzh1SajlxN L1qYZ3oIQvfqT4hhqUVyhayPgP9MnYldSKY6xh7EcIqTl47ojiaHytdoEXzHzLedMVgJ3K151rC NM8vLzF7HFz8a2bqPF2xW0iYHg0rL/DUUZVzqgRs8TiQ62MnMpQGKXsxitOnaBNeLQzPC7DekKh YSAQgGtxjpIj9XZzTBbgZO8UpqcTl3Q1jMmgGnam28N+IjA1S8CTbtjGrE2fISDR2ObmiY3ukH+ yvCUDbKM3ic0pf8KM+yAEBCr4VU9eB4O/Rp+cIqQxcGUA== X-Received: by 127.0.0.2 with SMTP id PUdHYY7687511xo0T7uTv9jm; Fri, 12 Jul 2024 03:58:24 -0700 X-Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by mx.groups.io with SMTP id smtpd.web11.5134.1720781903945580728 for ; Fri, 12 Jul 2024 03:58:24 -0700 X-Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-58ef19aa69dso2386426a12.3 for ; Fri, 12 Jul 2024 03:58:23 -0700 (PDT) X-Gm-Message-State: yzUTEi7WQqcnM2QKe0bzkwNmx7686176AA= X-Google-Smtp-Source: AGHT+IGJs43tTR5K3+jig1pbybXM8IXY0K75nu7JFkg165Z4cvR/4VBkR3UU7hVfR/FLFvOuPpgHCg== X-Received: by 2002:a05:6402:2547:b0:58a:d4f4:e8e7 with SMTP id 4fb4d7f45d1cf-594baa8bd14mr9425812a12.1.1720781901954; Fri, 12 Jul 2024 03:58:21 -0700 (PDT) X-Received: from [192.168.200.25] (83.8.74.165.ipv4.supernova.orange.pl. [83.8.74.165]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-594bc7c8a39sm4460166a12.55.2024.07.12.03.58.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jul 2024 03:58:21 -0700 (PDT) Message-ID: <1983882b-4d38-48f0-840b-d1551164c203@linaro.org> Date: Fri, 12 Jul 2024 12:58:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms 2/2] SbsaQemu: set CPU model in SMBIOS To: Ard Biesheuvel Cc: devel@edk2.groups.io, Leif Lindholm , Ard Biesheuvel , Sami Mujawar References: <20240712092356.517074-1-marcin.juszkiewicz@linaro.org> <20240712092356.517074-3-marcin.juszkiewicz@linaro.org> From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 12 Jul 2024 03:58:24 -0700 Resent-From: marcin.juszkiewicz@linaro.org Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=rzWMJrGk; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 12.07.2024 12:01, Ard Biesheuvel wrote: >> SbsaQemu platform have several cpu models available. Since start it >> reported "arm-virt" one in SMBIOS instead of real one. >> >> This change replaces it with the real cpu model like Cortex-A57, >> Neoverse-N2 etc. >> >> Requires change in EDK2 to make PcdProcessorVersion dynamic. >> >> Signed-off-by: Marcin Juszkiewicz > I am going to make the same remark as I did before in a different > context: how is it guaranteed that the code that sets the PCD executes > before the code that consumes it? >=20 > Making PCDs dynamic is usually not the solution here, unless they are > set in the PEI phase and consumed in the DXE phase or after. >=20 > The EFI SMBIOS protocol has an 'update string' method that you can > call from a platform driver. That might be a better fit here, and the > PCD can remain fixed, and carry a fallback default value. Thanks. Will take a look. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119910): https://edk2.groups.io/g/devel/message/119910 Mute This Topic: https://groups.io/mt/107179083/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-