* Re: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules
2019-05-27 6:36 [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules Wu, Hao A
@ 2019-05-27 16:56 ` Laszlo Ersek
2019-05-27 17:02 ` Laszlo Ersek
2019-06-13 15:00 ` Laszlo Ersek
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Laszlo Ersek @ 2019-05-27 16:56 UTC (permalink / raw)
To: devel, hao.a.wu; +Cc: Ray Ni, Andrew Fish, Leif Lindholm, Michael D Kinney
On 05/27/19 08:36, Wu, Hao A wrote:
> '''
> Please note that this patch will be hold until all the below requirements
> are met:
>
> A. edk2-stable201905 is created;
> B. OvmfPkg has drop its usage of the legacy ISA stack (which includes
> the IsaAcpiDxe driver);
> C. UefiPayloadPkg has been updated to drop its consume to the
> 8259InterruptControllerDxe driver.
> '''
>
> This patch itself will not be sent to the mailing list and is only
> available at:
> https://github.com/hwu25/edk2/tree/delete_framework
> (https://github.com/hwu25/edk2/commit/84e58f89f6d03f9cc3399cced9d5d5529e06a416)
>
>
> Below modules will be removed from PcAtChipsetPkg:
> * PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> * PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
> * PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
>
> They are considered legacy framework components and will no longer be used
> after the removal of IntelFramework[Module]Pkg.
>
> Also, the unused (after the modules being removed) PCDs will be deleted in
> package level DEC/UNI files.
Please include a reference to
<https://bugzilla.tianocore.org/show_bug.cgi?id=1844> in the commit message.
(I might comment more later; not sure just yet.)
Thanks
Laszlo
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>
>
> Hao A Wu (1):
> PcAtChipsetPkg: Remove framework modules
>
> PcAtChipsetPkg/PcAtChipsetPkg.dec | 58 --
> PcAtChipsetPkg/PcAtChipsetPkg.dsc | 5 +-
> PcAtChipsetPkg/8254TimerDxe/8254Timer.inf | 42 --
> PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf | 46 --
> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf | 50 --
> PcAtChipsetPkg/8254TimerDxe/Timer.h | 185 ------
> PcAtChipsetPkg/8259InterruptControllerDxe/8259.h | 220 -------
> PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h | 269 ---------
> PcAtChipsetPkg/8254TimerDxe/Timer.c | 401 -------------
> PcAtChipsetPkg/8259InterruptControllerDxe/8259.c | 622 --------------------
> PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c | 301 ----------
> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c | 353 -----------
> PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c | 386 ------------
> PcAtChipsetPkg/8254TimerDxe/Timer.uni | 16 -
> PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni | 14 -
> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni | 16 -
> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni | 14 -
> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni | 16 -
> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni | 14 -
> PcAtChipsetPkg/PcAtChipsetPkg.uni | 52 +-
> 20 files changed, 2 insertions(+), 3078 deletions(-)
> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.h
> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.h
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h
> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.c
> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.c
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c
> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.uni
> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni
> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni
> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules
2019-05-27 16:56 ` [edk2-devel] " Laszlo Ersek
@ 2019-05-27 17:02 ` Laszlo Ersek
0 siblings, 0 replies; 7+ messages in thread
From: Laszlo Ersek @ 2019-05-27 17:02 UTC (permalink / raw)
To: devel, hao.a.wu; +Cc: Ray Ni, Andrew Fish, Leif Lindholm, Michael D Kinney
On 05/27/19 18:56, Laszlo Ersek wrote:
> On 05/27/19 08:36, Wu, Hao A wrote:
>> '''
>> Please note that this patch will be hold until all the below requirements
>> are met:
>>
>> A. edk2-stable201905 is created;
>> B. OvmfPkg has drop its usage of the legacy ISA stack (which includes
>> the IsaAcpiDxe driver);
>> C. UefiPayloadPkg has been updated to drop its consume to the
>> 8259InterruptControllerDxe driver.
>> '''
>>
>> This patch itself will not be sent to the mailing list and is only
>> available at:
>> https://github.com/hwu25/edk2/tree/delete_framework
>> (https://github.com/hwu25/edk2/commit/84e58f89f6d03f9cc3399cced9d5d5529e06a416)
>>
>>
>> Below modules will be removed from PcAtChipsetPkg:
>> * PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
>> * PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
>> * PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
>>
>> They are considered legacy framework components and will no longer be used
>> after the removal of IntelFramework[Module]Pkg.
>>
>> Also, the unused (after the modules being removed) PCDs will be deleted in
>> package level DEC/UNI files.
>
> Please include a reference to
> <https://bugzilla.tianocore.org/show_bug.cgi?id=1844> in the commit message.
Sorry, I missed that the patch was not sent to the list -- but I've now
checked in your personal repo, and the BZ reference is already there in
the commit message.
Thanks
Laszlo
>
> (I might comment more later; not sure just yet.)
>
> Thanks
> Laszlo
>
>>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>
>>
>> Hao A Wu (1):
>> PcAtChipsetPkg: Remove framework modules
>>
>> PcAtChipsetPkg/PcAtChipsetPkg.dec | 58 --
>> PcAtChipsetPkg/PcAtChipsetPkg.dsc | 5 +-
>> PcAtChipsetPkg/8254TimerDxe/8254Timer.inf | 42 --
>> PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf | 46 --
>> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf | 50 --
>> PcAtChipsetPkg/8254TimerDxe/Timer.h | 185 ------
>> PcAtChipsetPkg/8259InterruptControllerDxe/8259.h | 220 -------
>> PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h | 269 ---------
>> PcAtChipsetPkg/8254TimerDxe/Timer.c | 401 -------------
>> PcAtChipsetPkg/8259InterruptControllerDxe/8259.c | 622 --------------------
>> PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c | 301 ----------
>> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c | 353 -----------
>> PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c | 386 ------------
>> PcAtChipsetPkg/8254TimerDxe/Timer.uni | 16 -
>> PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni | 14 -
>> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni | 16 -
>> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni | 14 -
>> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni | 16 -
>> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni | 14 -
>> PcAtChipsetPkg/PcAtChipsetPkg.uni | 52 +-
>> 20 files changed, 2 insertions(+), 3078 deletions(-)
>> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
>> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
>> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
>> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.h
>> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.h
>> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h
>> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.c
>> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.c
>> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c
>> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c
>> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c
>> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.uni
>> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni
>> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni
>> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni
>> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni
>> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni
>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules
2019-05-27 6:36 [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules Wu, Hao A
2019-05-27 16:56 ` [edk2-devel] " Laszlo Ersek
@ 2019-06-13 15:00 ` Laszlo Ersek
2019-06-25 8:03 ` Ni, Ray
2019-06-25 8:06 ` Wu, Hao A
3 siblings, 0 replies; 7+ messages in thread
From: Laszlo Ersek @ 2019-06-13 15:00 UTC (permalink / raw)
To: devel, hao.a.wu
Cc: Ray Ni, Andrew Fish, Leif Lindholm, Michael D Kinney,
David Woodhouse
Hello Hao,
On 05/27/19 08:36, Wu, Hao A wrote:
> '''
> Please note that this patch will be hold until all the below requirements
> are met:
>
> A. edk2-stable201905 is created;
> B. OvmfPkg has drop its usage of the legacy ISA stack (which includes
> the IsaAcpiDxe driver);
> C. UefiPayloadPkg has been updated to drop its consume to the
> 8259InterruptControllerDxe driver.
> '''
>
> This patch itself will not be sent to the mailing list and is only
> available at:
> https://github.com/hwu25/edk2/tree/delete_framework
> (https://github.com/hwu25/edk2/commit/84e58f89f6d03f9cc3399cced9d5d5529e06a416)
>
>
> Below modules will be removed from PcAtChipsetPkg:
> * PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> * PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
> * PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
OvmfPkg's dependency on IsaAcpiDxe has been removed in commit
562688707145 ("OvmfPkg: Drop build flag USE_LEGACY_ISA_STACK and legacy
ISA stack", 2019-06-11), so that's fine.
The other two drivers (8259InterruptControllerDxe and 8254TimerDxe) have
been copied under OvmfPkg for bug 1496.
I haven't reviewed this series in detail, but based on the above, I'm
fine with the removals, in general.
Acked-by: Laszlo Ersek <lersek@redhat.com>
Thanks
Laszlo
>
> They are considered legacy framework components and will no longer be used
> after the removal of IntelFramework[Module]Pkg.
>
> Also, the unused (after the modules being removed) PCDs will be deleted in
> package level DEC/UNI files.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>
>
> Hao A Wu (1):
> PcAtChipsetPkg: Remove framework modules
>
> PcAtChipsetPkg/PcAtChipsetPkg.dec | 58 --
> PcAtChipsetPkg/PcAtChipsetPkg.dsc | 5 +-
> PcAtChipsetPkg/8254TimerDxe/8254Timer.inf | 42 --
> PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf | 46 --
> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf | 50 --
> PcAtChipsetPkg/8254TimerDxe/Timer.h | 185 ------
> PcAtChipsetPkg/8259InterruptControllerDxe/8259.h | 220 -------
> PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h | 269 ---------
> PcAtChipsetPkg/8254TimerDxe/Timer.c | 401 -------------
> PcAtChipsetPkg/8259InterruptControllerDxe/8259.c | 622 --------------------
> PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c | 301 ----------
> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c | 353 -----------
> PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c | 386 ------------
> PcAtChipsetPkg/8254TimerDxe/Timer.uni | 16 -
> PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni | 14 -
> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni | 16 -
> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni | 14 -
> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni | 16 -
> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni | 14 -
> PcAtChipsetPkg/PcAtChipsetPkg.uni | 52 +-
> 20 files changed, 2 insertions(+), 3078 deletions(-)
> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.h
> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.h
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h
> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.c
> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.c
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c
> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.uni
> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni
> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni
> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules
2019-05-27 6:36 [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules Wu, Hao A
2019-05-27 16:56 ` [edk2-devel] " Laszlo Ersek
2019-06-13 15:00 ` Laszlo Ersek
@ 2019-06-25 8:03 ` Ni, Ray
2019-06-27 1:01 ` Wu, Hao A
2019-06-25 8:06 ` Wu, Hao A
3 siblings, 1 reply; 7+ messages in thread
From: Ni, Ray @ 2019-06-25 8:03 UTC (permalink / raw)
To: Wu, Hao A, devel
[-- Attachment #1: Type: text/plain, Size: 40 bytes --]
Reviewed-by: Ray Ni <ray.ni@intel.com>
[-- Attachment #2: Type: text/html, Size: 99 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules
2019-06-25 8:03 ` Ni, Ray
@ 2019-06-27 1:01 ` Wu, Hao A
0 siblings, 0 replies; 7+ messages in thread
From: Wu, Hao A @ 2019-06-27 1:01 UTC (permalink / raw)
To: Ni, Ray, devel@edk2.groups.io
[-- Attachment #1: Type: text/plain, Size: 342 bytes --]
Thanks.
Pushed via commit c78008b4b2.
Best Regards,
Hao Wu
From: Ni, Ray [mailto:ray.ni@intel.com]
Sent: Tuesday, June 25, 2019 4:04 PM
To: Wu; Wu, Hao A; devel@edk2.groups.io
Subject: Re: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules
Reviewed-by: Ray Ni ray.ni@intel.com<mailto:ray.ni@intel.com>
[-- Attachment #2: Type: text/html, Size: 23164 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules
2019-05-27 6:36 [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules Wu, Hao A
` (2 preceding siblings ...)
2019-06-25 8:03 ` Ni, Ray
@ 2019-06-25 8:06 ` Wu, Hao A
3 siblings, 0 replies; 7+ messages in thread
From: Wu, Hao A @ 2019-06-25 8:06 UTC (permalink / raw)
To: devel@edk2.groups.io, 'rfc@edk2.groups.io'
Cc: Ni, Ray, Andrew Fish, Laszlo Ersek, Leif Lindholm,
Kinney, Michael D, 'Kirkendall, Garrett'
Hello all,
For this RFC patch, so far it has received the below feedbacks:
* Ack tag from Laszlo:
https://edk2.groups.io/g/devel/message/42381
* Reviewed-by tag from Ray (PcAtChipsetPkg maintainer):
https://edk2.groups.io/g/devel/message/42793
* Linux Kernel soft hangs if 8259 PIC is not configured by BIOS:
https://edk2.groups.io/g/devel/topic/31823819#41532
For the last feedback, 8259 PIC can still be configured (to a reasonable
state for OS) by Chipset/SI initialization codes without requiring the
8259 driver in PcAtChipsetPkg. Hence, I think it is not considered as a
blockade for the removal of 8259 driver proposed by this patch.
If there is no other concern, I plan to push this change in 24 hours.
Best Regards,
Hao Wu
> -----Original Message-----
> From: Wu, Hao A
> Sent: Monday, May 27, 2019 2:37 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Ni, Ray; Andrew Fish; Laszlo Ersek; Leif Lindholm; Kinney,
> Michael D
> Subject: [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules
>
> '''
> Please note that this patch will be hold until all the below requirements
> are met:
>
> A. edk2-stable201905 is created;
> B. OvmfPkg has drop its usage of the legacy ISA stack (which includes
> the IsaAcpiDxe driver);
> C. UefiPayloadPkg has been updated to drop its consume to the
> 8259InterruptControllerDxe driver.
> '''
>
> This patch itself will not be sent to the mailing list and is only
> available at:
> https://github.com/hwu25/edk2/tree/delete_framework
> (https://github.com/hwu25/edk2/commit/84e58f89f6d03f9cc3399cced9d5d5
> 529e06a416)
>
>
> Below modules will be removed from PcAtChipsetPkg:
> * PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> * PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
> * PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
>
> They are considered legacy framework components and will no longer be
> used
> after the removal of IntelFramework[Module]Pkg.
>
> Also, the unused (after the modules being removed) PCDs will be deleted in
> package level DEC/UNI files.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>
>
> Hao A Wu (1):
> PcAtChipsetPkg: Remove framework modules
>
> PcAtChipsetPkg/PcAtChipsetPkg.dec | 58 --
> PcAtChipsetPkg/PcAtChipsetPkg.dsc | 5 +-
> PcAtChipsetPkg/8254TimerDxe/8254Timer.inf | 42 --
> PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf | 46 --
> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf | 50 --
> PcAtChipsetPkg/8254TimerDxe/Timer.h | 185 ------
> PcAtChipsetPkg/8259InterruptControllerDxe/8259.h | 220 -------
> PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h | 269 ---------
> PcAtChipsetPkg/8254TimerDxe/Timer.c | 401 -------------
> PcAtChipsetPkg/8259InterruptControllerDxe/8259.c | 622 ---------------
> -----
> PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c | 301 ----------
> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c | 353 -----------
> PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c | 386 ------------
> PcAtChipsetPkg/8254TimerDxe/Timer.uni | 16 -
> PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni | 14 -
> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni | 16 -
> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni | 14 -
> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni | 16 -
> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni | 14 -
> PcAtChipsetPkg/PcAtChipsetPkg.uni | 52 +-
> 20 files changed, 2 insertions(+), 3078 deletions(-)
> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.h
> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.h
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h
> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.c
> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.c
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c
> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.uni
> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni
> delete mode 100644
> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni
> delete mode 100644
> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni
> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni
>
> --
> 2.12.0.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread