From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.12203.1585669951977965323 for ; Tue, 31 Mar 2020 08:52:32 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: shenglei.zhang@intel.com) IronPort-SDR: k5IIUZTD99uEKo6Jhp8WYwYwyY/AM2YSspuPVS6tbDudRphnZPPXebSbwY7A4EX0VgjtQgu2xw C4/B+La2kkLA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2020 08:52:31 -0700 IronPort-SDR: N4COdgMhJsaeJMQyPRxql2FtmcTzhLUXxePye0H3suXluJEiCUxVB42mpqmFlxP6M5kAncWEPn UVh9pMUnC2Ag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,328,1580803200"; d="scan'208,217";a="252289587" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 31 Mar 2020 08:52:31 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 31 Mar 2020 08:52:30 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 31 Mar 2020 08:52:30 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.22]) with mapi id 14.03.0439.000; Tue, 31 Mar 2020 23:52:27 +0800 From: "Zhang, Shenglei" To: Sean Brogan , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" , "Zhang, Shenglei" Subject: How to add ignore "IgnoreFiles" for CharEncodingCheck Thread-Topic: How to add ignore "IgnoreFiles" for CharEncodingCheck Thread-Index: AdYHdEcFFCPeftEMSX+gHHW01tNh+Q== Date: Tue, 31 Mar 2020 15:52:27 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2I4MTE4MjEtZDc3NS00MGQ4LWExNzctOGEzYmRjYWE0MzZlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYVZxNG01UHVRbjYrQkF6QldFXC9SZ1Vrdm5cL0p5dk05RExxUXJscGJTZEVBZHhBYVdnSXNKTlptUjVPUStCVVZzIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: shenglei.zhang@intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_C0706E73DB8C124D9B9C38AA364E5D5E060535BBSHSMSX104ccrcor_" --_000_C0706E73DB8C124D9B9C38AA364E5D5E060535BBSHSMSX104ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Sean, I am introducing third party project oniguruma as submodule into edk2, and = want to skip CharEncodingCheck for certain files in oniguruma. I tried to add changes like below, but CI build failed. "CharEncodingCheck": { "IgnoreFiles": [[(MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/tes= t/testc.c),(MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/windows/t= estc.c)] } So what should I do in CharEncodingCheck_plug_in.yaml? Or how do you handle= this kind of case like openssl? I see you add this to edk2 and hope you could resolve my query. Thanks in a= dvance. Best Regards, Shenglei --_000_C0706E73DB8C124D9B9C38AA364E5D5E060535BBSHSMSX104ccrcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Sean,

I am introducing third party pr= oject oniguruma as submodule into edk2, and want to skip CharEncodingCheck = for certain files in oniguruma.

I tried to add changes like bel= ow, but CI build failed.

"CharEncodingCheck": = {

&q= uot;IgnoreFiles": [[(MdeModulePkg/Universal/RegularExpressionDxe/onigu= ruma/test/testc.c),(MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/w= indows/testc.c)]

}

So what should I do in CharEnco= dingCheck_plug_in.yaml? Or how do you handle this kind of case like openssl= ?

I see you add this to edk2 and = hope you could resolve my query. Thanks in advance.

Best Regards,=

Shenglei

--_000_C0706E73DB8C124D9B9C38AA364E5D5E060535BBSHSMSX104ccrcor_-- From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] How to add ignore "IgnoreFiles" for CharEncodingCheck To: Zhang, Shenglei ,devel@edk2.groups.io From: "Sean" X-Originating-Location: Redmond, Washington, US (50.35.74.15) X-Originating-Platform: Windows Chrome 83 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Tue, 31 Mar 2020 17:30:13 -0700 References: In-Reply-To: Message-ID: <19871.1585701013175242066@groups.io> Content-Type: multipart/alternative; boundary="1ViRqSNGnNWlR1feFoNh" --1ViRqSNGnNWlR1feFoNh Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tue, Mar 31, 2020 at 08:52 AM, Zhang, Shenglei wrote: >=20 >=20 >=20 > "CharEncodingCheck": { >=20 >=20 >=20 > "IgnoreFiles": > [[(MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/test/testc.c),(= MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/windows/testc.c)] >=20 >=20 >=20 >=20 > } >=20 >=20 This syntax works for me.=C2=A0 The logic isn't very complex as it is just= a case sensitive string match. "CharEncodingCheck": { "IgnoreFiles": ["MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/tes= t/testc.c", "MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/windows/= testc.c"] } --1ViRqSNGnNWlR1feFoNh Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tue, Mar 31, 2020 at 08:52 AM, Zhang, Shenglei wrote:

= "CharEncodingCheck": {

= "IgnoreFiles": [[(MdeModulePkg/Universal/RegularExpressionDxe/onigu= ruma/test/testc.c),(MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/w= indows/testc.c)]

= }

This syntax works for me.=C2=A0 The logic isn't very complex as it is = just a case sensitive string match.=C2=A0

"CharEncodingCheck&#= 34;: {
"IgnoreFiles": ["MdeModulePkg/Universal/RegularExpre= ssionDxe/oniguruma/test/testc.c", "MdeModulePkg/Universal/RegularEx= pressionDxe/oniguruma/windows/testc.c"]
} --1ViRqSNGnNWlR1feFoNh--