From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6C72EAC19D7 for ; Wed, 25 Oct 2023 18:53:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6TvgfkbKHfrABTtQHwkTlEVHw7Fxmu5fHgFhbVOsu6s=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698260015; v=1; b=ZL7X524xHNhH6qzArK2miq9bJNOX/z1L+vcgCe+4J0+zKZfJNhcK79fpp8iwPPrOnFNDDgbk G71tlvm2+EbaZS0lBXlly0Z9DGG97fUrTPrgeR3r0SqNDrCZfDUJfd5X06c+4MFi4dfcuq/8QdB ZKE7hDE3Eg4ItocG9xoumC2A= X-Received: by 127.0.0.2 with SMTP id JIIBYY7687511xmho2sadL3u; Wed, 25 Oct 2023 11:53:35 -0700 X-Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mx.groups.io with SMTP id smtpd.web10.181872.1698260014870342898 for ; Wed, 25 Oct 2023 11:53:35 -0700 X-Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id E795A5C028B; Wed, 25 Oct 2023 14:53:33 -0400 (EDT) X-Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 25 Oct 2023 14:53:33 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrledtgdduvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfevfhfhjggtgfesth ejredttddvjeenucfhrhhomheptfgvsggvtggtrgcuvehrrghnuceorhgvsggvtggtrges sghsughiohdrtghomheqnecuggftrfgrthhtvghrnhepheehfefhtdfgiedtheeutdelgf fgudfgvdegveevteduiedvvdeiheevveevudefnecuffhomhgrihhnpehgrhhouhhpshdr ihhopdhgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 Oct 2023 14:53:32 -0400 (EDT) Message-ID: <1987df02-a51b-4e77-9683-a45d72336ab2@bsdio.com> Date: Wed, 25 Oct 2023 12:53:21 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH] Basetools: Include PCD declarations from Library Instance To: "levi.yun" , devel@edk2.groups.io Cc: sami.mujawar@arm.com, pierre.gondois@arm.com, ardb+tianocore@kernel.org, quic_llindhol@quicinc.com, gaoliming@byosoft.com.cn, bob.c.feng@intel.com, yuwei.chen@intel.com, nd@arm.com References: <20231012171155.3262128-1-yeoreum.yun@arm.com> From: "Rebecca Cran" In-Reply-To: <20231012171155.3262128-1-yeoreum.yun@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: MI6NxDB94OqAzgSx3BIo3Qpex7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZL7X524x; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Rebecca Cran --=20 Rebecca Cran On 10/12/23 11:11, levi.yun wrote: > The patch "[PATCH v3 1/2] StandaloneMmPkg: Make StandaloneMmCpu driver > architecture independent" (https://edk2.groups.io/g/devel/message/109178) > removed ArmPkg/ArmPkg.dec from the Packages section in the > INF file: StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf > > This change was done as part of making the StandaloneMmCpu driver > architecture independent. > > Although this change is correct, it results in a side effect > here some platforms that utilise PCDs declared in ArmPkg.dec are > no longer declared. > > An example of this issue can be seen when building > edk2-platforms/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > $ build -a AARCH64 -t GCC -p Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > build.py... > /mnt/source/edk2-platforms/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf(2= 3): > error F001: PCD (gArmTokenSpaceGuid.PcdFdBaseAddress) used in > FDF is not declared in DEC files. > > As seen above, removing ArmPkg.dec from the Packages section in the > StandAloneMmCpu Driver Inf file triggers build failure. > Although, ArmPkg.dec is included in other Library Instances, > the build system does not include the declarations from > .dec files defined in Library instances. > > The build system only includes the PCD declarations from DEC files > that are specified in INF files for Modules (components). > > Therefore, extend the build system to include the Packages from > Library Instances so that the PCD declarations from the respective packag= e > DEC files are included. > > This patch can be seen on > https://github.com/LeviYeoReum/edk2/tree/levi/2848_dec_check_on_libr= ary > > Signed-off-by: levi.yun > --- > BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py b/BaseTo= ols/Source/Python/AutoGen/WorkspaceAutoGen.py > index f86c749c08c3bb2837a88b5872101bc69e8bf7a0..f52ef42045da52c3d4f20277c= 61542f659eb7874 100644 > --- a/BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py > @@ -439,6 +439,10 @@ class WorkspaceAutoGen(AutoGen): > PkgSet =3D set() > for mb in [self.BuildDatabase[m, Arch, self.BuildTarget, se= lf.ToolChain] for m in Platform.Modules]: > PkgSet.update(mb.Packages) > + > + for lb in [self.BuildDatabase[l, Arch, self.BuildTarget, sel= f.ToolChain] for l in Platform.LibraryInstances]: > + PkgSet.update(lb.Packages) > + > for Inf in ModuleList: > ModuleFile =3D PathClass(NormPath(Inf), GlobalData.gWor= kspace, Arch) > if ModuleFile in Platform.Modules: > @@ -968,4 +972,3 @@ class WorkspaceAutoGen(AutoGen): > # > def CreateAsBuiltInf(self): > return > - > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110063): https://edk2.groups.io/g/devel/message/110063 Mute This Topic: https://groups.io/mt/101922917/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-