From: "Lin, Derek (HPS SW)" <derek.lin2@hpe.com>
To: Zhang, Chao B <chao.b.zhang@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] SecurityPkg: Don't Verify the enrolled PK in setup mode
Date: Thu, 22 Aug 2019 20:20:53 -0700 [thread overview]
Message-ID: <19963.1566530453572108137@groups.io> (raw)
In-Reply-To: <FF72C7E4248F3C4E9BDF19D4918E90F24DEF1B15@shsmsx102.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
Hi Laszlo, Chao,
Sorry for late response in this thread.
I review Mantis#1983 and this discussion again. I agree with Laszlo.
1. UEFI spec 2.8 is not very clear about PK validation in Setup mode.
2. This patch only reduce the complexity of update PK process.
Having a FeaturePCD to control this kind of behavior in EDK2 is weird. That only make things more complicated to me.
To simplify and make things clear, updating PK shall always be signed in both Setup Mode and User Mode.
Anyway, I agree with Laszlo and I'm good with current implementation now.
[-- Attachment #2: Type: text/html, Size: 635 bytes --]
prev parent reply other threads:[~2019-08-23 3:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 5:25 [PATCH] SecurityPkg: Don't Verify the enrolled PK in setup mode derek.lin2
2019-07-04 6:29 ` [edk2-devel] " derek.lin2
2019-07-09 15:39 ` Zhang, Chao B
2019-07-10 8:50 ` Wang, Jian J
2019-07-10 17:04 ` Laszlo Ersek
2019-07-11 3:20 ` Zhang, Chao B
2019-07-11 11:47 ` Laszlo Ersek
2019-07-12 1:41 ` Zhang, Chao B
2019-08-23 3:20 ` Lin, Derek (HPS SW) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19963.1566530453572108137@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox