From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2AD75210ED113 for ; Thu, 16 Aug 2018 12:15:25 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D95F7401EF2B; Thu, 16 Aug 2018 19:15:24 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-198.rdu2.redhat.com [10.10.120.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id 34C1520180F5; Thu, 16 Aug 2018 19:15:23 +0000 (UTC) To: Songpeng Li , edk2-devel@lists.01.org Cc: Siyuan Fu , Jiaxin Wu References: <20180816013757.9680-1-songpeng.li@intel.com> <20180816013757.9680-2-songpeng.li@intel.com> From: Laszlo Ersek Message-ID: <19ad6241-2636-8b3d-fa6a-3a3c424927c9@redhat.com> Date: Thu, 16 Aug 2018 21:15:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180816013757.9680-2-songpeng.li@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 16 Aug 2018 19:15:24 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 16 Aug 2018 19:15:24 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 1/5] NetworkPkg: IScsiDxe: Remove the redundant code and definition. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 19:15:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/16/18 03:37, Songpeng Li wrote: > The function IScsiFindTcbByITT that is never called have been removed. > The definition gEfiAcpi20TableGuid has been removed. > > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Laszlo Ersek > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Songpeng Li > --- > NetworkPkg/IScsiDxe/IScsiDxe.inf | 1 - > NetworkPkg/IScsiDxe/IScsiProto.c | 33 -------------------------------- > 2 files changed, 34 deletions(-) Reviewed-by: Laszlo Ersek