From: "Laszlo Ersek" <lersek@redhat.com>
To: "Ni, Ray" <ray.ni@intel.com>, "Fu, Siyuan" <siyuan.fu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Dong, Eric" <eric.dong@intel.com>
Subject: Re: [PATCH v2 1/2] UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib.
Date: Wed, 12 Feb 2020 10:39:21 +0100 [thread overview]
Message-ID: <19cc2470-a55d-e18f-e236-8ce7fe16180e@redhat.com> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C432825@SHSMSX104.ccr.corp.intel.com>
On 02/12/20 03:52, Ni, Ray wrote:
>
>> +EFI_STATUS
>> +PlatformShadowMicrocode (
>> + IN OUT CPU_MP_DATA *CpuMpData
>> + )
>> +{
>> + return EFI_UNSUPPORTED;
>> +}
>
> Siyuan,
> Better to have comments above "return EFI_UNSUPPORTED" to clarify the
> existing supporting scope.
>
> With that, Reviewed-by: Ray Ni <ray.ni@intel.com>
>
> + Mike for potential comments since he was involved in the offline discussion
> and the final patch doesn't exactly reflect the discussion output.
OK, I'll wait with my ACK until Mike's approval then. Otherwise the v2
changes look OK to me (including your request for more comments).
Thanks
Laszlo
next prev parent reply other threads:[~2020-02-12 9:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 13:36 [PATCH v2 0/2] Move FIT based microcode shadow to platform PEIM Siyuan, Fu
2020-02-11 13:36 ` [PATCH v2 1/2] UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib Siyuan, Fu
2020-02-12 2:52 ` Ni, Ray
2020-02-12 9:39 ` Laszlo Ersek [this message]
2020-02-11 13:36 ` [PATCH v2 2/2] MdePkg: Remove FIT table industry standard header file Siyuan, Fu
2020-02-11 13:41 ` Liming Gao
2020-02-13 1:16 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19cc2470-a55d-e18f-e236-8ce7fe16180e@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox