From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120])
 by mx.groups.io with SMTP id smtpd.web09.2451.1581500369673684531
 for <devel@edk2.groups.io>;
 Wed, 12 Feb 2020 01:39:30 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DexM4c+r;
 spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1581500368;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=sIVACJtKKCsA7MxggxGL4So8QeTgV1On85UXtiGLO1s=;
	b=DexM4c+r6eIlt4ul7O/fwVg67B9+REll8Vs4mtFl+TLuQTqjulovM98YHBN5cg2PCkCDFZ
	dCnrdUSx8BcVbGtJ4zycy71ZGnXblIbIoYy8JGjvpJumYrMPPgb7c7+iEIQ0FTG8eUgKwa
	PsFVP3FqR4l3b/JvLJC1Od+WRPfFA8w=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-291-ppUZYd30PuKI8cNC_6GFcQ-1; Wed, 12 Feb 2020 04:39:25 -0500
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9FAFD100550E;
	Wed, 12 Feb 2020 09:39:23 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-72.ams2.redhat.com [10.36.117.72])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 623B860BF1;
	Wed, 12 Feb 2020 09:39:22 +0000 (UTC)
Subject: Re: [PATCH v2 1/2] UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib.
To: "Ni, Ray" <ray.ni@intel.com>, "Fu, Siyuan" <siyuan.fu@intel.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>,
 "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Dong, Eric" <eric.dong@intel.com>
References: <cover.1581428040.git.siyuan.fu@intel.com>
 <279ff524db95310f9ced9416f3dfdd51d337e719.1581428040.git.siyuan.fu@intel.com>
 <734D49CCEBEEF84792F5B80ED585239D5C432825@SHSMSX104.ccr.corp.intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <19cc2470-a55d-e18f-e236-8ce7fe16180e@redhat.com>
Date: Wed, 12 Feb 2020 10:39:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C432825@SHSMSX104.ccr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-MC-Unique: ppUZYd30PuKI8cNC_6GFcQ-1
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 02/12/20 03:52, Ni, Ray wrote:
> 
>> +EFI_STATUS
>> +PlatformShadowMicrocode (
>> +  IN OUT CPU_MP_DATA             *CpuMpData
>> +  )
>> +{
>> +  return EFI_UNSUPPORTED;
>> +}
> 
> Siyuan,
> Better to have comments above "return EFI_UNSUPPORTED" to clarify the
> existing supporting scope.
> 
> With that, Reviewed-by: Ray Ni <ray.ni@intel.com>
> 
> + Mike for potential comments since he was involved in the offline discussion
> and the final patch doesn't exactly reflect the discussion output.

OK, I'll wait with my ACK until Mike's approval then. Otherwise the v2
changes look OK to me (including your request for more comments).

Thanks
Laszlo