public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH edk2-platforms] Platform/Hisilicon: drop BdsLib inclusion from HiKey .dsc
Date: Thu, 30 Nov 2017 11:13:49 +0000	[thread overview]
Message-ID: <1B71CF47-82F2-4D55-9132-6A6B24AACD6B@linaro.org> (raw)
In-Reply-To: <20171130104631.29600-1-leif.lindholm@linaro.org>



> On 30 Nov 2017, at 10:46, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> 
> The ArmPkg BdsLib has been dropped from EDK2, and is no longer
> required by the Android*Boot applications - so delete the
> reference to fix the resulting build failure.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
> Platform/Hisilicon/HiKey/HiKey.dsc | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
> index 97811eb8d9..957e4d4a9e 100644
> --- a/Platform/Hisilicon/HiKey/HiKey.dsc
> +++ b/Platform/Hisilicon/HiKey/HiKey.dsc
> @@ -411,10 +411,7 @@ [Components.common]
>   #
>   # Fastboot
>   #
> -  EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf {
> -    <LibraryClasses>
> -      BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf
> -  }
> +  EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.inf
> 
> 
>   #
> -- 
> 2.11.0
> 


  reply	other threads:[~2017-11-30 11:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 10:46 [PATCH edk2-platforms] Platform/Hisilicon: drop BdsLib inclusion from HiKey .dsc Leif Lindholm
2017-11-30 11:13 ` Ard Biesheuvel [this message]
2017-11-30 12:09   ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1B71CF47-82F2-4D55-9132-6A6B24AACD6B@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox