public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Update NASM to stable release 2.15.05
@ 2021-10-20 16:51 Michael D Kinney
  2021-10-20 18:05 ` [edk2-devel] " Andrew Fish
  2021-10-21  3:02 ` Ni, Ray
  0 siblings, 2 replies; 5+ messages in thread
From: Michael D Kinney @ 2021-10-20 16:51 UTC (permalink / raw)
  To: devel@edk2.groups.io, Kinney, Michael D, rfc@edk2.groups.io

Hello,

I would like to propose that we update to a newer version of NASM.

	https://www.nasm.us/

The most recent stable version is 2.15.05.

	https://www.nasm.us/pub/nasm/releasebuilds/2.15.05/

NASM 2.15.05 Documentation:

	https://nasm.us/xdoc/2.15.05/html/
	https://nasm.us/xdoc/2.15.05/nasmdoc.pdf


The reason to update is to use a version of NASM that supports 
newer instructions that will allow the .nasm files with
DB statements for instructions to be updated to use 
instruction names.  This improves the readability/maintenance
of the .nasm source files:

	https://nasm.us/xdoc/2.15.05/html/nasmdocb.html#section-B.1.41

Also, the work on tools such as uncrustify to format source files
require tests to make sure the source format changes do not cause
any functional changes.  Compilers support flags for reproducible
builds.  NASM 2.15.05 added the --reproducible flag that provides
the same feature for OBJ files produces by NASM.

	https://nasm.us/xdoc/2.15.05/html/nasmdoc2.html#section-2.1.34


	2.1.34 The --reproducible Option
	
	If this option is given, NASM will not emit information that is
       inherently dependent on the NASM version or different from run to
       run (such as timestamps) into the output file.

Please let me know if there are any concerns with doing this tool update.
If there are no concerns, I will work on patches required to update 
EDK II CI to use NASM 2.15.05 and to update the developer documentation
to require NASM 2.15.05 as the new minimum version.

Thanks,

Mike


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] Update NASM to stable release 2.15.05
  2021-10-20 16:51 Update NASM to stable release 2.15.05 Michael D Kinney
@ 2021-10-20 18:05 ` Andrew Fish
  2021-11-09 18:39   ` Michael D Kinney
  2021-10-21  3:02 ` Ni, Ray
  1 sibling, 1 reply; 5+ messages in thread
From: Andrew Fish @ 2021-10-20 18:05 UTC (permalink / raw)
  To: edk2-devel-groups-io, Mike Kinney; +Cc: rfc@edk2.groups.io

Mike,

Sounds like a good plan. 

Thanks,

Andrew Fish

> On Oct 20, 2021, at 9:51 AM, Michael D Kinney <michael.d.kinney@intel.com> wrote:
> 
> Hello,
> 
> I would like to propose that we update to a newer version of NASM.
> 
> 	https://www.nasm.us/
> 
> The most recent stable version is 2.15.05.
> 
> 	https://www.nasm.us/pub/nasm/releasebuilds/2.15.05/
> 
> NASM 2.15.05 Documentation:
> 
> 	https://nasm.us/xdoc/2.15.05/html/
> 	https://nasm.us/xdoc/2.15.05/nasmdoc.pdf
> 
> 
> The reason to update is to use a version of NASM that supports 
> newer instructions that will allow the .nasm files with
> DB statements for instructions to be updated to use 
> instruction names.  This improves the readability/maintenance
> of the .nasm source files:
> 
> 	https://nasm.us/xdoc/2.15.05/html/nasmdocb.html#section-B.1.41
> 
> Also, the work on tools such as uncrustify to format source files
> require tests to make sure the source format changes do not cause
> any functional changes.  Compilers support flags for reproducible
> builds.  NASM 2.15.05 added the --reproducible flag that provides
> the same feature for OBJ files produces by NASM.
> 
> 	https://nasm.us/xdoc/2.15.05/html/nasmdoc2.html#section-2.1.34
> 
> 
> 	2.1.34 The --reproducible Option
> 	
> 	If this option is given, NASM will not emit information that is
>       inherently dependent on the NASM version or different from run to
>       run (such as timestamps) into the output file.
> 
> Please let me know if there are any concerns with doing this tool update.
> If there are no concerns, I will work on patches required to update 
> EDK II CI to use NASM 2.15.05 and to update the developer documentation
> to require NASM 2.15.05 as the new minimum version.
> 
> Thanks,
> 
> Mike
> 
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Update NASM to stable release 2.15.05
  2021-10-20 16:51 Update NASM to stable release 2.15.05 Michael D Kinney
  2021-10-20 18:05 ` [edk2-devel] " Andrew Fish
@ 2021-10-21  3:02 ` Ni, Ray
  1 sibling, 0 replies; 5+ messages in thread
From: Ni, Ray @ 2021-10-21  3:02 UTC (permalink / raw)
  To: rfc@edk2.groups.io, Kinney, Michael D, devel@edk2.groups.io

Mike,
It‘s very good! It allows further NASM cleanup removing DB instructions.

Thanks,
Ray

-----Original Message-----
From: rfc@edk2.groups.io <rfc@edk2.groups.io> On Behalf Of Michael D Kinney
Sent: Thursday, October 21, 2021 12:52 AM
To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>; rfc@edk2.groups.io
Subject: [edk2-rfc] Update NASM to stable release 2.15.05

Hello,

I would like to propose that we update to a newer version of NASM.

	https://www.nasm.us/

The most recent stable version is 2.15.05.

	https://www.nasm.us/pub/nasm/releasebuilds/2.15.05/

NASM 2.15.05 Documentation:

	https://nasm.us/xdoc/2.15.05/html/
	https://nasm.us/xdoc/2.15.05/nasmdoc.pdf


The reason to update is to use a version of NASM that supports newer instructions that will allow the .nasm files with DB statements for instructions to be updated to use instruction names.  This improves the readability/maintenance of the .nasm source files:

	https://nasm.us/xdoc/2.15.05/html/nasmdocb.html#section-B.1.41

Also, the work on tools such as uncrustify to format source files require tests to make sure the source format changes do not cause any functional changes.  Compilers support flags for reproducible builds.  NASM 2.15.05 added the --reproducible flag that provides the same feature for OBJ files produces by NASM.

	https://nasm.us/xdoc/2.15.05/html/nasmdoc2.html#section-2.1.34


	2.1.34 The --reproducible Option
	
	If this option is given, NASM will not emit information that is
       inherently dependent on the NASM version or different from run to
       run (such as timestamps) into the output file.

Please let me know if there are any concerns with doing this tool update.
If there are no concerns, I will work on patches required to update EDK II CI to use NASM 2.15.05 and to update the developer documentation to require NASM 2.15.05 as the new minimum version.

Thanks,

Mike







^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] Update NASM to stable release 2.15.05
  2021-10-20 18:05 ` [edk2-devel] " Andrew Fish
@ 2021-11-09 18:39   ` Michael D Kinney
  2021-11-09 18:51     ` Andrew Fish
  0 siblings, 1 reply; 5+ messages in thread
From: Michael D Kinney @ 2021-11-09 18:39 UTC (permalink / raw)
  To: Andrew Fish, edk2-devel-groups-io, Kinney, Michael D, Sean Brogan
  Cc: rfc@edk2.groups.io

Hi Andrew,

It looks like the EDK II CI agents were updated to use NASM 2.15.05 back in March of this year.

	https://github.com/tianocore/edk2/blob/0ecdcb6142037dd1cdd08660a2349960bcf0270a/BaseTools/Bin/nasm_ext_dep.yaml

So I think the only remaining task is to update the developer documentation to require NASM 2.15.05 as the new minimum required version.

Do you agree?

Mike

> -----Original Message-----
> From: Andrew Fish <afish@apple.com>
> Sent: Wednesday, October 20, 2021 11:05 AM
> To: edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: rfc@edk2.groups.io
> Subject: Re: [edk2-devel] Update NASM to stable release 2.15.05
> 
> Mike,
> 
> Sounds like a good plan.
> 
> Thanks,
> 
> Andrew Fish
> 
> > On Oct 20, 2021, at 9:51 AM, Michael D Kinney <michael.d.kinney@intel.com> wrote:
> >
> > Hello,
> >
> > I would like to propose that we update to a newer version of NASM.
> >
> > 	https://www.nasm.us/
> >
> > The most recent stable version is 2.15.05.
> >
> > 	https://www.nasm.us/pub/nasm/releasebuilds/2.15.05/
> >
> > NASM 2.15.05 Documentation:
> >
> > 	https://nasm.us/xdoc/2.15.05/html/
> > 	https://nasm.us/xdoc/2.15.05/nasmdoc.pdf
> >
> >
> > The reason to update is to use a version of NASM that supports
> > newer instructions that will allow the .nasm files with
> > DB statements for instructions to be updated to use
> > instruction names.  This improves the readability/maintenance
> > of the .nasm source files:
> >
> > 	https://nasm.us/xdoc/2.15.05/html/nasmdocb.html#section-B.1.41
> >
> > Also, the work on tools such as uncrustify to format source files
> > require tests to make sure the source format changes do not cause
> > any functional changes.  Compilers support flags for reproducible
> > builds.  NASM 2.15.05 added the --reproducible flag that provides
> > the same feature for OBJ files produces by NASM.
> >
> > 	https://nasm.us/xdoc/2.15.05/html/nasmdoc2.html#section-2.1.34
> >
> >
> > 	2.1.34 The --reproducible Option
> >
> > 	If this option is given, NASM will not emit information that is
> >       inherently dependent on the NASM version or different from run to
> >       run (such as timestamps) into the output file.
> >
> > Please let me know if there are any concerns with doing this tool update.
> > If there are no concerns, I will work on patches required to update
> > EDK II CI to use NASM 2.15.05 and to update the developer documentation
> > to require NASM 2.15.05 as the new minimum version.
> >
> > Thanks,
> >
> > Mike
> >
> >
> >
> > 
> >
> >


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] Update NASM to stable release 2.15.05
  2021-11-09 18:39   ` Michael D Kinney
@ 2021-11-09 18:51     ` Andrew Fish
  0 siblings, 0 replies; 5+ messages in thread
From: Andrew Fish @ 2021-11-09 18:51 UTC (permalink / raw)
  To: edk2-devel-groups-io, Mike Kinney; +Cc: Sean Brogan, rfc@edk2.groups.io



> On Nov 9, 2021, at 10:39 AM, Michael D Kinney <michael.d.kinney@intel.com> wrote:
> 
> Hi Andrew,
> 
> It looks like the EDK II CI agents were updated to use NASM 2.15.05 back in March of this year.
> 
> 	https://github.com/tianocore/edk2/blob/0ecdcb6142037dd1cdd08660a2349960bcf0270a/BaseTools/Bin/nasm_ext_dep.yaml
> 
> So I think the only remaining task is to update the developer documentation to require NASM 2.15.05 as the new minimum required version.
> 
> Do you agree?

Yes sounds good.

Thanks,

Andrew Fish

> 
> Mike
> 
>> -----Original Message-----
>> From: Andrew Fish <afish@apple.com>
>> Sent: Wednesday, October 20, 2021 11:05 AM
>> To: edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>
>> Cc: rfc@edk2.groups.io
>> Subject: Re: [edk2-devel] Update NASM to stable release 2.15.05
>> 
>> Mike,
>> 
>> Sounds like a good plan.
>> 
>> Thanks,
>> 
>> Andrew Fish
>> 
>>> On Oct 20, 2021, at 9:51 AM, Michael D Kinney <michael.d.kinney@intel.com> wrote:
>>> 
>>> Hello,
>>> 
>>> I would like to propose that we update to a newer version of NASM.
>>> 
>>> 	https://www.nasm.us/
>>> 
>>> The most recent stable version is 2.15.05.
>>> 
>>> 	https://www.nasm.us/pub/nasm/releasebuilds/2.15.05/
>>> 
>>> NASM 2.15.05 Documentation:
>>> 
>>> 	https://nasm.us/xdoc/2.15.05/html/
>>> 	https://nasm.us/xdoc/2.15.05/nasmdoc.pdf
>>> 
>>> 
>>> The reason to update is to use a version of NASM that supports
>>> newer instructions that will allow the .nasm files with
>>> DB statements for instructions to be updated to use
>>> instruction names.  This improves the readability/maintenance
>>> of the .nasm source files:
>>> 
>>> 	https://nasm.us/xdoc/2.15.05/html/nasmdocb.html#section-B.1.41
>>> 
>>> Also, the work on tools such as uncrustify to format source files
>>> require tests to make sure the source format changes do not cause
>>> any functional changes.  Compilers support flags for reproducible
>>> builds.  NASM 2.15.05 added the --reproducible flag that provides
>>> the same feature for OBJ files produces by NASM.
>>> 
>>> 	https://nasm.us/xdoc/2.15.05/html/nasmdoc2.html#section-2.1.34
>>> 
>>> 
>>> 	2.1.34 The --reproducible Option
>>> 
>>> 	If this option is given, NASM will not emit information that is
>>>      inherently dependent on the NASM version or different from run to
>>>      run (such as timestamps) into the output file.
>>> 
>>> Please let me know if there are any concerns with doing this tool update.
>>> If there are no concerns, I will work on patches required to update
>>> EDK II CI to use NASM 2.15.05 and to update the developer documentation
>>> to require NASM 2.15.05 as the new minimum version.
>>> 
>>> Thanks,
>>> 
>>> Mike
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
> 
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-09 18:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-20 16:51 Update NASM to stable release 2.15.05 Michael D Kinney
2021-10-20 18:05 ` [edk2-devel] " Andrew Fish
2021-11-09 18:39   ` Michael D Kinney
2021-11-09 18:51     ` Andrew Fish
2021-10-21  3:02 ` Ni, Ray

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox