public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Vitaly Cheptsov" <vit9696@protonmail.com>
To: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: devel@edk2.groups.io, Liming Gao <liming.gao@intel.com>,
	Bob Feng <bob.c.feng@intel.com>
Subject: Re: [PATCH 1/2] BaseTools: Change CLANGPDB target to reduce image size
Date: Tue, 24 Mar 2020 06:24:44 +0000	[thread overview]
Message-ID: <1C7FD61E-08E8-4E7C-80CE-EA404E5FF3A0@protonmail.com> (raw)
In-Reply-To: <20200324062045.2263-1-zhiguang.liu@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]

Hello,

While I can imagine this landing as an absolutely last effort resort, at the moment the problem is unclear and unjustified. Do not rush with this patch please and proceed with the discussion in BZ.

Best wishes,
Vitaly 

> 24 марта 2020 г., в 09:20, Zhiguang Liu <zhiguang.liu@intel.com> написал(а):
> 
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2628
> 
> Using target i686-unknown-windows will generate smaller IA32 FV.
> 
> CC: Vitaly Cheptsov <vit9696@protonmail.com>
> CC: Liming Gao <liming.gao@intel.com>
> CC: Bob Feng <bob.c.feng@intel.com>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
> BaseTools/Conf/tools_def.template | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index 2b17d3b297..3d6f6b4b4c 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -2755,7 +2755,7 @@ RELEASE_CLANG38_AARCH64_DLINK_FLAGS = DEF(CLANG38_AARCH64_DLINK_FLAGS) -flto -Wl
> DEFINE CLANGPDB_IA32_PREFIX          = ENV(CLANG_BIN)
> DEFINE CLANGPDB_X64_PREFIX           = ENV(CLANG_BIN)
> 
> -DEFINE CLANGPDB_IA32_TARGET          = -target i686-unknown-windows-gnu
> +DEFINE CLANGPDB_IA32_TARGET          = -target i686-unknown-windows
> DEFINE CLANGPDB_X64_TARGET           = -target x86_64-unknown-windows-gnu
> 
> DEFINE CLANGPDB_WARNING_OVERRIDES    = -Wno-parentheses-equality -Wno-tautological-compare -Wno-tautological-constant-out-of-range-compare -Wno-empty-body -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-option -Wno-microsoft-enum-forward-reference
> --
> 2.25.1.windows.1
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 489 bytes --]

      parent reply	other threads:[~2020-03-24  6:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-24  6:20 [PATCH 1/2] BaseTools: Change CLANGPDB target to reduce image size Zhiguang Liu
2020-03-24  6:20 ` [PATCH 2/2] MdePkg: Use __clang__ to decide if using clang or not Zhiguang Liu
2020-03-24  6:24 ` Vitaly Cheptsov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1C7FD61E-08E8-4E7C-80CE-EA404E5FF3A0@protonmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox