From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail2.protonmail.ch (mail2.protonmail.ch [185.70.40.22]) by mx.groups.io with SMTP id smtpd.web10.821.1585031091448739461 for ; Mon, 23 Mar 2020 23:24:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@protonmail.com header.s=default header.b=s0wC5cez; spf=pass (domain: protonmail.com, ip: 185.70.40.22, mailfrom: vit9696@protonmail.com) Date: Tue, 24 Mar 2020 06:24:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1585031089; bh=vipkIJBGnmHYTUpYWy7tT/9grR11ODuMX6nLPwuMacg=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=s0wC5cez0lGv+qsiNaKbk4IbefvDAYdGit/bp7B2VgJN8ZxkuIea8sZw5x3CMzeHj RrKnlZ3ZP5cULzCWy5tOjB9nCFA7pGjKbPJ7uOZ/kWJ0kfsl7x9dYa3YM2up0Au8cM +YQ2u01jRW0y8whqN35O2Q8K2i4XnPwn+AIKk0e8= To: Zhiguang Liu From: "Vitaly Cheptsov" Cc: devel@edk2.groups.io, Liming Gao , Bob Feng Reply-To: vit9696 Subject: Re: [PATCH 1/2] BaseTools: Change CLANGPDB target to reduce image size Message-ID: <1C7FD61E-08E8-4E7C-80CE-EA404E5FF3A0@protonmail.com> In-Reply-To: <20200324062045.2263-1-zhiguang.liu@intel.com> References: <20200324062045.2263-1-zhiguang.liu@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.7 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,FREEMAIL_REPLYTO_END_DIGIT shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Groupsio-MsgNum: 56128 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha256; boundary="---------------------1b6dba6b5ef605d48e9c9d5ef387a315"; charset=UTF-8 -----------------------1b6dba6b5ef605d48e9c9d5ef387a315 Cc: devel@edk2.groups.io, Liming Gao , Bob Feng Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Date: Tue, 24 Mar 2020 09:24:39 +0300 From: vit9696 In-Reply-To: <20200324062045.2263-1-zhiguang.liu@intel.com> Message-Id: <1C7FD61E-08E8-4E7C-80CE-EA404E5FF3A0@protonmail.com> Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) References: <20200324062045.2263-1-zhiguang.liu@intel.com> Subject: Re: [PATCH 1/2] BaseTools: Change CLANGPDB target to reduce image size To: Zhiguang Liu X-Mailer: Apple Mail (2.3608.60.0.2.5) Hello, While I can imagine this landing as an absolutely last effort resort, at = the moment the problem is unclear and unjustified. Do not rush with this = patch please and proceed with the discussion in BZ. Best wishes, Vitaly=20 > 24 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2020 =D0=B3., =D0=B2 09:20, Zhiguang = Liu =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0= =B0): >=20 >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2628 >=20 > Using target i686-unknown-windows will generate smaller IA32 FV. >=20 > CC: Vitaly Cheptsov > CC: Liming Gao > CC: Bob Feng > Signed-off-by: Zhiguang Liu > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Conf/tools_def.template = b/BaseTools/Conf/tools_def.template > index 2b17d3b297..3d6f6b4b4c 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -2755,7 +2755,7 @@ RELEASE_CLANG38_AARCH64_DLINK_FLAGS =3D = DEF(CLANG38_AARCH64_DLINK_FLAGS) -flto -Wl > DEFINE CLANGPDB_IA32_PREFIX =3D ENV(CLANG_BIN) > DEFINE CLANGPDB_X64_PREFIX =3D ENV(CLANG_BIN) >=20 > -DEFINE CLANGPDB_IA32_TARGET =3D -target = i686-unknown-windows-gnu > +DEFINE CLANGPDB_IA32_TARGET =3D -target i686-unknown-windows > DEFINE CLANGPDB_X64_TARGET =3D -target = x86_64-unknown-windows-gnu >=20 > DEFINE CLANGPDB_WARNING_OVERRIDES =3D -Wno-parentheses-equality = -Wno-tautological-compare = -Wno-tautological-constant-out-of-range-compare -Wno-empty-body = -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-option = -Wno-microsoft-enum-forward-reference > -- > 2.25.1.windows.1 >=20 -----------------------1b6dba6b5ef605d48e9c9d5ef387a315 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: ProtonMail wsBmBAEBCAAQBQJeeaeoCRBPsoxt7Hy0xQAKCRBPsoxt7Hy0xVMrB/0YV9my jStPUlJqAYuyEwjNcFhNBbNC1O4XMgNLjxgGylvEcYVofKqREs2dLVf/ehb9 RJhVBczl4ih+RIB2RAHfa09C4erVRx+cofI92a2ngVR70/K8vFaV5dwHN4Kt fY9kD+XCjsAPtZVGhrUO8YyD2NQT7iGFPmzsFNa/u/wXIyZjbBKBm274EEzX lIzzm6b1zPtmyVx7Q+QgNTwcmJiwk6x10Yoa7D/l/JoKbAeWsi1P20wr7rh3 c4FDSfYIH3+B3SOHFVJDC9u5y7Bob78PCI3FBOMckBejxSHVmlDSZAgnrSCK 8A2GZBNhJrxkE4+4WxauAIMJkMboXWWi9QGT =+Fmw -----END PGP SIGNATURE----- -----------------------1b6dba6b5ef605d48e9c9d5ef387a315--