From: "Vijayenthiran Subramaniam" <vijayenthiran.subramaniam@arm.com>
To: Sami Mujawar <Sami.Mujawar@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Thomas Abraham <thomas.abraham@arm.com>, nd <nd@arm.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v3 2/3] Platform/ARM/SgiPkg: Add HMAT ACPI table for RdN1EdgeX2
Date: Thu, 8 Apr 2021 12:55:49 +0000 [thread overview]
Message-ID: <1CB2E554-3555-4B29-ABD4-D52A50369EEE@arm.com> (raw)
In-Reply-To: <3142.1617820632237714937@groups.io>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
Hi Sami,
Agree with the suggestion. Please make the changes.
Regards,
Vijay
From: "Sami Mujawar via Groups.Io" <sami.mujawar=arm.com@groups.io>
Reply to: Sami Mujawar <Sami.Mujawar@arm.com>
Date: Thursday, 8 April 2021 at 12:07 AM
To: Vijayenthiran Subramaniam <Vijayenthiran.Subramaniam@arm.com>, "devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v3 2/3] Platform/ARM/SgiPkg: Add HMAT ACPI table for RdN1EdgeX2
Hi Vijay,
+#define HMAT_STRUCTURE_MEMORY_SIDE_CACHE_INFO_CACHE_ATTRIBUTES_INIT( \
+ TotalCacheLevels, CacheLevel, CacheAssociativity, WritePolicy, CacheLineSize \
+ ) \
+{ \
+ TotalCacheLevels, CacheLevel, CacheAssociativity, WritePolicy, CacheLineSize \
+}
This macros is again repeated in patch 3/3. I think this could be moved to Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h.
If you agree I can make this change locally before pushing this series.
Regards,
Sami Mujawar
[-- Attachment #2: Type: text/html, Size: 3335 bytes --]
next prev parent reply other threads:[~2021-04-08 12:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 11:01 [edk2-platforms] [PATCH v3 0/3] Add HMAT tables for RD multi-chip platforms Vijayenthiran Subramaniam
2021-02-17 11:01 ` [edk2-platforms] [PATCH v3 1/3] Platform/ARM/SgiPkg: Add helper macros for HMAT table Vijayenthiran Subramaniam
2021-02-17 11:01 ` [edk2-platforms] [PATCH v3 2/3] Platform/ARM/SgiPkg: Add HMAT ACPI table for RdN1EdgeX2 Vijayenthiran Subramaniam
2021-04-07 18:37 ` [edk2-devel] " Sami Mujawar
2021-04-08 12:55 ` Vijayenthiran Subramaniam [this message]
2021-02-17 11:01 ` [edk2-platforms] [PATCH v3 3/3] Platform/ARM/SgiPkg: Add HMAT ACPI table for RD-V1-MC Vijayenthiran Subramaniam
2021-04-08 14:51 ` [edk2-devel] [edk2-platforms] [PATCH v3 0/3] Add HMAT tables for RD multi-chip platforms Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1CB2E554-3555-4B29-ABD4-D52A50369EEE@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox