From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by mx.groups.io with SMTP id smtpd.web11.46186.1681928717171511863 for ; Wed, 19 Apr 2023 11:25:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@posteo.de header.s=2017 header.b=K0Z4yMGh; spf=pass (domain: posteo.de, ip: 185.67.36.66, mailfrom: mhaeuser@posteo.de) Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 28024240314 for ; Wed, 19 Apr 2023 20:25:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1681928715; bh=acn3m0/5nXeYOxi8rDyBEiKOqwVTslgcCXMPZYoscaU=; h=From:Subject:Date:Cc:To:From; b=K0Z4yMGh0EuG2U543gqCz50uK5IsYAkL/jM2Ntb5wl44eOKZM9dsKdI021RRqdFgS CYgF+4oq+/Z7RthvWgFnghHAGDAqYMx8VscN6QBMH5z56ni70oGMxlvXQie+xKmtpv WeXW65vB21Z8OI/ARDprme0qPds8WoY8AOaD31H4EE8/LDdBX5hM7pGP7zL2JRkat/ +nURUK6Fj9pX68JBKwIoQOcT1N2VO8QySBqz1LVJKgZ+zPPeRAAJfJfrncY8AQ6k3u GdEyAUk/CdiDQzChOlOa+uVeqg7hdL6eqHkLg9xiSirsm+7Gi4fR1Y7yBEK2OCAsOp kpRlwCjR3uUMA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q1q2x6pLmz6trm; Wed, 19 Apr 2023 20:25:13 +0200 (CEST) From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= Message-Id: <1CE9D3E9-4D3E-49B7-B66B-527B16322980@posteo.de> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Subject: Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN() Date: Wed, 19 Apr 2023 18:25:03 +0000 In-Reply-To: Cc: edk2-devel-groups-io , Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Vitaly Cheptsov To: Ard Biesheuvel References: <46CED01C-BEA6-49F3-9634-051DC63D248C@posteo.de>

<696924B3-EF5B-4799-AAD9-E090C97D9AA9@posteo.de> Content-Type: multipart/alternative; boundary="Apple-Mail=_91A92A77-24D3-4CA2-A4BC-1CA4CF667F96" --Apple-Mail=_91A92A77-24D3-4CA2-A4BC-1CA4CF667F96 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 19. Apr 2023, at 20:03, Ard Biesheuvel wrote: >=20 > Your branch seems to be missing = 16e0969ef775b898ac700f3261d76030b8ab9ef0 >=20 > "ArmVirtPkg/ArmVirtQemu: Use PEI flavor of ArmMmuLib for all PEIMs" That's correct (because that commit is after the last commit I managed = to reproduce the issue with), but I don't see how this commit would fix = the issue. As I said, the symptom is that PeiCore memory is badly = corrupted and the stall happens due to executing said corruption, not = due to jumping to NULL. Those broken branches I linked can all be made = work by rolling back the change to MemoryAllocationLib (which changes = the code size, thus misaligns *something*). In fact, using the broken = variant only for MemoryInitPei is sufficient to reproduce the issue, = other modules don't seem to be involved. Best regards, Marvin= --Apple-Mail=_91A92A77-24D3-4CA2-A4BC-1CA4CF667F96 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On 19. Apr = 2023, at 20:03, Ard Biesheuvel <ardb@kernel.org> = wrote:

Your branch seems to be = missing 16e0969ef775b898ac700f3261d76030b8ab9ef0

"ArmVirtPkg/ArmVirtQemu: Use PEI flavor of = ArmMmuLib for all PEIMs"

That's = correct (because that commit is after the last commit I managed to = reproduce the issue with), but I don't see how this commit would fix the = issue. As I said, the symptom is that PeiCore memory is badly corrupted = and the stall happens due to executing said corruption, not due to = jumping to NULL. Those broken branches I linked can all be made work by = rolling back the change to MemoryAllocationLib (which changes the code = size, thus misaligns *something*). In fact, using the broken variant = only for MemoryInitPei is sufficient to reproduce the issue, other = modules don't seem to be involved.

Best = regards,

Marvin

= --Apple-Mail=_91A92A77-24D3-4CA2-A4BC-1CA4CF667F96--