From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by mx.groups.io with SMTP id smtpd.web11.1072.1608054250302607323 for ; Tue, 15 Dec 2020 09:44:16 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: ispras.ru, ip: 83.149.199.84, mailfrom: cheptsov@ispras.ru) Received: from [192.168.1.2] (unknown [77.232.9.83]) by mail.ispras.ru (Postfix) with ESMTPSA id B10CC40A9285; Tue, 15 Dec 2020 17:44:07 +0000 (UTC) From: "Vitaly Cheptsov" Message-Id: <1DCCE202-8411-4ECE-A157-AEB87364B45C@ispras.ru> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for drives in RAID mode Date: Tue, 15 Dec 2020 20:44:07 +0300 In-Reply-To: Cc: "devel@edk2.groups.io" , "Wu, Hao A" , "Ni, Ray" , "Wang, Jian J" , "Albecki, Mateusz" , Laszlo Ersek To: "Kinney, Michael D" References: <20201211092502.21763-1-cheptsov@ispras.ru> <64FCA78C-6E93-4126-AF7F-D586865C408B@ispras.ru> X-Mailer: Apple Mail (2.3654.40.0.2.32) X-Groupsio-MsgNum: 68868 Content-Type: multipart/signed; boundary="Apple-Mail=_DE433989-8A33-49AE-A1A3-95EB911E734E"; protocol="application/pgp-signature"; micalg=pgp-sha512 --Apple-Mail=_DE433989-8A33-49AE-A1A3-95EB911E734E Content-Type: multipart/alternative; boundary="Apple-Mail=_B35F9807-709C-4FEB-987E-D5D60E8B7D00" --Apple-Mail=_B35F9807-709C-4FEB-987E-D5D60E8B7D00 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Unfortunately not. That is basically the issue. When there is a preference,= it is possible to ask the user to set it. However, for certain Dell machin= es, we have an issue with, it is not possible to select AHCI mode in the fi= rmware preferences, and these users end up with unconfigurable RAID. Best regards, Vitaly > 15 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3., =D0=B2 20:41, Kinney, Michael D =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0= ): >=20 > But do the systems allow the user to configure the FW that runs earlier?= Can you require to users to configure their platforms correctly? >=20 > Thanks, >=20 > Mike >=20 > From: devel@edk2.groups.io > On Behalf Of Vitaly Cheptsov > Sent: Tuesday, December 15, 2020 9:34 AM > To: Kinney, Michael D > > Cc: devel@edk2.groups.io ; Wu, Hao A >; Ni, Ray >; Wang, Jian J >; Albecki, Mateusz >; Laszlo Ersek > > Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Ad= d support for drives in RAID mode >=20 > Hi Michael, >=20 > I believe Intel SATA controllers have non-standard lockdown bits, which = do not let you reconfigure them as soon as the initialisation is over. Sinc= e we start much later (outside of the firmware), we can no longer control t= his. >=20 > Best regards, > Vitaly >=20 >=20 > 15 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3., =D0=B2 19:58, Kinney, Michael D > =D0=BD=D0=B0= =D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >=20 > Hi Vitaly, >=20 > Can you please explain why the controller can not be configured in a non= -RAID mode? >=20 > Thanks, >=20 > Mike >=20 > From: devel@edk2.groups.io > On Behalf Of Vitaly Cheptsov > Sent: Tuesday, December 15, 2020 12:58 AM > To: Wu, Hao A >; devel@ed= k2.groups.io > Cc: Ni, Ray >; Wang, Jian J <= jian.j.wang@intel.com >; Albecki, Mateusz >; Laszlo Ersek <= lersek@redhat.com >; Kinney, Michael D > > Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Ad= d support for drives in RAID mode >=20 > Hello, >=20 > 1. Could you help to change the BZ tracker https://bugzilla.tianocore.or= g/show_bug.cgi?id=3D3118 to a "Tiano Feature Requests"? > For me, it looks more like a feature request. >=20 > Sure, done. >=20 > 2. Could you help to include 'AtaAtapiPassThru' in the BZ tracker subjec= t for better reference? >=20 > Also done. >=20 > 3. For Patch 2/2, is there any reason to clear the bits: > EFI_ATA_PASS_THRU_ATTRIBUTES_PHYSICAL > EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_PHYSICAL > If the drives are intended to be used as non-RAID devices, I think both = the ATTRIBUTES_PHYSICAL & ATTRIBUTES_LOGICAL should be set for the controll= er according to the UEFI Spec. >=20 > I am not quite positive why this was needed (the patch was prepared a fe= w months ago), but I will make a comment in V2 when we test it on real hard= ware. I think it was required to take the right path in the driver. >=20 > DuetPkg was removed from edk2. > If the change is specially for DUET use case, I am afraid we cannot acce= pt this change. >=20 > This is not the DuetPkg from EDK II, but ours[1]. Thus your claim does n= ot apply. >=20 > I agree it would be better to configure the platform so the SATA control= ler is in its non-RAID mode. >=20 > Agree, but in this case it is not feasible. >=20 > If the controller is in RAID mode, then the OS that is booted may have a= SATA RAID driver > that can configure the drives in RAID mode. Then, if the UEFI FW treats= it as non RAID, it > may not be bootable, and configuration actions in UEFI may corrupt data = on the RAID configured > drives. For this reason, I am not in favor of adding a PCD. >=20 > Actually some operating systems have to introduce workarounds for this a= s well, and no, in this particular case the OS does not treat the drive as = RAID either. >=20 > If there are no other review comments besides the attributes, I will pro= ceed with V2 in the coming days. >=20 > Best regards, > Vitaly >=20 > [1] https://github.com/acidanthera/OpenCorePkg >=20 >=20 >=20 >=20 > 15 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3., =D0=B2 06:54, Kinney, Michael D > =D0=BD=D0=B0= =D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >=20 > I agree it would be better to configure the platform so the SATA control= ler is in its non-RAID mode. >=20 > If the controller is in RAID mode, then the OS that is booted may have a= SATA RAID driver > that can configure the drives in RAID mode. Then, if the UEFI FW treats= it as non RAID, it > may not be bootable, and configuration actions in UEFI may corrupt data = on the RAID configured > drives. For this reason, I am not in favor of adding a PCD. >=20 > Mike >=20 >=20 >=20 > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Wu, Hao A > Sent: Monday, December 14, 2020 5:53 PM > To: Ni, Ray >; devel@edk2.gro= ups.io ; cheptsov@ispras.ru > Cc: Wang, Jian J >;= Albecki, Mateusz >; Laszlo Ersek > > Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Ad= d support for drives in RAID mode >=20 >=20 >=20 > -----Original Message----- > From: Ni, Ray > > Sent: Tuesday, December 15, 2020 9:45 AM > To: devel@edk2.groups.io ; cheptsov@ispras.= ru > Cc: Wang, Jian J >;= Wu, Hao A >; > Albecki, Mateusz >; Laszlo Ersek > > > Subject: RE: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: > Add support for drives in RAID mode >=20 > DuetPkg was removed from edk2. > If the change is specially for DUET use case, I am afraid we cannot acce= pt this > change. >=20 > Hao, > Can this change benefit a general use case? >=20 >=20 > Hello Ray, >=20 > My understanding to the proposed PCD is that drives behind a RAID mode S= ATA controller can be configured to working in > non-RAID mode (acting like individual drives). >=20 > As for the DuetPkg, below is a previous comment from Vitaly: > "there is no firmware preference for that (Hao: configure the controller= to non-RAID mode). The firmware does not support > UEFI, and we are running through DuetPkg." >=20 > Best Regards, > Hao Wu >=20 >=20 >=20 >=20 >=20 > Thanks, > Ray >=20 >=20 >=20 > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Vitaly > Cheptsov > Sent: Friday, December 11, 2020 5:25 PM > To: devel@edk2.groups.io > Cc: Vitaly Cheptsov >; Wa= ng, Jian J > >; Wu, Hao A >; Albecki, > Mateusz >; = Laszlo Ersek > > Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: > Add >=20 >=20 > support for drives in RAID mode >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3118 >=20 > This resolves the problem of using drivers connected to Intel G33 > builtin SATA controller when run from DuetPkg when it can only be > configured in RAID mode through the firmware settings. >=20 > Cc: Jian J Wang > > Cc: Hao A Wu > > Cc: Mateusz Albecki > > Cc: Laszlo Ersek > > Signed-off-by: Vitaly Cheptsov > > --- > MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > index ab06e2833c..301335c967 100644 > --- a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > +++ b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c > @@ -324,7 +324,7 @@ SataControllerSupported ( > return EFI_UNSUPPORTED; > } >=20 > - if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData)) { > + if (IS_PCI_IDE (&PciData) || IS_PCI_SATADPA (&PciData) || > + IS_PCI_RAID (&PciData)) { > return EFI_SUCCESS; > } >=20 > @@ -465,7 +465,7 @@ SataControllerStart ( > if (IS_PCI_IDE (&PciData)) { > Private->IdeInit.ChannelCount =3D IDE_MAX_CHANNEL; > Private->DeviceCount =3D IDE_MAX_DEVICES; > - } else if (IS_PCI_SATADPA (&PciData)) { > + } else if (IS_PCI_SATADPA (&PciData) || IS_PCI_RAID (&PciData)) { > // > // Read Ports Implemented(PI) to calculate max port number (0 based)= . > // > -- > 2.24.3 (Apple Git-128) >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to th= is group. > View/Reply Online (#68707): > https://edk2.groups.io/g/devel/message/68707 > Mute This Topic: https://groups.io/mt/78875596/1712937 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com ] > -=3D-=3D-=3D-=3D-=3D-=3D >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 --Apple-Mail=_B35F9807-709C-4FEB-987E-D5D60E8B7D00 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Unfortunately not. That i= s basically the issue. When there is a preference, it is possible to ask th= e user to set it. However, for certain Dell machines, we have an issue with= , it is not possible to select AHCI mode in the firmware preferences, and t= hese users end up with unconfigurable RAID.

<= /div>
Best regards,
Vitaly

= 15 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3., =D0=B2 20:41, Kinney, Michael D <michael.d.kinney@int= el.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0):
But do the systems a= llow the user to configure the FW that runs earlier? =  Can you require t= o users to configure their platforms correctly?
 <= /o:p>
Thanks,
=  
Mike
 
From: devel@edk2.groups.io <devel@edk2.groups.io>=  On Behalf = Of Vitaly CheptsovSent:&n= bsp;Tuesday, December 15, 2020 9:34 AM
T= o: Kinney, Michael D = <michael.d.kinney@intel.com>Cc:&nb= sp;devel@edk2.groups.io; Wu, Hao A = <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Albecki, Mateusz <mateusz.albecki@intel.com>; Laszlo Ers= ek <lersek@redhat.com>
Subject: = Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support fo= r drives in RAID mode
 
Hi Michael,
&n= bsp;
I believe Intel SATA controllers have non-standard lockdown = bits, which do not let you reconfigure them as soon as the initialisation i= s over. Since we start much later (outside of the firmware), we can no long= er control this.
 
Best regards,
Vitaly


15 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3.= , =D0=B2 19:58, Kinney, Michael D <mi= chael.d.kinney@intel.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB= (=D0=B0):
 
Hi Vitaly,
 
Can you please ex= plain why the controller can not be configured in a non-RAID mode?
 
Thanks,=
 
<= div style=3D"margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibr= i, sans-serif;" class=3D"">Mike
=  
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Vitaly Cheptsov
Sent: Tuesday, Dec= ember 15, 2020 12:58 AM
To: Wu, Hao A <hao.a.wu@intel.com>= ;; devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.= wang@intel.com>; Albecki, Mateusz <mateusz.albecki@intel.= com>; Laszlo Ersek <lersek@redhat.com>; Kinney, M= ichael D <michael.d.kinney@intel.com>
Subject: Re= : [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe: Add support for = drives in RAID mode
 
Hello,
 <= o:p class=3D"">
1. Could you help to change the = BZ tracker <= span style=3D"color: purple;" class=3D"">https://bugzilla.tianocore.org/sho= w_bug.cgi?id=3D3118 to a "Tiano Feature Requests"?
For me, it looks more like a feature request.<= /span>
 
= Sure, done.
<= div class=3D"">
 
2. Could you help to include 'AtaAtapiP= assThru' in the BZ tracker subject for better reference?
 
Also done.
<= div class=3D"">
 
3. For Patch 2/2, is there any reason t= o clear the bits:
EFI_ATA_PASS_THRU_ATTRIBUTES_PHYSICAL
EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_PHYSICAL
If the dr= ives are intended to be used as non-RAID devices, I think both the ATTRIBUT= ES_PHYSICAL & ATTRIBUTES_LOGICAL should be set for the controller accor= ding to the UEFI Spec.
 
I am not quite positive why this = was needed (the patch was prepared a few months ago), but I will make a com= ment in V2 when we test it on real hardware. I think it was required to tak= e the right path in the driver.
 
DuetPkg was remove= d from edk2.
If the change is specially for DUET use case, I = am afraid we cannot accept this change.
<= /div>
 
This is not t= he DuetPkg from EDK II, but ours[1]. Thus your claim does not apply.
 
= I agree it would be better to configure the platform so th= e SATA controller is in its non-RAID mode.
 
Agree, but in= this case it is not feasible.
 
If the controller = is in RAID mode, then the OS that is booted may have a SATA RAID driver
that can configure the drives in RAID mode.  Then, if the U= EFI FW treats it as non RAID, it
may not be bootable, and con= figuration actions in UEFI may corrupt data on the RAID configured
drives.  For this reason, I am not in favor of adding a PCD.
 
= Actually some operating systems have to introduce workarou= nds for this as well, and no, in this particular case the OS does not treat= the drive as RAID either.
=  
If there are no othe= r review comments besides the attributes, I will proceed with V2 in the com= ing days.
 
Best regards,=
Vitaly
<= /div>
 
 



15 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3.= , =D0=B2 06:54, Kinney, Michael D <michael.d.kinney@intel.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0):<= /o:p>
-----Original Message-----
From: Ni, = Ray <= ray.ni@intel.com>
Sent: Tuesday, December 15, 2= 020 9:45 AM
To: devel@edk2.groups.io;&nbs= p;cheptsov@ispras.ru
Cc: Wang, Jian J <jian.j.wa= ng@intel.com>; Wu, Hao A <hao.a.wu@intel.com
>;
Albecki, Mateusz <mateusz.albecki@intel.com>; = Laszlo Ersek
<lersek@redhat.com>
S= ubject: RE: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDxe:
Add support for drives in RAID mode

Du= etPkg was removed from edk2.
If the change is specially for D= UET use case, I am afraid we cannot accept this
change.

Hao,
Can this change benefit a genera= l use case?


Hello Ray,

My understanding to the prop= osed PCD is that drives behind a RAID mode SATA controller can be configure= d to working in
non-RAID mode (acting like individual drives)= .

As for the DuetPkg, below is a previous comm= ent from Vitaly:
"there is no firmware preference for that (H= ao: configure the controller to non-RAID mode). The firmware does not suppo= rt
UEFI, and we are running through DuetPkg."
<= br class=3D"">Best Regards,
Hao Wu





Thanks,
Ray



<= div style=3D"margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibr= i, sans-serif;" class=3D"">-----Original Message-----
From: devel@edk2= .groups.io <= ;dev= el@edk2.groups.io> On Behalf Of Vitaly
Cheptsov=
Sent: Friday, December 11, 2020 5:25 PM
To: 
devel@edk2.groups.io=
Cc: Vitaly Cheptsov <cheptsov@ispras.ru>; Wang, J= ian J
<jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu= @intel.com>; Albecki,
Mateusz <mateusz.albe= cki@intel.com>; Laszlo Ersek <lersek@redhat.com>Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/SataControllerDx= e:
Add

=

support for drives in RAID mode

REF:=  ht= tps://bugzilla.tianocore.org/show_bug.cgi?id=3D3118

This resolves the problem of using drivers connected to In= tel G33
builtin SATA controller when run from DuetPkg when it= can only be
configured in RAID mode through the firmware set= tings.

Cc: Jian J Wang <jian.j.wang@intel.com<= /span>>
Cc: Hao A Wu <hao.a.wu@intel.com>Cc: Mateusz Albecki <mateusz.albecki@intel.com&= gt;
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Vitaly Cheptsov <cheptsov@ispras.ru>
---
MdeModulePkg/Bus/Pci/SataControllerDxe/SataContr= oller.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions= (-)

diff --git a/MdeModulePkg/Bus/Pci/SataCont= rollerDxe/SataController.c
b/MdeModulePkg/Bus/Pci/SataControl= lerDxe/SataController.c
index ab06e2833c..301335c967 100644--- a/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c<= br class=3D"">+++ b/MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c=
@@ -324,7 +324,7 @@ SataControllerSupported (
=     return EFI_UNSUPPORTED;
  }=

-  if (IS_PCI_IDE (&PciData) || IS_P= CI_SATADPA (&PciData)) {
+  if (IS_PCI_IDE (&Pci= Data) || IS_PCI_SATADPA (&PciData) ||
+ IS_PCI_RAID (&= ;PciData)) {
    return EFI_SUCCESS;
  }

@@ -465,7 +465,7 @@ Sa= taControllerStart (
  if (IS_PCI_IDE (&PciData)= ) {
    Private->IdeInit.ChannelCount = = =3D IDE_MAX_CHANNEL;
    Private->Dev= iceCount          =3D IDE_MAX_= DEVICES;
-  } else if (IS_PCI_SATADPA (&PciData)) {<= br class=3D"">+  } else if (IS_PCI_SATADPA (&PciData) || IS_PCI_RA= ID (&PciData)) {
    //
    // Read Ports Implemented(PI) to calculate max por= t number (0 based).
    //
= --
2.24.3 (Apple Git-128)



-=3D-=3D-=3D-=3D-=3D-=3D
Groups.io Links: You receive all message= s sent to this group.
View/Reply Online (#68707):
https://edk2.groups.io/g/devel/message/68707
Mute This Topic: https://groups.io/mt/78875596/1712937
Gro= up Owner: devel+owner@e= dk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub=  [ray.ni@intel.com]
-=3D-=3D-=3D-=3D-=3D-=3D






<= /p>

<= /div>
 

--Apple-Mail=_B35F9807-709C-4FEB-987E-D5D60E8B7D00-- --Apple-Mail=_DE433989-8A33-49AE-A1A3-95EB911E734E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEsLABAI5Y5VbvBdmpL8K2O86Eyz4FAl/Y9ecACgkQL8K2O86E yz7Klg/+Pri4Iw6DgZB/vv1CfM9jSu7/a9rmuOgQYbWlCC41QGuljtEVn10EROvw ArRk0o0/NqDFVZ3lKZrB7MyfU6FlQoIxVXbPmp7Wkc4KE2NPtc7fXncsDcSqxhsQ turDtFL0sylBXYA0COn388T3wqolFDaZKxqHm+aF+P4uBDqpCO4DHk9p/3abXe8V 1eVwYHsoU3LiD49RKom531aEUWF3EZ/Hf8B5p2Uy0ZjKRJTi/Ffns2QB0xNQfU26 UmODoIxoKDWfOv2YtMPQb2Wug4nTruFq/DLMiDV8mp3wzpSGu9OstsGET0eroWyo q5odutmuxaMG1rykAukjPP8fkHv/YZpLOAUTuI2wJrmvYG9BFUijFW5V4s3wgsBv JmfFmF0PrhxdkMTLYw9LNouUoxoIjkNGgaiznuSSIw4YNtoaqdWeTDIUNNNy+muQ gZUVXabZarfG0aQQVq6tLhfWyClHY7uh3hqht8UoVapj4xUFJg7yJxlxUyk8FiOo KE/gj5/YcLlvlwcE9yqf2lF8P9zHBIR7PgnmhZpkujb4UBmOI/M2bdmNn/Musix1 AaiAEv580r9yj61Nc6GuanTazt0aIixIv2VfNq64BTJC2XvP2+0v34s2qDDbiGDC YEZwWWvX0h9g+xl2vL4yWoLxYV8MJR3D1YTiqvwGB2YyDdZh32c= =96KU -----END PGP SIGNATURE----- --Apple-Mail=_DE433989-8A33-49AE-A1A3-95EB911E734E--