From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Bjorge, Erik C" <erik.c.bjorge@intel.com>
Cc: "Desimone, Ashley E" <ashley.e.desimone@intel.com>,
"Pandya, Puja" <puja.pandya@intel.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: Re: [edk2-devel] [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py
Date: Fri, 31 Jan 2020 06:56:06 +0000 [thread overview]
Message-ID: <1E8AB7C1-77B4-4367-9BCC-3123BB7FE8C0@intel.com> (raw)
In-Reply-To: <93fef0f8caa445fd6c01a968f87a6de639fe0fd2.1579728839.git.erik.c.bjorge@intel.com>
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
On 1/22/20, 1:55 PM, "devel@edk2.groups.io on behalf of Bjorge, Erik C" <devel@edk2.groups.io on behalf of erik.c.bjorge@intel.com> wrote:
On Ubuntu the script final_copy.py was not able to run without
prepending ./ to the script name.
Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
build-scripts/build_linux_installer.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/build-scripts/build_linux_installer.py b/build-scripts/build_linux_installer.py
index 4501dec..0130552 100755
--- a/build-scripts/build_linux_installer.py
+++ b/build-scripts/build_linux_installer.py
@@ -55,7 +55,7 @@ def main():
# Step 4: Package installer files
try:
- subprocess.run('final_copy.py', check=True)
+ subprocess.run(os.path.join('.', 'final_copy.py'), check=True)
except:
print('Failed to generate installer package')
return 1
--
2.21.0.windows.1
prev parent reply other threads:[~2020-01-31 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 21:55 [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py Bjorge, Erik C
2020-01-23 18:48 ` [edk2-devel] " Desimone, Ashley E
2020-01-31 6:56 ` Nate DeSimone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1E8AB7C1-77B4-4367-9BCC-3123BB7FE8C0@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox