public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py
@ 2020-01-22 21:55 Bjorge, Erik C
  2020-01-23 18:48 ` [edk2-devel] " Desimone, Ashley E
  2020-01-31  6:56 ` Nate DeSimone
  0 siblings, 2 replies; 3+ messages in thread
From: Bjorge, Erik C @ 2020-01-22 21:55 UTC (permalink / raw)
  To: devel; +Cc: Nate DeSimone, Ashley DeSimone, Puja Pandya, Bret Barkelew

On Ubuntu the script final_copy.py was not able to run without
prepending ./ to the script name.

Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 build-scripts/build_linux_installer.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build-scripts/build_linux_installer.py b/build-scripts/build_linux_installer.py
index 4501dec..0130552 100755
--- a/build-scripts/build_linux_installer.py
+++ b/build-scripts/build_linux_installer.py
@@ -55,7 +55,7 @@ def main():
 
     # Step 4: Package installer files
     try:
-        subprocess.run('final_copy.py', check=True)
+        subprocess.run(os.path.join('.', 'final_copy.py'), check=True)
     except:
         print('Failed to generate installer package')
         return 1
-- 
2.21.0.windows.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py
  2020-01-22 21:55 [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py Bjorge, Erik C
@ 2020-01-23 18:48 ` Desimone, Ashley E
  2020-01-31  6:56 ` Nate DeSimone
  1 sibling, 0 replies; 3+ messages in thread
From: Desimone, Ashley E @ 2020-01-23 18:48 UTC (permalink / raw)
  To: devel@edk2.groups.io, Bjorge, Erik C
  Cc: Desimone, Nathaniel L, Pandya, Puja, Bret Barkelew

Reviewed-by: Ashley Desimone <ashley.e.desimone@intel.com>

-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bjorge, Erik C
Sent: Wednesday, January 22, 2020 1:55 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py

On Ubuntu the script final_copy.py was not able to run without prepending ./ to the script name.

Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 build-scripts/build_linux_installer.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build-scripts/build_linux_installer.py b/build-scripts/build_linux_installer.py
index 4501dec..0130552 100755
--- a/build-scripts/build_linux_installer.py
+++ b/build-scripts/build_linux_installer.py
@@ -55,7 +55,7 @@ def main():
 
     # Step 4: Package installer files
     try:
-        subprocess.run('final_copy.py', check=True)
+        subprocess.run(os.path.join('.', 'final_copy.py'), check=True)
     except:
         print('Failed to generate installer package')
         return 1
--
2.21.0.windows.1





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py
  2020-01-22 21:55 [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py Bjorge, Erik C
  2020-01-23 18:48 ` [edk2-devel] " Desimone, Ashley E
@ 2020-01-31  6:56 ` Nate DeSimone
  1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2020-01-31  6:56 UTC (permalink / raw)
  To: devel@edk2.groups.io, Bjorge, Erik C
  Cc: Desimone, Ashley E, Pandya, Puja, Bret Barkelew

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

On 1/22/20, 1:55 PM, "devel@edk2.groups.io on behalf of Bjorge, Erik C" <devel@edk2.groups.io on behalf of erik.c.bjorge@intel.com> wrote:

    On Ubuntu the script final_copy.py was not able to run without
    prepending ./ to the script name.
    
    Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
    Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
    Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
    Cc: Puja Pandya <puja.pandya@intel.com>
    Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
    ---
     build-scripts/build_linux_installer.py | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/build-scripts/build_linux_installer.py b/build-scripts/build_linux_installer.py
    index 4501dec..0130552 100755
    --- a/build-scripts/build_linux_installer.py
    +++ b/build-scripts/build_linux_installer.py
    @@ -55,7 +55,7 @@ def main():
     
         # Step 4: Package installer files
         try:
    -        subprocess.run('final_copy.py', check=True)
    +        subprocess.run(os.path.join('.', 'final_copy.py'), check=True)
         except:
             print('Failed to generate installer package')
             return 1
    -- 
    2.21.0.windows.1
    
    
    
    
    


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-01-31  6:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-22 21:55 [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py Bjorge, Erik C
2020-01-23 18:48 ` [edk2-devel] " Desimone, Ashley E
2020-01-31  6:56 ` Nate DeSimone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox