Re: [PATCH v3 1/3] MdeModulePkg/UdfDxe: Check 'Component Type' within a Path Component

[Paulo Alcantara <paulo@paulo.ac>]

Hi Hao Wu,

On October 29, 2018 10:26:15 PM GMT-03:00, Hao Wu <hao.a.wu@intel.com> wrote:
>REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1279
>
>According to the ECMA-167 standard (3rd Edition - June 1997), Section
>14.16.1.1, valid values are 1 to 5. All other values will be treated as
>a
>corrupted volume.
>
>This commit will add such check within function ResolveSymlink().
>
>Cc: Leif Lindholm <leif.lindholm@linaro.org>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Hao Wu <hao.a.wu@intel.com>
>Reviewed-by: Paulo Alcantara <palcantara@suse.de>
>Reviewed-by: Star Zeng <star.zeng@intel.com>
>---
> MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c
>b/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c
>index b9ebddfe62..c15741a032 100644
>--- a/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c
>+++ b/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c
>@@ -2257,6 +2257,13 @@ ResolveSymlink (
>       }
>       FileName[Index] = L'\0';
>       break;
>+    default:
>+      //
>+      // Accoring to the ECMA-167 standard (3rd Edition - June 1997),
>Section

Minor typo: s/Accoring/According/

Paulo

>+      // 14.16.1.1, all other values are reserved.
>+      //
>+      Status = EFI_VOLUME_CORRUPTED;
>+      goto Error_Find_File;
>     }
> 
>     //

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.