From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=18.228.144.36; helo=mail.paulo.ac; envelope-from=paulo@paulo.ac; receiver=edk2-devel@lists.01.org Received: from mail.paulo.ac (mail.paulo.ac [18.228.144.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 582832117B576 for ; Mon, 29 Oct 2018 18:40:48 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.paulo.ac (Postfix) with ESMTP id B2EC548AD306; Tue, 30 Oct 2018 01:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=paulo.ac; s=default; t=1540863646; bh=urMdn2xYpAaoUx6rnpAhdU1eQppg7u6riwhRDPiOU9U=; h=Date:In-Reply-To:References:Subject:To:CC:From; b=QFHp57pRydiO7wRo7ISUj29qRxbFEsOkr+/S1h3KZ6ciOryvkeSXO4x1I9ZATWi70 Tay1MLw+HpwFZUiijQ7wUEsfOx7wBK7lL6F/7h8DTN51A/HrQg+ilHn7jLv1VmcGbO azZsztgvuOLhxQgMI0L75ma6gm6WKvXRDmxbTVjw= Received: from mail.paulo.ac ([127.0.0.1]) by localhost (ip-172-31-5-70.sa-east-1.compute.internal [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uVHfini8JZRz; Tue, 30 Oct 2018 01:40:45 +0000 (UTC) Received: from [192.168.1.102] (189.27.130.117.dynamic.adsl.gvt.net.br [189.27.130.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.paulo.ac (Postfix) with ESMTPSA id B1F8B48AD305; Tue, 30 Oct 2018 01:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=paulo.ac; s=default; t=1540863644; bh=urMdn2xYpAaoUx6rnpAhdU1eQppg7u6riwhRDPiOU9U=; h=Date:In-Reply-To:References:Subject:To:CC:From; b=SbcdzWJCqK7pYD4LprpsdDkpj22Lt4r0pF/rzMGyN77FmQ/ceO7OsarHAYtdFuhJE Kn6+vdDa5KREdluTRk1dlcTj0Ien+ycRl8v6G1DqHF42ffNZy/NTgBOYRXSBbamlYI 9yZygREjFCUjZB+WYNJqwsrYRqqEXdqu8z728F3o= Date: Mon, 29 Oct 2018 22:40:43 -0300 User-Agent: K-9 Mail for Android In-Reply-To: <20181030012617.5040-2-hao.a.wu@intel.com> References: <20181030012617.5040-1-hao.a.wu@intel.com> <20181030012617.5040-2-hao.a.wu@intel.com> MIME-Version: 1.0 To: edk2-devel@lists.01.org,Hao Wu CC: Ruiyu Ni From: Paulo Alcantara Message-ID: <1F148C11-F1A0-4575-ADA9-C54FD608F97F@paulo.ac> Subject: Re: [PATCH v3 1/3] MdeModulePkg/UdfDxe: Check 'Component Type' within a Path Component X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 01:40:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Hao Wu, On October 29, 2018 10:26:15 PM GMT-03:00, Hao Wu wrote: >REF:https://bugzilla=2Etianocore=2Eorg/show_bug=2Ecgi?id=3D1279 > >According to the ECMA-167 standard (3rd Edition - June 1997), Section >14=2E16=2E1=2E1, valid values are 1 to 5=2E All other values will be trea= ted as >a >corrupted volume=2E > >This commit will add such check within function ResolveSymlink()=2E > >Cc: Leif Lindholm >Cc: Ruiyu Ni >Contributed-under: TianoCore Contribution Agreement 1=2E1 >Signed-off-by: Hao Wu >Reviewed-by: Paulo Alcantara >Reviewed-by: Star Zeng >--- > MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations=2Ec | 7 +++++++ > 1 file changed, 7 insertions(+) > >diff --git a/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations=2Ec >b/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations=2Ec >index b9ebddfe62=2E=2Ec15741a032 100644 >--- a/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations=2Ec >+++ b/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations=2Ec >@@ -2257,6 +2257,13 @@ ResolveSymlink ( > } > FileName[Index] =3D L'\0'; > break; >+ default: >+ // >+ // Accoring to the ECMA-167 standard (3rd Edition - June 1997), >Section Minor typo: s/Accoring/According/ Paulo >+ // 14=2E16=2E1=2E1, all other values are reserved=2E >+ // >+ Status =3D EFI_VOLUME_CORRUPTED; >+ goto Error_Find_File; > } >=20 > // --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E