From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=hong-chihx.hsueh@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8288221A00AE6 for ; Tue, 29 Jan 2019 17:05:06 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2019 17:05:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,538,1539673200"; d="scan'208";a="139930984" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 29 Jan 2019 17:05:05 -0800 Received: from fmsmsx107.amr.corp.intel.com ([169.254.6.186]) by FMSMSX105.amr.corp.intel.com ([169.254.4.102]) with mapi id 14.03.0415.000; Tue, 29 Jan 2019 17:05:05 -0800 From: "Hsueh, Hong-chihX" To: Laszlo Ersek , "edk2-devel@lists.01.org" , "Bi, Dandan" CC: "Kinney, Michael D" , "Gao, Liming" Thread-Topic: [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if relocation info is invalid. Thread-Index: AQHUt8FhB6qyVzP24UeI7t3zOdT85qXG/1uA Date: Wed, 30 Jan 2019 01:05:05 +0000 Message-ID: <1F8AF101AC6B5D47B4348ACCED214431CA59F555@fmsmsx107.amr.corp.intel.com> References: <20190128232200.1968-1-hong-chihx.hsueh@intel.com> <5c19d2e8-52ce-5393-6101-d5786c128606@redhat.com> In-Reply-To: <5c19d2e8-52ce-5393-6101-d5786c128606@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTY2MGRkYjktYjMzYy00ZjM5LWE3MzAtZmM3NzJhZWQwZGNiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoib0xpQ2QrRG9MTUNxeDZ0VGJ6cUVQbGhSc1dRUlZ6RTcwbElVYkpJNU5DUjBORVwvYnVMc0tzK3loc2hJZEtVWkQifQ== x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if relocation info is invalid. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 01:05:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgTGFzemxvICYgRGFuZGFuLA0KSGVyZSBpcyB0aGUgdXBkYXRlZCBwYXRjaCBmb3IgeW91ciBy ZXZpZXcuIFRoYW5rIHlvdSENCmh0dHBzOi8vbGlzdHMuMDEub3JnL3BpcGVybWFpbC9lZGsyLWRl dmVsLzIwMTktSmFudWFyeS8wMzU5NTQuaHRtbA0KDQpSZWdhcmRzLA0KTmVvDQoNCj4gLS0tLS1P cmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogTGFzemxvIEVyc2VrIFttYWlsdG86bGVyc2Vr QHJlZGhhdC5jb21dDQo+IFNlbnQ6IFR1ZXNkYXksIEphbnVhcnkgMjksIDIwMTkgMjo1NyBBTQ0K PiBUbzogSHN1ZWgsIEhvbmctY2hpaFggPGhvbmctY2hpaHguaHN1ZWhAaW50ZWwuY29tPjsgZWRr Mi1kZXZlbEBsaXN0cy4wMS5vcmcNCj4gQ2M6IEtpbm5leSwgTWljaGFlbCBEIDxtaWNoYWVsLmQu a2lubmV5QGludGVsLmNvbT47IEdhbywgTGltaW5nDQo+IDxsaW1pbmcuZ2FvQGludGVsLmNvbT47 IEJpLCBEYW5kYW4gPGRhbmRhbi5iaUBpbnRlbC5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hd IE1kZVBrZy9CYXNlUGVDb2ZmTGliOiBza2lwIHJ1bnRpbWUgcmVsb2NhdGlvbiBpZg0KPiByZWxv Y2F0aW9uIGluZm8gaXMgaW52YWxpZC4NCj4gDQo+IE9uIDAxLzI5LzE5IDAwOjIyLCBOZW8gSHN1 ZWggd3JvdGU6DQo+ID4gU2tpcCBydW50aW1lIHJlbG9jYXRpb24gZm9yIFBFIGltYWdlcyB0aGF0 IHByb3ZpZGUgaW52YWxpZCByZWxvY2F0aW9uDQo+ID4gaW5mb21hdGlvbg0KPiA+IChleDogUmVs b2NEaXItPlNpemUgPSAwKSB0byBmaXggYSBoYW5nIG9ic2VydmVkIHdoaWxlIGJvb3RpbmcgV2lu ZG93cy4NCj4gPg0KPiA+IENvbnRyaWJ1dGVkLXVuZGVyOiBUaWFub0NvcmUgQ29udHJpYnV0aW9u IEFncmVlbWVudCAxLjENCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IE5lbyBIc3VlaCA8aG9uZy1j aGloeC5oc3VlaEBpbnRlbC5jb20+DQo+ID4gQ2M6IE1pY2hhZWwgRCBLaW5uZXkgPG1pY2hhZWwu ZC5raW5uZXlAaW50ZWwuY29tPg0KPiA+IENjOiBMaW1pbmcgR2FvIDxsaW1pbmcuZ2FvQGludGVs LmNvbT4NCj4gPiBDYzogRGFuZGFuIEJpIDxkYW5kYW4uYmlAaW50ZWwuY29tPg0KPiA+IENjOiBM YXN6bG8gRXJzZWsgPGxlcnNla0ByZWRoYXQuY29tPg0KPiA+IC0tLQ0KPiA+ICBNZGVQa2cvTGli cmFyeS9CYXNlUGVDb2ZmTGliL0Jhc2VQZUNvZmYuYyB8IDE2ICsrKysrKysrKysrLS0tLS0NCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pDQo+ID4N Cj4gPiBkaWZmIC0tZ2l0IGEvTWRlUGtnL0xpYnJhcnkvQmFzZVBlQ29mZkxpYi9CYXNlUGVDb2Zm LmMNCj4gPiBiL01kZVBrZy9MaWJyYXJ5L0Jhc2VQZUNvZmZMaWIvQmFzZVBlQ29mZi5jDQo+ID4g aW5kZXggMWJkMDc5YWQ2YS4uNmQ2YzM3YmQ2MSAxMDA2NDQNCj4gPiAtLS0gYS9NZGVQa2cvTGli cmFyeS9CYXNlUGVDb2ZmTGliL0Jhc2VQZUNvZmYuYw0KPiA+ICsrKyBiL01kZVBrZy9MaWJyYXJ5 L0Jhc2VQZUNvZmZMaWIvQmFzZVBlQ29mZi5jDQo+ID4gQEAgLTEwMDIsNyArMTAwMiw3IEBAIFBl Q29mZkxvYWRlclJlbG9jYXRlSW1hZ2UgKA0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUmVsb2NE aXItPlZpcnR1YWxBZGRyZXNzICsNCj4gUmVsb2NEaXItPlNpemUgLSAxLA0KPiA+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgVGVTdHJpcHBlZE9mZnNldA0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKTsN Cj4gPiAtICAgIGlmIChSZWxvY0Jhc2UgPT0gTlVMTCB8fCBSZWxvY0Jhc2VFbmQgPT0gTlVMTCB8 fCBSZWxvY0Jhc2VFbmQgPA0KPiBSZWxvY0Jhc2UpIHsNCj4gPiArICAgIGlmIChSZWxvY0Jhc2Ug PT0gTlVMTCB8fCBSZWxvY0Jhc2VFbmQgPT0gTlVMTCB8fCAoVUlOVE4pDQo+ID4gKyBSZWxvY0Jh c2VFbmQgPCAoVUlOVE4pIFJlbG9jQmFzZSkgew0KPiA+ICAgICAgICBJbWFnZUNvbnRleHQtPklt YWdlRXJyb3IgPSBJTUFHRV9FUlJPUl9GQUlMRURfUkVMT0NBVElPTjsNCj4gPiAgICAgICAgcmV0 dXJuIFJFVFVSTl9MT0FEX0VSUk9SOw0KPiA+ICAgICAgfQ0KPiA+IEBAIC0xMDIyLDcgKzEwMjIs NyBAQCBQZUNvZmZMb2FkZXJSZWxvY2F0ZUltYWdlICgNCj4gPiAgICAgIC8vIFJ1biB0aGUgcmVs b2NhdGlvbiBpbmZvcm1hdGlvbiBhbmQgYXBwbHkgdGhlIGZpeHVwcw0KPiA+ICAgICAgLy8NCj4g PiAgICAgIEZpeHVwRGF0YSA9IEltYWdlQ29udGV4dC0+Rml4dXBEYXRhOw0KPiA+IC0gICAgd2hp bGUgKFJlbG9jQmFzZSA8IFJlbG9jQmFzZUVuZCkgew0KPiA+ICsgICAgd2hpbGUgKChVSU5UTikg UmVsb2NCYXNlIDwgKFVJTlROKSBSZWxvY0Jhc2VFbmQpIHsNCj4gPg0KPiA+ICAgICAgICBSZWxv YyAgICAgPSAoVUlOVDE2ICopICgoQ0hBUjggKikgUmVsb2NCYXNlICsgc2l6ZW9mDQo+IChFRklf SU1BR0VfQkFTRV9SRUxPQ0FUSU9OKSk7DQo+ID4gICAgICAgIC8vDQo+ID4gQEAgLTEwNTEsNyAr MTA1MSw3IEBAIFBlQ29mZkxvYWRlclJlbG9jYXRlSW1hZ2UgKA0KPiA+ICAgICAgICAvLw0KPiA+ ICAgICAgICAvLyBSdW4gdGhpcyByZWxvY2F0aW9uIHJlY29yZA0KPiA+ICAgICAgICAvLw0KPiA+ IC0gICAgICB3aGlsZSAoUmVsb2MgPCBSZWxvY0VuZCkgew0KPiA+ICsgICAgICB3aGlsZSAoKFVJ TlROKSBSZWxvYyA8IChVSU5UTikgUmVsb2NFbmQpIHsNCj4gPiAgICAgICAgICBGaXh1cCA9IFBl Q29mZkxvYWRlckltYWdlQWRkcmVzcyAoSW1hZ2VDb250ZXh0LCBSZWxvY0Jhc2UtDQo+ID5WaXJ0 dWFsQWRkcmVzcyArICgqUmVsb2MgJiAweEZGRiksIFRlU3RyaXBwZWRPZmZzZXQpOw0KPiA+ICAg ICAgICAgIGlmIChGaXh1cCA9PSBOVUxMKSB7DQo+ID4gICAgICAgICAgICBJbWFnZUNvbnRleHQt PkltYWdlRXJyb3IgPSBJTUFHRV9FUlJPUl9GQUlMRURfUkVMT0NBVElPTjsNCj4gPiBAQCAtMTc0 Niw2ICsxNzQ2LDEyIEBAIFBlQ29mZkxvYWRlclJlbG9jYXRlSW1hZ2VGb3JSdW50aW1lICgNCj4g PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIFJlbG9jRGlyLT5WaXJ0dWFsQWRkcmVzcyArDQo+IFJlbG9j RGlyLT5TaXplIC0gMSwNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDANCj4gPg0KPiA+ICk7DQo+ ID4gKyAgICBpZiAoUmVsb2NCYXNlID09IE5VTEwgfHwgUmVsb2NCYXNlRW5kID09IE5VTEwgfHwg KFVJTlROKSBSZWxvY0Jhc2VFbmQNCj4gPCAoVUlOVE4pIFJlbG9jQmFzZSkgew0KPiA+ICsgICAg ICAvLw0KPiA+ICsgICAgICAvLyByZWxvY2F0aW9uIGJsb2NrIGlzIG5vdCB2YWxpZCwganVzdCBy ZXR1cm4NCj4gPiArICAgICAgLy8NCj4gPiArICAgICAgcmV0dXJuOw0KPiA+ICsgICAgfQ0KPiA+ ICAgIH0gZWxzZSB7DQo+ID4gICAgICAvLw0KPiA+ICAgICAgLy8gQ2Fubm90IGZpbmQgcmVsb2Nh dGlvbnMsIGNhbm5vdCBjb250aW51ZSB0byByZWxvY2F0ZSB0aGUgaW1hZ2UsIEFTU0VSVA0KPiBm b3IgdGhpcyBpbnZhbGlkIGltYWdlLg0KPiA+IEBAIC0xNzY5LDcgKzE3NzUsNyBAQCBQZUNvZmZM b2FkZXJSZWxvY2F0ZUltYWdlRm9yUnVudGltZSAoDQo+ID4gICAgICAvLw0KPiA+ICAgICAgRml4 dXBEYXRhID0gUmVsb2NhdGlvbkRhdGE7DQo+ID4gICAgICBSZWxvY0Jhc2VPcmlnID0gUmVsb2NC YXNlOw0KPiA+IC0gICAgd2hpbGUgKFJlbG9jQmFzZSA8IFJlbG9jQmFzZUVuZCkgew0KPiA+ICsg ICAgd2hpbGUgKChVSU5UTikgUmVsb2NCYXNlIDwgKFVJTlROKSBSZWxvY0Jhc2VFbmQpIHsNCj4g PiAgICAgICAgLy8NCj4gPiAgICAgICAgLy8gQWRkIGNoZWNrIGZvciBSZWxvY0Jhc2UtPlNpemVP ZkJsb2NrIGZpZWxkLg0KPiA+ICAgICAgICAvLw0KPiA+IEBAIC0xNzk0LDcgKzE4MDAsNyBAQCBQ ZUNvZmZMb2FkZXJSZWxvY2F0ZUltYWdlRm9yUnVudGltZSAoDQo+ID4gICAgICAgIC8vDQo+ID4g ICAgICAgIC8vIFJ1biB0aGlzIHJlbG9jYXRpb24gcmVjb3JkDQo+ID4gICAgICAgIC8vDQo+ID4g LSAgICAgIHdoaWxlIChSZWxvYyA8IFJlbG9jRW5kKSB7DQo+ID4gKyAgICAgIHdoaWxlICgoVUlO VE4pIFJlbG9jIDwgKFVJTlROKSBSZWxvY0VuZCkgew0KPiA+DQo+ID4gICAgICAgICAgRml4dXAg PSBQZUNvZmZMb2FkZXJJbWFnZUFkZHJlc3MgKCZJbWFnZUNvbnRleHQsIFJlbG9jQmFzZS0NCj4g PlZpcnR1YWxBZGRyZXNzICsgKCpSZWxvYyAmIDB4RkZGKSwgMCk7DQo+ID4gICAgICAgICAgaWYg KEZpeHVwID09IE5VTEwpIHsNCj4gPg0KPiANCj4gSSB0aGluayB0aGlzIHBhdGNoIGlzIGdvb2Qg ZW5vdWdoLCBidXQgaXQgc2VlbXMgdG8gbWlzcyB0aGUgc2l6ZT09MCBjaGVjayB0aGF0DQo+IERh bmRhbiBhc2tlZCBmb3IuDQo+IA0KPiBUaGFua3MsDQo+IGxhc3psbw0K