Re: [edk2-devel] Role of DLINK2_FLAGS and link-time option consistency

["Marvin Häuser" <mhaeuser@posteo.de>]

[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]


> On 7. Apr 2023, at 14:00, Ard Biesheuvel <ardb@kernel.org> wrote:
> 
> (cc Ray)
> 
> On Fri, 7 Apr 2023 at 13:05, Marvin Häuser <mhaeuser@posteo.de> wrote:
>> 
>> 
>> On 7. Apr 2023, at 13:02, Ard Biesheuvel <ardb@kernel.org> wrote:
>> 
>> IIRC DLINK2_FLAGS is mainly being used (in the GCC case) for passing
>> options that need to come after previous occurrences of the same
>> option with a different value, in order for the DLINK2 one to take
>> precedence.
>> 
>> 
>> Thanks for the quick response! By that rationale, it should probably apply to the 16-bit ASM linker step as well and the rest can remain as-is (modulo that weird CLANGDWARF optimization situation)?
>> 
> 
> That build rule seems like dead code to me: we don't have any such
> files in the repo

It appears there still is one file remaining:
https://github.com/tianocore/edk2/blob/797f526ae2a83811b0ccbde0138c65a9f137eba5/IntelFsp2Pkg/FspSecCore/Vtf0/Ia16/ResetVec.asm16

But it is not directly referenced, just included from a file with a different extension:
https://github.com/tianocore/edk2/blob/797f526ae2a83811b0ccbde0138c65a9f137eba5/IntelFsp2Pkg/FspSecCore/Vtf0/ResetVectorCode.asm#L11

Being FSP, the most important consumers will probably be downstream, so I will not propose to remove it.


> , and no references to the .com output files that it
> produces, afaict
> 
> (The last uses were removed in 1a48fda5315433661c2f3039a30aea5916c22267)
> 
> Maybe Ray can comment?

Ping? :)

Best regards,
Marvin


[-- Attachment #2: Type: text/html, Size: 2376 bytes --]