From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by mx.groups.io with SMTP id smtpd.web11.15432.1681587232094713608 for ; Sat, 15 Apr 2023 12:33:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@posteo.de header.s=2017 header.b=bNDCPhMn; spf=pass (domain: posteo.de, ip: 185.67.36.66, mailfrom: mhaeuser@posteo.de) Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 37F382401D1 for ; Sat, 15 Apr 2023 21:33:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1681587230; bh=jYmBu82htoho62BXfYMC8l2yey0ha/Xwuyiw8LiyzfI=; h=From:Subject:Date:Cc:To:From; b=bNDCPhMnJzYnAMnc11bAUW0e04WLH7gk+ZmPLYOyiN4x1/i/CJjwkg8RBhpIS0mua 0lZ+ejOUPk8ABBtFl+Ubfzsds17Xb3PIGalAmjOKkqpFXkx5ht1U5eyrgetp+YY5wY DwpDkK30CY41J9jpUFMtyytrzd0Hji/m59WFu2vzoUD2Q1gOUSgG8Dj1PEA1iy21u7 W2negOGLpyP89l4pMbhAW0h45lKVVdU02F1L/ZgtV11/1vUyDlLvvJBZZQrwjkLdgZ kyJvksqvtUEYl0q7kIh0Nn+eJsKXSGU/0EjeqZPg09xpjrthLs+g2biWXMGfBl0rU2 ZGfitHN4bZ65A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PzNlv5rd3z9rxG; Sat, 15 Apr 2023 21:33:47 +0200 (CEST) From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= Message-Id: <1FAEE811-702C-410A-8451-CE7DE724B85F@posteo.de> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Subject: Re: [edk2-devel] Role of DLINK2_FLAGS and link-time option consistency Date: Sat, 15 Apr 2023 19:33:37 +0000 In-Reply-To: Cc: edk2-devel-groups-io , Liming Gao , Ray Ni , Rebecca Cran , Bob Feng , "Chen, Christine" , "Rudolph, Patrick" , Lean Sheng Tan , Pedro Falcato , Vitaly Cheptsov , Leif Lindholm , Steven Shi To: Ard Biesheuvel References: <6DC21A1C-4321-499F-ACCD-D5C81D20DB11@posteo.de> <846CCDAB-F758-4767-8588-17D65529415F@posteo.de> Content-Type: multipart/alternative; boundary="Apple-Mail=_24B1CD41-EFF1-412B-BBF9-BA00FCA04E2A" --Apple-Mail=_24B1CD41-EFF1-412B-BBF9-BA00FCA04E2A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 7. Apr 2023, at 14:00, Ard Biesheuvel wrote: >=20 > (cc Ray) >=20 > On Fri, 7 Apr 2023 at 13:05, Marvin H=C3=A4user = wrote: >>=20 >>=20 >> On 7. Apr 2023, at 13:02, Ard Biesheuvel wrote: >>=20 >> IIRC DLINK2_FLAGS is mainly being used (in the GCC case) for passing >> options that need to come after previous occurrences of the same >> option with a different value, in order for the DLINK2 one to take >> precedence. >>=20 >>=20 >> Thanks for the quick response! By that rationale, it should probably = apply to the 16-bit ASM linker step as well and the rest can remain = as-is (modulo that weird CLANGDWARF optimization situation)? >>=20 >=20 > That build rule seems like dead code to me: we don't have any such > files in the repo It appears there still is one file remaining: = https://github.com/tianocore/edk2/blob/797f526ae2a83811b0ccbde0138c65a9f13= 7eba5/IntelFsp2Pkg/FspSecCore/Vtf0/Ia16/ResetVec.asm16 But it is not directly referenced, just included from a file with a = different extension: = https://github.com/tianocore/edk2/blob/797f526ae2a83811b0ccbde0138c65a9f13= 7eba5/IntelFsp2Pkg/FspSecCore/Vtf0/ResetVectorCode.asm#L11 Being FSP, the most important consumers will probably be downstream, so = I will not propose to remove it. > , and no references to the .com output files that it > produces, afaict >=20 > (The last uses were removed in = 1a48fda5315433661c2f3039a30aea5916c22267) >=20 > Maybe Ray can comment? Ping? :) Best regards, Marvin --Apple-Mail=_24B1CD41-EFF1-412B-BBF9-BA00FCA04E2A Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On 7. Apr = 2023, at 14:00, Ard Biesheuvel <ardb@kernel.org> wrote:

(cc Ray)

On Fri, 7 = Apr 2023 at 13:05, Marvin H=C3=A4user <mhaeuser@posteo.de> = wrote:


On 7. Apr 2023, at 13:02, = Ard Biesheuvel <ardb@kernel.org> wrote:

IIRC DLINK2_FLAGS = is mainly being used (in the GCC case) for passing
options that need = to come after previous occurrences of the same
option with a = different value, in order for the DLINK2 one to = take
precedence.


Thanks for the quick response! By that = rationale, it should probably apply to the 16-bit ASM linker step as = well and the rest can remain as-is (modulo that weird CLANGDWARF = optimization situation)?


That build rule seems = like dead code to me: we don't have any such
files in the = repo

It appears there still = is one file remaining:

= But it is not directly referenced, just included from a file with a = different extension:

Being FSP, the most important consumers will probably be = downstream, so I will not propose to remove = it.


, and no = references to the .com output files that it
produces, = afaict

(The last uses were removed in = 1a48fda5315433661c2f3039a30aea5916c22267)

Maybe Ray can = comment?

Ping? = :)

Best = regards,
Marvin

= --Apple-Mail=_24B1CD41-EFF1-412B-BBF9-BA00FCA04E2A--