From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, edk2-devel@lists.01.org
Cc: michael.d.kinney@intel.com, eric.jin@intel.com
Subject: Re: [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames
Date: Tue, 6 Nov 2018 20:35:44 +0100 [thread overview]
Message-ID: <1a0e7be0-e1a7-fac8-0893-bf61d7e68659@redhat.com> (raw)
In-Reply-To: <20181106175833.26964-4-ard.biesheuvel@linaro.org>
On 6/11/18 18:58, Ard Biesheuvel wrote:
> Rename E1000.[ch] and E1000_osdep.[ch] to all lowercase, and replace
> all #include references with lowercase ones as well.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 2 +-
> IntelUndiPkg/GigUndiDxe/ComponentName.c | 2 +-
> IntelUndiPkg/GigUndiDxe/Decode.c | 2 +-
> IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 2 +-
> IntelUndiPkg/GigUndiDxe/Dma.c | 2 +-
> IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 2 +-
> IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 2 +-
> IntelUndiPkg/GigUndiDxe/DriverHealth.c | 2 +-
> IntelUndiPkg/GigUndiDxe/EepromConfig.h | 2 +-
> IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 8 ++++----
> IntelUndiPkg/GigUndiDxe/Init.c | 2 +-
> IntelUndiPkg/GigUndiDxe/StartStop.c | 2 +-
> IntelUndiPkg/GigUndiDxe/StartStop.h | 2 +-
> IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} | 2 +-
> IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} | 0
> IntelUndiPkg/GigUndiDxe/{E1000_osdep.c => e1000_osdep.c} | 2 +-
> IntelUndiPkg/GigUndiDxe/{E1000_osdep.h => e1000_osdep.h} | 0
> IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 2 +-
> 18 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> index b0320b11839b..8918c538e447 100644
> --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> @@ -28,7 +28,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> ***************************************************************************/
> #include "Uefi.h"
>
> -#include "E1000.h"
> +#include "e1000.h"
>
>
> #include "AdapterInformation.h"
> diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> index 1473bfbed0af..70baf00f4a5d 100644
> --- a/IntelUndiPkg/GigUndiDxe/ComponentName.c
> +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
>
> #include "ComponentName.h"
> #include "DeviceSupport.h"
> diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c b/IntelUndiPkg/GigUndiDxe/Decode.c
> index 88e8be315bd1..14060db0d050 100644
> --- a/IntelUndiPkg/GigUndiDxe/Decode.c
> +++ b/IntelUndiPkg/GigUndiDxe/Decode.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
> #include <Uefi\UEfiPxe.h>
>
> /** This routine determines the operational state of the UNDI. It updates the state flags in the
> diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> index f309044d9b9d..e156b587f6a7 100644
> --- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> +++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #ifndef DEVICE_SUPPORT_H_
> #define DEVICE_SUPPORT_H_
>
> -#include "E1000.h"
> +#include "e1000.h"
>
> typedef struct BRAND_STRUCT_S BRAND_STRUCT;
>
> diff --git a/IntelUndiPkg/GigUndiDxe/Dma.c b/IntelUndiPkg/GigUndiDxe/Dma.c
> index 76a3fcf69601..bf94c1e2fd54 100644
> --- a/IntelUndiPkg/GigUndiDxe/Dma.c
> +++ b/IntelUndiPkg/GigUndiDxe/Dma.c
> @@ -27,7 +27,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
>
> -#include "E1000.h"
> +#include "e1000.h"
>
> #include "Dma.h"
>
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> index 118c1b2b9b04..20d40ab672ef 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
> #include "DriverConfiguration.h"
>
> /* Protocol structure tentative definition */
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> index a9f176ce5324..559f2133281e 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
> #include "DriverDiagnostics.h"
>
> /* Protocol structures tentative definitions */
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> index b1af371e06db..b5b7db5fd814 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
>
>
> /** Retrieves the health status of a controller in the platform.
> diff --git a/IntelUndiPkg/GigUndiDxe/EepromConfig.h b/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> index e0d31f6a151d..272292d107e1 100644
> --- a/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> +++ b/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #ifndef EEPROM_CONFIG_H_
> #define EEPROM_CONFIG_H_
>
> -#include "E1000.h"
> +#include "e1000.h"
>
> // EEPROM power management bit definitions
> #define E1000_INIT_CONTROL_WORD1 0x0A
> diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> index 2d2d0707a686..0e4462733df6 100644
> --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> @@ -72,8 +72,8 @@ DriverConfiguration.c
> DriverConfiguration.h
> DriverDiagnostics.c
> DriverDiagnostics.h
> -E1000.h
> -E1000.c
> +e1000.h
> +e1000.c
> e1000_80003es2lan.h
> e1000_80003es2lan.c
> e1000_82571.h
> @@ -92,8 +92,8 @@ e1000_manage.h
> e1000_manage.c
> e1000_nvm.h
> e1000_nvm.c
> -E1000_osdep.h
> -E1000_osdep.c
> +e1000_osdep.h
> +e1000_osdep.c
> e1000_phy.h
> e1000_phy.c
> e1000_regs.h
> diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c
> index 47ed03eb0849..74b933674589 100644
> --- a/IntelUndiPkg/GigUndiDxe/Init.c
> +++ b/IntelUndiPkg/GigUndiDxe/Init.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
> #include "Init.h"
> #include "DeviceSupport.h"
> #include "Decode.h"
> diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c b/IntelUndiPkg/GigUndiDxe/StartStop.c
> index 10ab4e51bf44..32bed7ce288d 100644
> --- a/IntelUndiPkg/GigUndiDxe/StartStop.c
> +++ b/IntelUndiPkg/GigUndiDxe/StartStop.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
> #include "StartStop.h"
>
> EFI_GUID gEfiStartStopProtocolGuid = EFI_DRIVER_STOP_PROTOCOL_GUID;
> diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h b/IntelUndiPkg/GigUndiDxe/StartStop.h
> index 24304d6cc3a7..255f17aabaa4 100644
> --- a/IntelUndiPkg/GigUndiDxe/StartStop.h
> +++ b/IntelUndiPkg/GigUndiDxe/StartStop.h
> @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #ifndef START_STOP_H_
> #define START_STOP_H_
>
> -#include "E1000.h"
> +#include "e1000.h"
>
> #define EFI_DRIVER_STOP_PROTOCOL_GUID \
> { 0x34d59603, 0x1428, 0x4429, 0xa4, 0x14, 0xe6, 0xb3, \
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c
> similarity index 99%
> rename from IntelUndiPkg/GigUndiDxe/E1000.c
> rename to IntelUndiPkg/GigUndiDxe/e1000.c
> index fad20d988441..6f8529abf046 100644
> --- a/IntelUndiPkg/GigUndiDxe/E1000.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
> #include "DeviceSupport.h"
>
>
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000.h b/IntelUndiPkg/GigUndiDxe/e1000.h
> similarity index 100%
> rename from IntelUndiPkg/GigUndiDxe/E1000.h
> rename to IntelUndiPkg/GigUndiDxe/e1000.h
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c b/IntelUndiPkg/GigUndiDxe/e1000_osdep.c
> similarity index 99%
> rename from IntelUndiPkg/GigUndiDxe/E1000_osdep.c
> rename to IntelUndiPkg/GigUndiDxe/e1000_osdep.c
> index 0d0047a93048..3aa18e735dee 100644
> --- a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
>
> /** Reads from the PCI capabality region.
>
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.h b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> similarity index 100%
> rename from IntelUndiPkg/GigUndiDxe/E1000_osdep.h
> rename to IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> index ed2ffc427093..ec67d000e9ae 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #ifndef __WOLIMPL_H
> #define __WOLIMPL_H
>
> -#include <E1000.h>
> +#include <e1000.h>
> #define WOL_1G 2
>
> typedef UNDI_PRIVATE_DATA *WOL_ADAPTER_HANDLE_TYPE;
>
next prev parent reply other threads:[~2018-11-06 19:35 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
2018-11-06 17:58 ` [PATCH edk2-staging 01/19] IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported architectures Ard Biesheuvel
2019-01-29 13:54 ` Ryszard Knop
2019-01-29 14:04 ` Ard Biesheuvel
2018-11-06 17:58 ` [PATCH edk2-staging 02/19] IntelUndiPkg: remove EOF markers Ard Biesheuvel
2018-11-06 19:34 ` Philippe Mathieu-Daudé
2019-01-29 13:58 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames Ard Biesheuvel
2018-11-06 19:35 ` Philippe Mathieu-Daudé [this message]
2019-01-29 14:21 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 04/19] IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path separators Ard Biesheuvel
2018-11-06 19:37 ` Philippe Mathieu-Daudé
2019-01-29 14:26 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 05/19] IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration after type definition Ard Biesheuvel
2019-01-29 16:02 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 06/19] IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts for pointers Ard Biesheuvel
2019-01-30 10:59 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 07/19] IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT build options Ard Biesheuvel
2019-01-30 11:48 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast Ard Biesheuvel
2018-11-07 9:16 ` Philippe Mathieu-Daudé
2018-11-07 14:05 ` Philippe Mathieu-Daudé
2019-01-30 12:05 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast Ard Biesheuvel
2018-11-06 20:31 ` Philippe Mathieu-Daudé
2018-11-06 20:35 ` Ard Biesheuvel
2018-11-07 9:08 ` Philippe Mathieu-Daudé
2019-01-30 12:37 ` Ryszard Knop
2019-01-30 12:30 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 10/19] IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals Ard Biesheuvel
2018-11-06 20:34 ` Philippe Mathieu-Daudé
2019-01-30 12:59 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 11/19] IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP token pasting Ard Biesheuvel
2019-01-30 13:35 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 12/19] IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct pointer type Ard Biesheuvel
2018-11-06 20:35 ` Philippe Mathieu-Daudé
2019-01-30 13:37 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 13/19] IntelUndiPkg/GigUndiDxe: don't take address of cast expression Ard Biesheuvel
2018-11-06 20:36 ` Philippe Mathieu-Daudé
2019-01-30 13:41 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 14/19] IntelUndiPkg/GigUndiDxe: redefine UNREFERENCED_nPARAMETER macros for GCC Ard Biesheuvel
2018-11-06 17:58 ` [PATCH edk2-staging 15/19] IntelUndiPkg/GigUndiDxe: remove forward declaration of non-existent function Ard Biesheuvel
2018-11-06 20:40 ` Philippe Mathieu-Daudé
2019-01-30 15:26 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 16/19] IntelUndiPkg/GigUndiDxe: fix incorrect indentation Ard Biesheuvel
2018-11-06 20:41 ` Philippe Mathieu-Daudé
2018-11-06 17:58 ` [PATCH edk2-staging 17/19] IntelUndiPkg/GigUndiDxe: move MSFT warning overrides to INF file Ard Biesheuvel
2019-01-30 14:09 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 18/19] IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers Ard Biesheuvel
2019-01-30 15:15 ` Ryszard Knop
2019-01-30 15:20 ` Ard Biesheuvel
2019-01-30 15:31 ` Ryszard Knop
2019-01-30 15:33 ` Ard Biesheuvel
2018-11-06 17:58 ` [PATCH edk2-staging 19/19] IntelUndiPkg/GigUndiDxe: remove or reorganize unused variables Ard Biesheuvel
2018-11-07 9:08 ` Philippe Mathieu-Daudé
2019-01-30 14:32 ` Ryszard Knop
2018-11-06 22:10 ` [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Kinney, Michael D
2018-11-06 23:03 ` Ard Biesheuvel
2018-11-09 17:54 ` Knop, Ryszard
2018-11-09 18:00 ` Ard Biesheuvel
2018-11-07 14:56 ` Leif Lindholm
2019-01-29 13:13 ` Ryszard Knop
2019-01-29 13:55 ` Ryszard Knop
2019-03-27 15:32 ` Ard Biesheuvel
2019-03-28 10:46 ` Ryszard Knop
2019-03-28 11:38 ` Ard Biesheuvel
2020-01-07 12:49 ` [edk2-devel] " Maciej Rabeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a0e7be0-e1a7-fac8-0893-bf61d7e68659@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox