From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.68; helo=mail-wr1-f68.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0AD2021189FB2 for ; Tue, 6 Nov 2018 11:35:46 -0800 (PST) Received: by mail-wr1-f68.google.com with SMTP id j17-v6so9738088wrq.11 for ; Tue, 06 Nov 2018 11:35:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aDORC52bngZKa9aj5HCxSMgZlFUuOvAn5bIBiONnbxw=; b=fG353AYYQ6xJVwu6z316UAJMxOeJ/uKCnq7dj7SRnz/x83yEmFNL2hL/eeexa5g4zm TlTkcdSiWp6B52jTxqsWcwGSUR/29C6U+y/n//4Rxrr5KxUV8QBTKNNOzTUBQ0mTFbzT fbo3WydCHnZInNvoKkEqhQq/GRqM1YIJ4y/hdzpSDo2nySP/yvgi7UzdKFneaeGRJ1gC T+XG2d/HIyqQjl1yrzhUx7Zgtb4uqDF4gwgFe7+IZfT9sm8n35wZMCcPSbfNEv7RLgWV Up9dcbYnxYFQkQSHT2EfQW5M6VRN/qTCVaojMDsJLJ9YTutYASYqI/L6y8sZPxq6qTet moEw== X-Gm-Message-State: AGRZ1gKc/engYtOYFNUpSx0SQQyJRfhshlU3lY5ibbjb/thI/oDGyJfC AStH7rkSNoXWKIHvuaLP0bALPA== X-Google-Smtp-Source: AJdET5frR3zMP15NTr/DcWKRfvEjU0JJh2PCd6XsVg5Kp6mE1kkX0KUIdxzkATxwoa9uphYVOzl/Kg== X-Received: by 2002:adf:9b84:: with SMTP id d4-v6mr23174267wrc.240.1541532945439; Tue, 06 Nov 2018 11:35:45 -0800 (PST) Received: from [192.168.1.74] (67.23.27.109.rev.sfr.net. [109.27.23.67]) by smtp.gmail.com with ESMTPSA id j203-v6sm4529443wmd.46.2018.11.06.11.35.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 11:35:44 -0800 (PST) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: michael.d.kinney@intel.com, eric.jin@intel.com References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-4-ard.biesheuvel@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <1a0e7be0-e1a7-fac8-0893-bf61d7e68659@redhat.com> Date: Tue, 6 Nov 2018 20:35:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181106175833.26964-4-ard.biesheuvel@linaro.org> Subject: Re: [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 19:35:47 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 6/11/18 18:58, Ard Biesheuvel wrote: > Rename E1000.[ch] and E1000_osdep.[ch] to all lowercase, and replace > all #include references with lowercase ones as well. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé > --- > IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 2 +- > IntelUndiPkg/GigUndiDxe/ComponentName.c | 2 +- > IntelUndiPkg/GigUndiDxe/Decode.c | 2 +- > IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 2 +- > IntelUndiPkg/GigUndiDxe/Dma.c | 2 +- > IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 2 +- > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 2 +- > IntelUndiPkg/GigUndiDxe/DriverHealth.c | 2 +- > IntelUndiPkg/GigUndiDxe/EepromConfig.h | 2 +- > IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 8 ++++---- > IntelUndiPkg/GigUndiDxe/Init.c | 2 +- > IntelUndiPkg/GigUndiDxe/StartStop.c | 2 +- > IntelUndiPkg/GigUndiDxe/StartStop.h | 2 +- > IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} | 2 +- > IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} | 0 > IntelUndiPkg/GigUndiDxe/{E1000_osdep.c => e1000_osdep.c} | 2 +- > IntelUndiPkg/GigUndiDxe/{E1000_osdep.h => e1000_osdep.h} | 0 > IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 2 +- > 18 files changed, 19 insertions(+), 19 deletions(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c > index b0320b11839b..8918c538e447 100644 > --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c > +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c > @@ -28,7 +28,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > ***************************************************************************/ > #include "Uefi.h" > > -#include "E1000.h" > +#include "e1000.h" > > > #include "AdapterInformation.h" > diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c b/IntelUndiPkg/GigUndiDxe/ComponentName.c > index 1473bfbed0af..70baf00f4a5d 100644 > --- a/IntelUndiPkg/GigUndiDxe/ComponentName.c > +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ***************************************************************************/ > -#include "E1000.h" > +#include "e1000.h" > > #include "ComponentName.h" > #include "DeviceSupport.h" > diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c b/IntelUndiPkg/GigUndiDxe/Decode.c > index 88e8be315bd1..14060db0d050 100644 > --- a/IntelUndiPkg/GigUndiDxe/Decode.c > +++ b/IntelUndiPkg/GigUndiDxe/Decode.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ***************************************************************************/ > -#include "E1000.h" > +#include "e1000.h" > #include > > /** This routine determines the operational state of the UNDI. It updates the state flags in the > diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h > index f309044d9b9d..e156b587f6a7 100644 > --- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h > +++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h > @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > #ifndef DEVICE_SUPPORT_H_ > #define DEVICE_SUPPORT_H_ > > -#include "E1000.h" > +#include "e1000.h" > > typedef struct BRAND_STRUCT_S BRAND_STRUCT; > > diff --git a/IntelUndiPkg/GigUndiDxe/Dma.c b/IntelUndiPkg/GigUndiDxe/Dma.c > index 76a3fcf69601..bf94c1e2fd54 100644 > --- a/IntelUndiPkg/GigUndiDxe/Dma.c > +++ b/IntelUndiPkg/GigUndiDxe/Dma.c > @@ -27,7 +27,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ***************************************************************************/ > > -#include "E1000.h" > +#include "e1000.h" > > #include "Dma.h" > > diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c > index 118c1b2b9b04..20d40ab672ef 100644 > --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c > +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ***************************************************************************/ > -#include "E1000.h" > +#include "e1000.h" > #include "DriverConfiguration.h" > > /* Protocol structure tentative definition */ > diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c > index a9f176ce5324..559f2133281e 100644 > --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c > +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ***************************************************************************/ > -#include "E1000.h" > +#include "e1000.h" > #include "DriverDiagnostics.h" > > /* Protocol structures tentative definitions */ > diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c b/IntelUndiPkg/GigUndiDxe/DriverHealth.c > index b1af371e06db..b5b7db5fd814 100644 > --- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c > +++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ***************************************************************************/ > -#include "E1000.h" > +#include "e1000.h" > > > /** Retrieves the health status of a controller in the platform. > diff --git a/IntelUndiPkg/GigUndiDxe/EepromConfig.h b/IntelUndiPkg/GigUndiDxe/EepromConfig.h > index e0d31f6a151d..272292d107e1 100644 > --- a/IntelUndiPkg/GigUndiDxe/EepromConfig.h > +++ b/IntelUndiPkg/GigUndiDxe/EepromConfig.h > @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > #ifndef EEPROM_CONFIG_H_ > #define EEPROM_CONFIG_H_ > > -#include "E1000.h" > +#include "e1000.h" > > // EEPROM power management bit definitions > #define E1000_INIT_CONTROL_WORD1 0x0A > diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > index 2d2d0707a686..0e4462733df6 100644 > --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > @@ -72,8 +72,8 @@ DriverConfiguration.c > DriverConfiguration.h > DriverDiagnostics.c > DriverDiagnostics.h > -E1000.h > -E1000.c > +e1000.h > +e1000.c > e1000_80003es2lan.h > e1000_80003es2lan.c > e1000_82571.h > @@ -92,8 +92,8 @@ e1000_manage.h > e1000_manage.c > e1000_nvm.h > e1000_nvm.c > -E1000_osdep.h > -E1000_osdep.c > +e1000_osdep.h > +e1000_osdep.c > e1000_phy.h > e1000_phy.c > e1000_regs.h > diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c > index 47ed03eb0849..74b933674589 100644 > --- a/IntelUndiPkg/GigUndiDxe/Init.c > +++ b/IntelUndiPkg/GigUndiDxe/Init.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ***************************************************************************/ > -#include "E1000.h" > +#include "e1000.h" > #include "Init.h" > #include "DeviceSupport.h" > #include "Decode.h" > diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c b/IntelUndiPkg/GigUndiDxe/StartStop.c > index 10ab4e51bf44..32bed7ce288d 100644 > --- a/IntelUndiPkg/GigUndiDxe/StartStop.c > +++ b/IntelUndiPkg/GigUndiDxe/StartStop.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ***************************************************************************/ > -#include "E1000.h" > +#include "e1000.h" > #include "StartStop.h" > > EFI_GUID gEfiStartStopProtocolGuid = EFI_DRIVER_STOP_PROTOCOL_GUID; > diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h b/IntelUndiPkg/GigUndiDxe/StartStop.h > index 24304d6cc3a7..255f17aabaa4 100644 > --- a/IntelUndiPkg/GigUndiDxe/StartStop.h > +++ b/IntelUndiPkg/GigUndiDxe/StartStop.h > @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > #ifndef START_STOP_H_ > #define START_STOP_H_ > > -#include "E1000.h" > +#include "e1000.h" > > #define EFI_DRIVER_STOP_PROTOCOL_GUID \ > { 0x34d59603, 0x1428, 0x4429, 0xa4, 0x14, 0xe6, 0xb3, \ > diff --git a/IntelUndiPkg/GigUndiDxe/E1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c > similarity index 99% > rename from IntelUndiPkg/GigUndiDxe/E1000.c > rename to IntelUndiPkg/GigUndiDxe/e1000.c > index fad20d988441..6f8529abf046 100644 > --- a/IntelUndiPkg/GigUndiDxe/E1000.c > +++ b/IntelUndiPkg/GigUndiDxe/e1000.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ***************************************************************************/ > -#include "E1000.h" > +#include "e1000.h" > #include "DeviceSupport.h" > > > diff --git a/IntelUndiPkg/GigUndiDxe/E1000.h b/IntelUndiPkg/GigUndiDxe/e1000.h > similarity index 100% > rename from IntelUndiPkg/GigUndiDxe/E1000.h > rename to IntelUndiPkg/GigUndiDxe/e1000.h > diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c b/IntelUndiPkg/GigUndiDxe/e1000_osdep.c > similarity index 99% > rename from IntelUndiPkg/GigUndiDxe/E1000_osdep.c > rename to IntelUndiPkg/GigUndiDxe/e1000_osdep.c > index 0d0047a93048..3aa18e735dee 100644 > --- a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c > +++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.c > @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ***************************************************************************/ > -#include "E1000.h" > +#include "e1000.h" > > /** Reads from the PCI capabality region. > > diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.h b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h > similarity index 100% > rename from IntelUndiPkg/GigUndiDxe/E1000_osdep.h > rename to IntelUndiPkg/GigUndiDxe/e1000_osdep.h > diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h > index ed2ffc427093..ec67d000e9ae 100644 > --- a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h > +++ b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h > @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > #ifndef __WOLIMPL_H > #define __WOLIMPL_H > > -#include > +#include > #define WOL_1G 2 > > typedef UNDI_PRIVATE_DATA *WOL_ADAPTER_HANDLE_TYPE; >