From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 698819412F2 for ; Wed, 17 Apr 2024 07:43:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=BSJ7IIWw6GfOTX6h8TumLYONVZ333qVG5oPPKQLXqBg=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1713339827; v=1; b=lTKVIGTMDHkwLdS9u0BW14hwBonc1EJG4rlpo8cTcQrHnhKKqtxEy3aIYT2eVt5qQNFxzdIp C1hCGzMAVPIU4NkUMar4uZ+1YilhO3+ippn/ji0TL+x2M8AE6hYJR3fEIlAevgtqpXXQGU4tnl/ eh7jU0UXrz9GR7ubjxD0VxkifHCH0uG678iqUy2X7aLb7D1F8KKDYdSfbNLyL54dhyhUafmRXVO ZxToBbic5eZqFjl5M02eT6BiVWXxAhsNsgOBx2d7xB/MRbCZk29iHc533Ye/wvRYonsLbovo3ea aBCTHhJMGXABi/LXYb+HJz2YIibbv3/pJVkSOhUhWFGfQ== X-Received: by 127.0.0.2 with SMTP id NVqdYY7687511x30OMJKr5s6; Wed, 17 Apr 2024 00:43:47 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.7313.1713339820630032921 for ; Wed, 17 Apr 2024 00:43:41 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8Dx+7qjfR9mL60oAA--.11058S3; Wed, 17 Apr 2024 15:43:31 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxthGifR9mhch9AA--.32293S3; Wed, 17 Apr 2024 15:43:30 +0800 (CST) Message-ID: <1a290eb4-543f-43cd-a8b2-337bb48b89ff@loongson.cn> Date: Wed, 17 Apr 2024 15:43:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib To: Gerd Hoffmann , devel@edk2.groups.io Cc: lixianglai , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Bibo Mao , Dongyan Qian References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093924.1254576-1-lichao@loongson.cn> <01d94c67-de3d-7709-84d4-ec97dc7a01ec@loongson.cn> <2teja7rxfli7fxvxlii54tbdaj2y6jz2qlvprf7pfpzzjyycrz@gp5axpziekwh> <949717bb-5dbd-4298-9482-a3b12ded650a@loongson.cn> <17BEC74BB37915EC.2828@groups.io> <323033d0-8749-4885-a4b1-7f6f854b6487@loongson.cn> <5fjrgywtmvboqdi43n7brrzms67skc3zejzvnekz2v62znhzpk@wjidta4b7rae> From: "Chao Li" In-Reply-To: <5fjrgywtmvboqdi43n7brrzms67skc3zejzvnekz2v62znhzpk@wjidta4b7rae> X-CM-TRANSID: AQAAf8DxthGifR9mhch9AA--.32293S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAKCGYeNusLoQABsN X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 17 Apr 2024 00:43:41 -0700 Resent-From: lichao@loongson.cn Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lc2S091j23zA59mHh2S8ERmfx7686176AA= Content-Type: multipart/alternative; boundary="------------Orrl6zc8E0qBogJA0CvPgb0Z" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=lTKVIGTM; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io --------------Orrl6zc8E0qBogJA0CvPgb0Z Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Gerd, Thanks, Chao On 2024/4/17 14:59, Gerd Hoffmann wrote: > On Wed, Apr 17, 2024 at 10:53:21AM +0800, Chao Li wrote: >> Hi Gerd, >> >> Part 2 has been be merged, I'm separating  this Lib into two serve the PEI >> stage and DXE stage. >> >> Currently, This DXE library uses three global variables, and when I simulate >> the no-mmio version: MmioLib.c + Dxe.c + Pei.c, I can abstract some helper >> functions as the public functions in Mmio version. >> >> Do you mind if I replace these three vaiables with three dynamically typed >> PCDs? If so, the PEI and DXE stage libraries can using  some of the same >> APIs. > What is your idea? Let PEI discover fw_cfg, store results in PCDs, and > DXE will read the PCDs instead of using FdtClientProtocol to find the > fw_cfg? > > Note that risc-v and arm don't need access to fw_cfg in PEI, so this > approach would not work for them. No no no, I mean these two stages have their own way to get the FDT resouces, for example: PEI stage uses fdtlib to find the fw_cfg and the DXE stage uses FdtClientProtocol to find the fw_cfg, DXE will look for fw_cfg anyway. Can I submit a patch set for quick review by you? It content only four patches. > > take care, > Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117901): https://edk2.groups.io/g/devel/message/117901 Mute This Topic: https://groups.io/mt/104859897/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------Orrl6zc8E0qBogJA0CvPgb0Z Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Gerd,


Thanks,
Chao
On 2024/4/17 14:59, Gerd Hoffmann wrote:
On Wed, Apr 17, 2024 at 10:53:21AM +0800, Chao Li wrote:

Hi Gerd,

Part 2 has been be merged, I'm separating  this Lib into two serve the PEI
stage and DXE stage.

Currently, This DXE library uses three global variables, and when I simulate
the no-mmio version: MmioLib.c + Dxe.c + Pei.c, I can abstract some helper
functions as the public functions in Mmio version.

Do you mind if I replace these three vaiables with three dynamically typed
PCDs? If so, the PEI and DXE stage libraries can using  some of the same
APIs.

What is your idea?  Let PEI discover fw_cfg, store results in PCDs, and
DXE will read the PCDs instead of using FdtClientProtocol to find the
fw_cfg?

Note that risc-v and arm don't need access to fw_cfg in PEI, so this
approach would not work for them.

No no no, I mean these two stages have their own way to get the FDT resouces, for example: PEI stage uses fdtlib to find the fw_cfg and the DXE stage uses FdtClientProtocol to find the fw_cfg, DXE will look for fw_cfg anyway.

Can I submit a patch set for quick review by you? It content only four patches.


take care,
  Gerd
_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#117901) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------Orrl6zc8E0qBogJA0CvPgb0Z--