From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.10153.1581428473792866182 for ; Tue, 11 Feb 2020 05:41:13 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 05:41:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="380435786" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 11 Feb 2020 05:41:12 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Feb 2020 05:41:12 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 11 Feb 2020 21:41:10 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Tue, 11 Feb 2020 21:41:10 +0800 From: "Liming Gao" To: "Fu, Siyuan" , "devel@edk2.groups.io" CC: "Kinney, Michael D" Subject: Re: [PATCH v2 2/2] MdePkg: Remove FIT table industry standard header file. Thread-Topic: [PATCH v2 2/2] MdePkg: Remove FIT table industry standard header file. Thread-Index: AQHV4OBUtS2yQXHtAU+x2Q7pws93oagV///w Date: Tue, 11 Feb 2020 13:41:10 +0000 Message-ID: <1a30252fe0f54c0a968c8a7cd73cab1c@intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Fu, Siyuan > Sent: Tuesday, February 11, 2020 9:37 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > Subject: [PATCH v2 2/2] MdePkg: Remove FIT table industry standard header= file. >=20 > Commit c7c964b and dd01704 add header file for FIT table and update > MpInitLib to support FIT based microcode shadow operation. There are > comments that FIT is Intel specific specification instead of industry > standard, which should not be placed in EDK2 MdePkg and UefiCpuPkg. > This patch removes the header file added by c7c964b. >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Siyuan Fu > --- > .../IndustryStandard/FirmwareInterfaceTable.h | 76 ------------------- > 1 file changed, 76 deletions(-) > delete mode 100644 MdePkg/Include/IndustryStandard/FirmwareInterfaceTabl= e.h >=20 > diff --git a/MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h b/M= dePkg/Include/IndustryStandard/FirmwareInterfaceTable.h > deleted file mode 100644 > index be3e34ae1b..0000000000 > --- a/MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h > +++ /dev/null > @@ -1,76 +0,0 @@ > -/** @file > - Industry Standard Definitions of Firmware Interface Table BIOS Specifi= cation 1.0. > - > - Copyright (c) 2016 - 2020, Intel Corporation. All rights reserved.
> - SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#ifndef __FIRMWARE_INTERFACE_TABLE_H__ > -#define __FIRMWARE_INTERFACE_TABLE_H__ > - > -// > -// FIT Entry type definitions > -// > -#define FIT_TYPE_00_HEADER 0x00 > -#define FIT_TYPE_01_MICROCODE 0x01 > -#define FIT_TYPE_02_STARTUP_ACM 0x02 > -#define FIT_TYPE_07_BIOS_STARTUP_MODULE 0x07 > -#define FIT_TYPE_08_TPM_POLICY 0x08 > -#define FIT_TYPE_09_BIOS_POLICY 0x09 > -#define FIT_TYPE_0A_TXT_POLICY 0x0A > -#define FIT_TYPE_0B_KEY_MANIFEST 0x0B > -#define FIT_TYPE_0C_BOOT_POLICY_MANIFEST 0x0C > -#define FIT_TYPE_10_CSE_SECURE_BOOT 0x10 > -#define FIT_TYPE_2D_TXTSX_POLICY 0x2D > -#define FIT_TYPE_2F_JMP_DEBUG_POLICY 0x2F > -#define FIT_TYPE_7F_SKIP 0x7F > - > -#define FIT_POINTER_ADDRESS 0xFFFFFFC0 ///< Fixed addres= s at 4G - 40h > - > -#define FIT_TYPE_VERSION 0x0100 > - > -#define FIT_TYPE_00_SIGNATURE SIGNATURE_64 ('_', 'F', 'I', 'T', '_', ' = ', ' ', ' ') > - > -#pragma pack(1) > - > -typedef struct { > - // > - // Address is the base address of the firmware component > - // must be aligned on 16 byte boundary > - // > - UINT64 Address; > - // > - // Size is the span of the component in multiple of 16 bytes > - // > - UINT8 Size[3]; > - // > - // Reserved must be set to 0 > - // > - UINT8 Reserved; > - // > - // Component's version number in binary coded decimal (BCD) format. > - // For the FIT header entry, the value in this field will indicate the= revision > - // number of the FIT data structure. The upper byte of the revision fi= eld > - // indicates the major revision and the lower byte indicates the minor= revision. > - // > - UINT16 Version; > - // > - // FIT types 0x00 to 0x7F > - // > - UINT8 Type : 7; > - // > - // Checksum Valid indicates whether component has valid checksum. > - // > - UINT8 C_V : 1; > - // > - // Component's checksum. The modulo sum of all the bytes in the compon= ent and > - // the value in this field (Chksum) must add up to zero. This field is= only > - // valid if the C_V flag is non-zero. > - // > - UINT8 Chksum; > -} FIRMWARE_INTERFACE_TABLE_ENTRY; > - > -#pragma pack() > - > -#endif > -- > 2.19.1.windows.1