From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.87]) by mx.groups.io with SMTP id smtpd.web08.105.1661272633666640080 for ; Tue, 23 Aug 2022 09:37:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=WJTBP6jF; spf=pass (domain: arm.com, ip: 40.107.15.87, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XpGFP6My0bRaC3kTEQoUvfdq9NnJzqJTHsouRdE3xLr5J7Oi972yPEdiUja8uegfqi5/roT83/4JJjUZeC9XV1h4h56U7pIJelc23b+wXTG8YFWHDRwaenfYG9QwL7j5VjcOAwXvObhKDKKCi630iTW1cv6vpUd7DeerziseItxKsTCPlMU8VETcU6pU9OBOrTZZxnNX0TQ2C5K7QboBpqdK45k4kyBp/5MahJBQxFC8OB3QXwP66wXoBFGZu56tyh6ZdUbVdoRGuTVncZoLvUXvZYc8tgoyvD3e0rUYLIOJAtsGGgzXyD4863/wqdQAdZjJlSFW62+Q387UQBsdpg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u/9tM6pr+xajvOGuQTJyQ8o+pCrhT9WtqXVYHtjBiCQ=; b=kBi4htx2sCD72w3b541zQpQWjSfWWhJVdOEvwCr6bbqTBq79VeWVjP7m5d3aQNenysZFo1FRwLTxas4GJPxFeii1YyDQrABFaP6PkCBRQDmc6HEmc5l+ljsIu25sD6zo6plaLAPyqrhkIg2jwvZx14tXrbumJtRLMgTZQNoclzW1U+LToH5liN3+eIqH7V4sIRCY5YcQf8tdOxYZyYskpjzdvQCkaPkPjgMNO94gkKFbBCTc56ZIyb4+VxNNhqMuNS9c6BiJmiebuYd9IbXLrsXdZU5s+A0sxRmR2/7Ri2yjSlnK5lE0qHB7Ihd4GMibnaSmSP7ayh47ZFpHx1CAZg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u/9tM6pr+xajvOGuQTJyQ8o+pCrhT9WtqXVYHtjBiCQ=; b=WJTBP6jFxYubrB/c2eaUJn22zf14QaXpduk/Gyf70670nCHn8kM3tEiKHqk9vllIiZwlxXUMc1AS2qAIyf09Nrai1X/cWFEVldgvBBBjY3AkTAHprunGWQFiPE4LoUD0afIpicob87qosSiqDFbqmgUU4aqjSyJAzNL3L+/I1+s= Received: from AM6P191CA0025.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::38) by DB7PR08MB3210.eurprd08.prod.outlook.com (2603:10a6:5:20::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.22; Tue, 23 Aug 2022 16:37:10 +0000 Received: from VE1EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8b:cafe::e4) by AM6P191CA0025.outlook.office365.com (2603:10a6:209:8b::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.17 via Frontend Transport; Tue, 23 Aug 2022 16:37:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT047.mail.protection.outlook.com (10.152.19.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.15 via Frontend Transport; Tue, 23 Aug 2022 16:37:10 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Tue, 23 Aug 2022 16:37:10 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 167d7e5ca281a806 X-CR-MTA-TID: 64aa7808 Received: from 25401fc3c547.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 04552735-499F-47C2-8D3E-E284B9F5796A.1; Tue, 23 Aug 2022 16:37:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 25401fc3c547.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 Aug 2022 16:37:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WM7h5UERo44BZ+D7qzZiq8OSDqEipxD295cfI3yKo6/gzUNBIXAUBTJJZVfUB5zviA63awGpR6Evel41Nqp+35afLSuB69ONjo8yos1vUmkGZ82nVa0QuOd7KXq6yECy42yEHv1N7wohnaMFrkGkcaVvEkIZ2XMWsKjrDfrsSwIGjlN+mlUE+cP8Bb26fQAWXwxe+tqy6Mlv6baWbXvZorqcjMmwvQJGCGbDZ+wMBWl2U2dU0qqaEUZUGz+Fk8Uh7Qs7Tv2OoHARRl4zmBkyVbABdR2/3glelKKSAMx/3JFCQsthKSFbFCPvWOz9beNqdSQFeyEm8w4ulmuo6GOCLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u/9tM6pr+xajvOGuQTJyQ8o+pCrhT9WtqXVYHtjBiCQ=; b=SmtfIztS0F/XoebjHkTQ1Odon4gFaY0vk3kCuxw5zNUbc40xUH8OK4feKpfH3fLJ0vCkNwdHvkT2vFso13OgSgZlBWYnUPpW8SOh9p5g0SyWBEc97ChjBDK69ACQiWr5OHzg/V1Jsa/7HM0ufayBpXBrB9IehuJHsjyYQCF9jFQDdMR6hiRDx5aTF1FQnodiVTy9+QNayOL/vWG+trdsvuJkGj51bvwlQiRyth1YeEnil2+LSESsxfmKfhgzxegwhZGw41brKIucOsiSbEzz4lfpNjMLE/oMwO0bvyUI1XgXicaAh3sB2lsw0yb7wbZ55mBF9IJzC/sdpY21+g+HZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u/9tM6pr+xajvOGuQTJyQ8o+pCrhT9WtqXVYHtjBiCQ=; b=WJTBP6jFxYubrB/c2eaUJn22zf14QaXpduk/Gyf70670nCHn8kM3tEiKHqk9vllIiZwlxXUMc1AS2qAIyf09Nrai1X/cWFEVldgvBBBjY3AkTAHprunGWQFiPE4LoUD0afIpicob87qosSiqDFbqmgUU4aqjSyJAzNL3L+/I1+s= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DU0PR08MB8472.eurprd08.prod.outlook.com (2603:10a6:10:404::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.22; Tue, 23 Aug 2022 16:37:00 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24%6]) with mapi id 15.20.5546.022; Tue, 23 Aug 2022 16:37:00 +0000 Message-ID: <1a3985d7-6bab-cf81-4bcf-8972e73a2212@arm.com> Date: Tue, 23 Aug 2022 17:36:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 5/6] ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2 To: Nhi Pham , devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , "nd@arm.com" References: <20220823105926.1379824-1-nhi@os.amperecomputing.com> <20220823105926.1379824-6-nhi@os.amperecomputing.com> From: "Sami Mujawar" In-Reply-To: <20220823105926.1379824-6-nhi@os.amperecomputing.com> X-ClientProxiedBy: LO4P123CA0044.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::13) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: a7e34c65-dce2-47a7-73b9-08da8525b9ae X-MS-TrafficTypeDiagnostic: DU0PR08MB8472:EE_|VE1EUR03FT047:EE_|DB7PR08MB3210:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: UtHSLdVu9tKI4+mroNKAvhfpOFYnbGYLTFz+60OFA1Oe+qjZBlHK7jXa995N+yNfRcp8GjRsjkVnNkWqm0YavXA3WNMKymS/3LU1LntUUvrrfFdHYUe5u50vYlPV2Hld/GjB6hc8KPVXN/3HUTKRASMtemJYAigHcLDimbdbfyW2ccWG05KLOmDjRnS9+9BrD1/XfJZfgfLk+1iIKGIT70mzgWdKoWm3+5YqMxhmumkpuuLNSTY+yN+RXnRJxujHysfFD7BFqkQVbYll9FdNI+PyxRnLANB80JS7on6YhJck4eH8HGUiKRafGrgBfRFWyG7RbuBbDd9izdVFg6U+vv02yCtUKMD0niXzZqCU28lgbUmScP7WFLKNZeg7r54gEod5X6tv63b+/NgH1dzmi8CAPtfZfYMvspwcLl44c4mNmI3ABnaQGTH6rDoZeWr0QMAwWJofvMZxLzB7qrCJdMetNDoL7N6arG6XuMX67twa53pm5Fe2wySBGji/2ruog8z/ENXUP0uxodMXoUTM442s17dhoShFGNrHIu8cbqVePGuH5yaslCt0SLZEUbAsqg4+TTX16mY+gcJw+n8z4oazFCLlNnmDzXgW/4x8C6wmuZpGzbf4xv5oC4bK6TjsKyNAc2NMYx3MHQFZQHDlK9FM6AmtrEZWivewiyM4Ds0MQDOYr3WYoaW90EPkoJEx74wIB5r3/ThelCsc+kadfdDtkl+9fHDVW6+M7WbEHg3SF/lJ1rVDpKV0jxsRNR7yb7XzJUkcNL1k8YXA3CGMffUjVZ6PYct8YwjaskNLhBo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(396003)(376002)(39860400002)(346002)(83380400001)(186003)(45954011)(2616005)(54906003)(36756003)(31686004)(316002)(66556008)(19627235002)(66946007)(8676002)(66476007)(4326008)(2906002)(53546011)(31696002)(26005)(44832011)(6506007)(6512007)(478600001)(8936002)(6486002)(41300700001)(5660300002)(38100700002)(86362001)(15650500001)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8472 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6685cd58-97b7-4d7a-208a-08da8525b3d9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1wuMrLNtMqOHLMq6P32wrJcVdDBAzVA97E4c/pci8DPmocRvf6gKaNUeKx6w9pJzUQ9WyPejopousZ1jZe2VeJzfgxxDfPl9DXq04XGkjPzg9BprpjJz9FSwKQIB0EGRF6RyR4sYrxJ7BKf8k41LrdDmuUYrRu358JBnIHLm+aQdXm3cAixL2ay2WG6u157h9bqKOs9hnNjZXqvJxrhQeR8SkM+2oE/LKJJJjX0xlmZVCi3tGoSESWaMLnA1L5fpD4mgZfVQlDkTB9TpntTtuDiS2Yshq+7EJ3TUpvuEpwukFZYjd3bEK4A1+tQ9J6Rs3i727Arat1V3s/gaOwGYD1GL7hdM8/Ql59eEw782CHRC8bK7EyAGEv4y9jY9VHjdJdA1G27sYPf/7apRbUaCAYvDp38JdLTr/3Z7EPEcaf0JeDJrl2P9RPFcmmgotCtuAtx29GdlH50Dgn8zCrvbJBtgjtlwTY2hRbhQ0iERXRS7orRaEpSjteHmKWWVsEwM0jo6/1SQhh7OiZi1ZkHGN3WUrEwpimHa/XLuybFacolRAywb15oAzcDUV6TZQI2OMUxBFqGSJ2qfohmNGhxY+px8FABfozoEi07xTWgz/fOXMDDF+roNaOHvAJ1EOY+klAyS3tRihagoArsCaUZkEEDq6E/Ze9cTPxYp4tk8MHZkDiusbvKQcBrQyz/SqGFtEgeqgs3IHFl6hCsdyAcPvOTSQX1rrD39VRKenFq5MJNKTtK0JjVXoO6mR1crNwamkUkZCcMCvO4NEpmK4ssPaFEEpBsFWFqIppjBRhPFoz6zKtHZM3lK4FxL9c9oNvz9 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(39860400002)(376002)(136003)(46966006)(40470700004)(36840700001)(53546011)(6666004)(478600001)(26005)(6506007)(41300700001)(6486002)(6512007)(82310400005)(40480700001)(4326008)(8676002)(15650500001)(2906002)(31696002)(19627235002)(31686004)(86362001)(36756003)(54906003)(316002)(40460700003)(356005)(81166007)(2616005)(47076005)(45954011)(186003)(82740400003)(336012)(8936002)(5660300002)(70206006)(44832011)(70586007)(83380400001)(36860700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 16:37:10.0754 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a7e34c65-dce2-47a7-73b9-08da8525b9ae X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3210 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Nhi, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/08/2022 11:59 am, Nhi Pham wrote: > From: Minh Nguyen > > This patch removes redundant updates of "BoardManufacturerType02" > and "SerialNumberType02". > > Signed-off-by: Nhi Pham > --- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c > index f61546955f12..3441e7798860 100644 > --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c > +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c > @@ -120,16 +120,6 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBaseBoardManufacturer) { > STRING_TOKEN (STR_MISC_BASE_BOARD_SERIAL_NUMBER), > > SerialNumberType02 > > ); > > - OemUpdateSmbiosInfo ( > > - mSmbiosMiscHiiHandle, > > - STRING_TOKEN (STR_MISC_BASE_BOARD_MANUFACTURER), > > - BoardManufacturerType02 > > - ); > > - OemUpdateSmbiosInfo ( > > - mSmbiosMiscHiiHandle, > > - STRING_TOKEN (STR_MISC_BASE_BOARD_SERIAL_NUMBER), > > - SerialNumberType02 > > - ); > > OemUpdateSmbiosInfo ( > > mSmbiosMiscHiiHandle, > > STRING_TOKEN (STR_MISC_BASE_BOARD_SKU_NUMBER), >