From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.12471.1580997591418178249 for ; Thu, 06 Feb 2020 05:59:51 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BuWVF93+; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580997590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OvjLRg26Ji7yT6a4Bz4bGxz/eqaOCFvjSGdPuOwYe60=; b=BuWVF93+4CGkWfgFyJKv0v5PGngzZCbXiMi19V3jUQv0E5x2/9iZqlMJfudFCEKuI7xTwz nJdEAJsaZDEMXRJSXx3kcCC5Hqh2crHou56UrQpzhdYfJpkUlsQc0YUN9rapOXTctTpRMc CywNInuZMuxyRcXBeibVrUCA7WA+Vv8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-434-Mr11_3A3P2uU5GzWUYyCuw-1; Thu, 06 Feb 2020 08:59:48 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6FDD110957D7; Thu, 6 Feb 2020 13:59:47 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-20.ams2.redhat.com [10.36.117.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1145A8DC1B; Thu, 6 Feb 2020 13:59:45 +0000 (UTC) Subject: Re: [PATCH v1 0/2] Fix backward incompatible CPU_MP_DATA struct change To: Hao A Wu , devel@edk2.groups.io Cc: Michael Kubacki , Michael D Kinney , Eric Dong , Ray Ni References: <20200206052356.3672-1-hao.a.wu@intel.com> From: "Laszlo Ersek" Message-ID: <1a49ccac-7d6f-7e74-1997-7ecdf8097de1@redhat.com> Date: Thu, 6 Feb 2020 14:59:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200206052356.3672-1-hao.a.wu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: Mr11_3A3P2uU5GzWUYyCuw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 02/06/20 06:23, Hao A Wu wrote: > The series will resolve a backward compatibility issue with pre-built > binaries (e.g. FSP) introduced by commit 88bd0661661. > > The relocation of 'MicrocodePatchRegionSize' and 'MicrocodePatchAddress' > fields in structure CPU_MP_DATA may cause access issue for platforms that > use pre-built FSP binary, since the offset of these microcode related > fields in CPU_MP_DATA can be different between PEI phase (in the pre-built > binary) and DXE phase (in current code implementation). > > The series will use the newly introduced EDKII microcode patch HOB instead > for the DXE phase to get the information of the loaded (done in PEI phase) > microcode patches data. > > Cc: Michael Kubacki > Cc: Michael D Kinney > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > > Hao A Wu (2): > Revert UefiCpuPkg/MpInitLib: Relocate microcode patch fields in > CPU_MP_DATA > UefiCpuPkg/MpInitLib: Not pass microcode info between archs in > CPU_MP_DATA > > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 3 +- > UefiCpuPkg/Library/MpInitLib/MpLib.h | 27 +++++++++++- > UefiCpuPkg/Library/MpInitLib/Microcode.c | 43 ++++++++++++++++++++ > UefiCpuPkg/Library/MpInitLib/MpLib.c | 20 +++++---- > UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 3 +- > 5 files changed, 82 insertions(+), 14 deletions(-) > Looks plausible to me, but my review doesn't (and shouldn't) carry much weight here. Acked-by: Laszlo Ersek Thanks Laszlo