From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0061.outbound.protection.outlook.com [104.47.38.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 69D5B21E1DAE1 for ; Wed, 2 Aug 2017 18:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Bu8at9g3F8i58tLSVy01UUPT+m+FhWY771ki5K8OMjo=; b=Ks1dfhgxEI7+K23MDG9pAfXlVFX0BfwsZwN11xqC6I5pKJNOiLVBGQzk8Q/AhvH0lUHa/z3abwuxQw5FQzGv574dj7otfpYB8JVb05Oaleq8RID85MRu31WaT6TFksH8yi9Gyt0Bx9NFKFpViWZfghRjvk8Tdu5MmjI73yVwR3Y= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Received: from Brijeshs-MacBook-Pro.local (70.112.153.56) by CY1PR12MB0150.namprd12.prod.outlook.com (10.161.173.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1304.22; Thu, 3 Aug 2017 01:09:59 +0000 Cc: brijesh.singh@amd.com, edk2-devel-01 , Ard Biesheuvel , Jordan Justen , Tom Lendacky , Andrew Fish To: Laszlo Ersek References: <20170802212453.19221-1-lersek@redhat.com> <20170802212453.19221-11-lersek@redhat.com> <560549ae-700a-2a1c-db97-0851d3a12fe1@amd.com> <4eda3a9b-6be8-ef61-117a-ebff5e988629@redhat.com> From: Brijesh Singh Message-ID: <1a75582e-a3ba-d20c-75b8-c558cd373787@amd.com> Date: Wed, 2 Aug 2017 20:09:56 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <4eda3a9b-6be8-ef61-117a-ebff5e988629@redhat.com> X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: DM5PR07CA0026.namprd07.prod.outlook.com (10.168.109.12) To CY1PR12MB0150.namprd12.prod.outlook.com (10.161.173.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eff7260a-43ff-4156-ceb6-08d4da0c5d17 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR12MB0150; X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0150; 3:ZGH/Mnh3C0VEFtwqaRTNh1/esdZiRmaRBvmICsffOH3sX2sS+ydTPyD2FTeQ4h936Pm2hwN46rZETw8zkvnZLjJ+EdfyZ5suuR9Egy60CJsVxCsnWD2RgNe04rBRAfJC0edQtsnksuFEO0Hco7nvlggXE7RZoLTzw0dccvfm9zMTpYRW/Cv8OmzpnRBhRY7+qWfqbhDdv8kz+1xeV8/KU3WSwpd7pcZeN+mUbvgUaxyj5KL/oMxAjGA0rE+QRA6vDwAiKUQSx7mcTJOrVhQjta5V7z8Np1KRJjhe7cCyKskwqis7m76izfxqeyamZV2fmL1bSTp66gT7uMKHWzXC6JAsE0lq4kE9VJWH86f1AjsyxTxYYZ8r5yMjxpQCTdyS7BWfaQ0GzOTXg3vyNBCNt8f1Fd6/bDtBcZhIEvJwaY+gcyKxNkQvLFJHgzgrusfAvzrAVMztPe2C51cQg95RyvbvLj8kk1u2/FMovBNIsG3DLh0TSFiJj55bYqSjsRCqdsh6wwx1fanwaX3EtsfZuInXyiKjISI0+g8m8IA91F5/DRrXDQQUY3zEEpqV7fNdyQHpRGgRWrcef1Apo7ZW+3oZEtqXo4zJrmvOPYxASBxvKPrAVoNKQrVvE7KecYEYebHBRA/8MQ5Nbc+/6KizlVs398bvVG/ZeIpIMDKZJ4tZ9xMuMxu2nnk1Ip6x+K8/jHAIPCo32Ir8K+rBMqQm7xFBXLHvf4WIln7DalWH0n+yHAc/oT+5LuZyzLBdw0mu7IVR4wNNmBMqofaXoUB/V7hgqzUgmRBdXTfG9IGlFsdS9zBazdHPS4BtFeQs9VuRvyRLn9efZo+EG//srdF5Mg== X-MS-TrafficTypeDiagnostic: CY1PR12MB0150: X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0150; 25:Ev3Ec7jcoQJ7Ojp8JmGJ87AHYHXcJ+RKXt+7UejpO/ZsHWHsOnD+htzKIfCycnw8Thbczu9lpwV2lDiZPP7fa/c6bxUzAaXKsQ8qWqbjO2kDBBlYEvq3zXZnCGQbgUlLdF75ln8SFnjJiH4G4H0RwB3Fiu/fJZSFnBW7VEtb/jnaRyyvSLwTTFZhX2Ww64keq1IopOKqwC7I08Z1A92REfVyZtlOBaSnturqXX/GjAlOpa6Xd+uyHKcU+mfqQN4XHAMG/FEaAJmdPbuK6rwBHQYGkDbcRu3D/RwWdOdfGiLLbNUZZcVTahfJUpQgtjo/4tUX9BZkD9rKNzO35LkYaYdG1ebwbyyB6087TDvTmtv9c4hJFUeQes+id52ifSKaIMNgsc+ODNiEBn4Kh8gYm78L9z5uDMvUyY94/zBLJ6hPv80QHtPTUaiocVK57SWOfdskFGD+7FOfQxWdsi3RQ9K6NOf/7xZQ5kgsyre+PzskfC1na3iEzFapG2bIN011ySnLaaQCQ8LUkbbroBM+iWUc7bbD9PB3N22tVMcInxt19VTm4t3OxtusttdIt5432uRsoqUlhBpJ9O/6nlgyd5QvGOm+GZm7EtnRznczAg8o9zKk2Yd5ZPKg+Pqr1ObM4WN8DshOlrPHKavI5BWckkT72HBTnCU1KlTYMi6Vu/ARDDDlx5tzK83H5b5iCaCfEhpCvPcjQDMAj9KxHMnKpA2iS2guF1NcOQwzHlyK1VeBl/v8ytio1u+7oTq1vyl4h2lVJZmHa72liCTqY/WkoI1P0j4wTbEUD2kjz4LQISn/CSXRlq5gmPbMF80OooxKeZTz9YSlvSr3mYUqVy3XMF+oC3ZdXvsJxPutzR0wSEUkxGXDWLyOV3WJYdAQ5JLNth/RPWOSIQWMHofbSmBe9A9y4mC6jT519t2CPqDxovM= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0150; 31:CrtSHDWQtCRNXzu/LSq+iPSPmVSeL5M4cAE0BktZMlEGcP9vu0NFQza5p91FFdLbpC2WgQiSdgKARZ5RN17c2kx8EpFX0g4/CGqepW9lr6UErYTPpZWHuK+17UmdeAtqDPbCtHPkj87FX5JRZsxdfak+CB0M6nk1/px4BDTb2A9UM343HMZm1Z49upBv9EISysJxhSgbU9OD6i5g8nC4kkdwxc8A3A14ENC32TckwoK8g9TUaP4O/aXVxrdk2zsCl6QgCVKdU+UsZ+mrrfFK9Yvqfqa09/KAWjW6SVWYaMbGYI3/0mtHzj2yERiB8TTZtqNbiwmhivyEk5sM5yHpQVIVhIvrA9ILRLkAPUWgbHr+KEL6dv7L+ynRAbDTz9oaDN/rJ9L55kA4yglMaSOH5tCN5TkGyn5jgEQzbfj2i7YQHHwbArP4Ct4BhTtxFbwtz6gOMva9JzX+uBGfM8ckPoYyPYZkodNvmLhLYXtMgfeRCzfMSurIrKllwUWgxoLBEsGGThhJ7pJE95SzvGfL9VI8c8oAtHIg6v/li2dGbGIIWDxP2ijXUEoU+4AK6aLHXttii2KImxXaR+tDnKhEBkS3i0jr1scBj7n7tkfGYbiifQ4Mw0TnD6QjzoaNFgHFRUsv2gS3ZGIzN8ouMzr0GoV+rZ4pC60E59wGYT8ho7s= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0150; 20:qOxlS0vQQdTZxhnEyKEhEH343bzCn/QOrDFtHHHl5nvVVLel5ZjmkvuAsmH9zNFAEyU+YXhoVELKwp0V6LZZzoD6RcQOuQRRJHEXKl1STwa7WCa2rTyD+V2nvze8bAd6iF2fkzW91K6qoNn4QY4dNqI1ZDbBonhVs0n9+J0XTrxH6TL686xD3pcQZLqwVAXbqGLzUkiPG675aBn1MzlsgPzDvUoMwvaFF+y4R3eBjqwkxgkPOjah0UFEXLVDqirbm3zyL/G2szGrB3Zwa8e61qH7nla72n+Zvlf9zUwZo+aO6D69KVjSGzuahfNm7NZXr4tB5e+pMYK+cnpksqOaHKrluB9j/f4H0dr/EhAXvgh6bh/oxz5X8BuM8PjgvPJ2blHV4euJZTNVVlmowJHyRKQybgLruRwExFNASBbqju1V5rwn5N+JeMTaegyfXiD5WOhzmQUvlA37ZPdZPNb3fW9PVAeTeVTl1yJ1tEPM/SUSVs3oD73rqfTqHjEuaCUf X-Exchange-Antispam-Report-Test: UriScan:(31960201722614); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123560025)(20161123564025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR12MB0150; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR12MB0150; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUwOzQ6Rk1Zby9TK2l1ajgwWlZRKzR2N3h0elBPc2Vx?= =?utf-8?B?NEYxUGdRYU1iVG5sQzJDZitIWWozM2FzOFdBZWpEdDZrUURkaVNxMU8xQkN2?= =?utf-8?B?YlNmSHdSaG0vdkJEcEJYYXQ0azdxanRLTzVJdUZsNHNBSWI4MHpuMEJ5aEtx?= =?utf-8?B?aVorbFMrZkRJbURLcWt1YnhSTVVtL2ZHSWtiN2hyaUZvTU9TTnVRTGd5U2Vh?= =?utf-8?B?a2VsN3Nid1gyNFlSejFaaG1WYm9lMWxRbm4yWmxEVTRXaTZabFluT1ptalo4?= =?utf-8?B?SmQzMW96RldjN2tVTFcrNnkyTGp4RWtTT1JyMU9CbFhObUlXWjdEYmFubUlh?= =?utf-8?B?QVVkNXUvVktXaDdPVk1TM0wrQ0RQaTZKVGRMU1BXYndqbG9ra1NpSitLQVpN?= =?utf-8?B?ejhUelNaZjgwaGtEb0JjOFhtejB1SDhicGVBN1FmOGpucitjUjY0TVR3cTBh?= =?utf-8?B?YmdZSzdSRm8vVFVjZ3ZFY1ViK1M2RHdqQTM0SDVTTE1CZlN0dGZUbDl2ZnRY?= =?utf-8?B?cU55cUNhU0dRQVhZUUREdURJREVNNHQwWkdWVDhwclpPVjcyMXVWWnM4dEMy?= =?utf-8?B?ZnpZR296RnZtYmZxdzNWbXJKNGY5K0JEc2gyU2FtN0YxV0xzNTFpdUV4M1Rr?= =?utf-8?B?Sm03K2xUSGZtUWhwK3hZaENBSklxMUc0NVAxUFVVS0RkcGhqY1dCdnQyU1RM?= =?utf-8?B?enZ2Y3YwT2UvQWpERzdlb0pzQnZRRGE5TE9lblZUdjR0VjFRc1Vpakw3SkUv?= =?utf-8?B?aHl5bDcydGZnTEs1UXlITDVyR1NDOEc3U09IeXdzc0ZsaisyZXpEQktUVUtE?= =?utf-8?B?a0lyY1RZUytTT1VxWGh0MUNQc3RlUjRZTkpONkJDYmEzcklvczRQZ09YaTRV?= =?utf-8?B?VzluQ0xZdXlXQXBiREhRWjVkY0VkdGpRei9NQVBZU3RycUNuVnJ6ajNDdWJY?= =?utf-8?B?dzNUUDNzRitUNEtzOVVxcTU3aDFTdDl4VTNYbjl0RnBseFZKdVF2V3ZtbHU5?= =?utf-8?B?ZjJsRWVsaWRrWGlNOEpxTjlNQ0NVblhrbFFJV28vVjg0cDVXS3NQbndFRG51?= =?utf-8?B?K3E0STl3MW1UbXRGU3hZNFdvQnR3K2lkT3BpeGdFY2E2eEpYMm9VYzNySHVP?= =?utf-8?B?aDhjY0lpeDJXWE9keHhtZG91RWhnMHo4NDYrZUF1TnhOMEtac1lqeWlaN1pi?= =?utf-8?B?b3pzUDh3ZktpcVliRmZEL2c3amw3SzZKZXdvOTVPdFhTYUhhcVNvQkZEdGdN?= =?utf-8?B?RU1PczNLRTZubmozU2V2eGs3OXMvV2NPK2VYbmZKcjJTdzd3S2k2YWpxaUVL?= =?utf-8?B?VDc0dnBSUnRscXMxQU9CcmpseXlYTVZ2NGNaVjNBTjNybEE0aUo3dG5TQW1p?= =?utf-8?B?KzhhMUhkRUdiVURHcnNsd21RV1pxYy9EbFpPRFIxTllPQzduLytBUEFQbE9V?= =?utf-8?B?M2VPbXBqM1RsMm1mTHNZVmZidlNKbFdzaks3dWRTMWZhREhtSitBWEdwcVkv?= =?utf-8?B?QnNPVFgweHdrdFc0M0xuRFRCQngydjhkWjVOWU5pR0pObjNad2FiamNXeVFT?= =?utf-8?B?bGEwclJpUEZLb0g3ZGh1WEdDZjl3SGFCVVdRQ1lkMHNwUGZhVlR3VlJVTUdn?= =?utf-8?Q?ykVpp1sOvEc5DVPJ5xa?= X-Forefront-PRVS: 03883BD916 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6029001)(6009001)(39840400002)(39450400003)(39410400002)(39860400002)(39400400002)(39850400002)(24454002)(189002)(199003)(377454003)(93886004)(105586002)(305945005)(229853002)(966005)(42186005)(106356001)(25786009)(33646002)(50986999)(54356999)(76176999)(230700001)(64126003)(6486002)(53546010)(31696002)(4326008)(4001350100001)(6666003)(101416001)(97736004)(3846002)(23676002)(50466002)(6116002)(38730400002)(110136004)(6246003)(68736007)(6916009)(2950100002)(65806001)(2906002)(47776003)(81166006)(81156014)(66066001)(65956001)(8676002)(478600001)(189998001)(5660300001)(65826007)(31686004)(7350300001)(6506006)(83506001)(6512007)(54906002)(53936002)(86362001)(36756003)(6306002)(7736002)(8666007)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR12MB0150; H:Brijeshs-MacBook-Pro.local; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUwOzIzOkthRWkrR3JzK0R2WjBpcWExd0RDaU92eXAx?= =?utf-8?B?MEIxZ0xobDROVHl0VzA3VjNoMVY1Zmw1aEU3T3NvWk9WVGMzN3JOQXRCYXBJ?= =?utf-8?B?a3ZGRFVtQnZ5dmZKMEZUcTZQYWtpaEhHVFRwRWZYcGtPRy9TSW9DRzByUXZj?= =?utf-8?B?MDNjMDdQTXZNL0M4YVlyVlFNb0tVN2owMW01bHBIWVFOOTg1MXFUZlkySHpW?= =?utf-8?B?ZmZRcUFxRFFaeXBzVjVKYU54YTZZK283VkQyNlZSQjYxN2tscHhQVnFjLzVs?= =?utf-8?B?c1hXeDcyWkxFTEdjYWZkZlFZTGhPeDZFcG95SUhCeG9QVFg2QjhrT2VZeFVs?= =?utf-8?B?NDlrdnprWm9scks4eVJWVUpFUkNNWFpuR3ZsNnF1eHNWUVVSM1pXOWczZUxm?= =?utf-8?B?NnBmWnN2ZWI4c2J0OHpVTnJQYXE1Z2trUG1lbEJIUlNSbGVhV3BqUHZpTnl3?= =?utf-8?B?alhIc0kzTGhidkNJUEJWNmVHaDVrcVQzZHNKR25CWWNUZjY1dG91MmJ2RGpS?= =?utf-8?B?R3RFMkd6SVZpMWlhSlNtempRNGdXUlJ1Tm9wbUQ1a0huQlZVYkJRM1RtYjhq?= =?utf-8?B?ZEllWXp5enBuOUlGUVNGaXlIeC84MUhJVERLdXRGQnlJV3V4M0EwcHdSRURB?= =?utf-8?B?aHZEVUNJWDFIWmpXZnZ6NHc1L3VXbUdJQ05GRTY1UVdVUmVyUHRvZllxZFMy?= =?utf-8?B?Rnh0OTQ5K09oTXNKZlJ2cHBDMC91Ym5KaStFODVGbk5XT0Q3SUlNTjAzRFZG?= =?utf-8?B?V3UxUXRoZnBYemtlMkNiNVdicDU2bGtjWTVFZXp6ckxIcWpzY0pTMGE0WTBu?= =?utf-8?B?YmxWdllja2dWeWdBQmdTYWpJeWx2YmZLWWdWa3RFSGhKQStQcnBWQWwwbVda?= =?utf-8?B?NlQxSUNhaUtkWFpIb3RHUDR1blJHczFFcXF4WWhCeVFnWW00ZzdXeWlBT2ZV?= =?utf-8?B?cmtibWl6bUo2S3pNNy9lZGhib01zRUFCRy9wRUxKcC9tci81blVvT05IWm9n?= =?utf-8?B?bTdZaVZpOEFxVmo1RmhLb3R1UHBvUVE2U0RnMEt2ZVZNcTQyWnBkRHVCRGJ0?= =?utf-8?B?aHp2RmVxNDM3RGlHRHZWMkhjQUpHbTMxMzc3Tm5ITEtGMGdVdXgwN3E0a3ZK?= =?utf-8?B?VnFOSnRueVBrKzB0Nml0NzNoRVpXVDZNMG55UlY4OWRrNVViMTJIQng4V3lj?= =?utf-8?B?dzJ5azQwYUUrYU1aVGI5ay9BZEVqWVlkNTZPSWs2RUFDNE1vd0JMZzg3SHFX?= =?utf-8?B?ZjE1elN0czZmcHJ1M3lLK1dVSzhiZkJGS0VVV3g1OEhjSE5wVzdpTUFJTzFG?= =?utf-8?B?RkJhaEU3Z1Q3N1FIMkdYQTlWY09EUmZnNFFUazF6UWxWNVd6QjNNby9oTjVq?= =?utf-8?B?dkEwR2MwNURibzVFK1FFcTNlYjN6TkxodkNjMDl6bVZxcGptdForL3FFZC9K?= =?utf-8?B?c1dWU2I5K2VqWk1aQWhVYmh0K25VQXU5R1dZa3ROQnY1amlZTm5UL2FVMXNL?= =?utf-8?B?V2cvUkpyUVB0RTBGV2NRRFZlOFhudFhzc1A0aDdHTTBYODk0VTltZnV4WVpK?= =?utf-8?B?TWFNVGt0dTIvaGVvNHlKeVF3ZThOaHZpT01BUEIrbWxwcUFEdk1ZVmZablht?= =?utf-8?B?NnJWOWVaRGxrYXVDK1Z0V1B2clBSMmlrTXQ4N3dWWXhvYWo0dDRyek9DSFBq?= =?utf-8?B?S0FSeWRZakwvRzFjSU5kTHVvN1c3THkrbDBQTDdBWVVTQnorbzkvUGdnMUs1?= =?utf-8?B?MTJsdW9TSEJZMmpqR3VmcDEvcmoxdkp4dkxLckFJalZ6c3ZiTG5UenI3NDMr?= =?utf-8?B?UFhRNFprM09pQ3FiZVI0SnYvakFqN1VSWnVndTdJcDR3UzNqaGkzanB5bXht?= =?utf-8?B?S2xkR25ERlZBQlJRUVlNTHZlbXRmR01Lb2MwOG51WTBBNEFZa0ZuekRndSs0?= =?utf-8?B?SUxMRm1VOTA3cmgxQ1A5VlkzSm1iMDBoV1drYjlGOHRWOUtiOG5wS2pJT1ZI?= =?utf-8?B?SUVoaHg0cW5pa0grUDNYZ1E3RW5PQ0J1YmhCUUUxSUs4dlE1Y0hZeHlHQUh0?= =?utf-8?B?SDR5TVhHYzY0amxIUlNQcnRjQnducGFBNUhpeU41SVBlYWMwa2dEZndOaUlO?= =?utf-8?B?N01Va1lPYjVGNGVMVHZxZkVLd29sbHd6dE9IQm0weGNXUG1wQVNEcEx1b2tm?= =?utf-8?B?QlhtUkd3YlhDU0NNMlBOaGIydEgrWXhhdi9ZMndBNFpFZExOeU9zTXpvNHZE?= =?utf-8?B?TUNkQVRTaEZ5N3lNeGllWFpwRERwcGNhTWZxRkxIbk1BM1VJOFJVZEw3Yjkx?= =?utf-8?Q?yj9K0LI3vcA1Ws9g=3D?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUwOzY6RThyUHhBa1hEMDM5NHZnZER3VGFuMnZzQTJP?= =?utf-8?B?RTBhZEQrbEFIRi9xTkZyYmlpOG45NXNRbkU4WkxaN1ZOeklydDhHdTdadGZj?= =?utf-8?B?bWxiRmNsaG4wR2hNV1R0UThoaEJwakVsVGZwUDFJMlNucDErMG50bFYvMGxO?= =?utf-8?B?a0JGMk16M0p6V3ArZTEweHR2Uk9IeGZwYUF6WitWdjcwYzJxZEViTlgvUlp2?= =?utf-8?B?TnBlNmp3UmZKWjB4dHc0Y1lQV09VQ01Hd0RiZ2F2c1M5VnJhaTZnaDErVXVa?= =?utf-8?B?WnVkaTFsckZ5U3djNnkwUjN3OTV1UlBsdFppbVNaUVF2VkdWR2k2em1IL0dG?= =?utf-8?B?UWIrRDIwckhad29mamxiQ3hRRzhLanNJcy9ua1NaZTZjSG1nZktsKzJIS1cw?= =?utf-8?B?Ykk3U3VnVkdnMjIvM0U5ZGxTQXZqcUh1b21KNm42aDNZUmpkOWFxWHBmT21w?= =?utf-8?B?azlhajBNVkJCRTZueTFFUWRwNG9ucmhxN1lPVWFEV2xxRTluK1JYdEtYQ2Fr?= =?utf-8?B?VGFpc205RnoyR3ROTWVJMDJVaFZMdTZTUmlEcEtzcE1NdmdsanhxVkkvaHJL?= =?utf-8?B?Mkh5U3NZdGhFL2JQU3k4MDhCenoyYjNVdG55RHZPVGNkT0ZGdzUrTVkzS2dT?= =?utf-8?B?SUd3SzJsdEp6bEpmaFlkWUs0Zmo0TkIxNEZsZTRRZVJNWmk2MU9SeDIvbjdF?= =?utf-8?B?djZud3BBdjFMTitVQU41SmZoRXRGVXd2ckJuZ1pRUXR1R0NCWHlYWFQrb3Fl?= =?utf-8?B?cEUvd1pkbERrMnM3cnRaSjV0WFNlMDVNdDJOWitxU2lDNTBBczNBeHBNdWQv?= =?utf-8?B?THBEM09YVFg0eEs5NHM3WDgzQ3BxaklSTFNEbGp1bWhEbWIva2xTeEVTMjF2?= =?utf-8?B?RTd6ZXFJMlU0Q3lyMC9tWElYNk9OUk9GeWxYZmtLd3JzVklhRVExTS91MHcx?= =?utf-8?B?Tlp6NlFpRmNuYnlPYi9RZ1hwQjBTNFp4NDZsS1lKN0cyZ3loNFAxcm9zV0Ri?= =?utf-8?B?cXFlR2wrOXBJM0JKOERtK0tHVEd2azZNOC84SnQzQWRKRjF2Z0p4bE9hSGNS?= =?utf-8?B?VTBLcXFtdUtRUHN3OVVYVUtXK2FYREtiaHBZdk9UMDV4Skl5NkZmQWZGMDNM?= =?utf-8?B?RWVQMDZaOHFaSmxodTBWZWNnbkVYM2dpRVlYalNUeEhqR25LU3B3VlJ2QjJB?= =?utf-8?B?V2NCempMT2JETExqZFRJN0ZxWHhKRW5rTFk0aDdsTXl3N1YvWFE0RXNJVnhh?= =?utf-8?B?Q2N3TGZpbjdJdlcyRmtkalhHWFlmbFo5WkpHUFg3RmtWTjR0VTVsUjlacU95?= =?utf-8?B?VlJKdHlsaldYT1Y4Y09nNzZUampCV012OHVRZWk4c1gzZDhDelRPcXNrMUhm?= =?utf-8?Q?+G/DEZU?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0150; 5:2hgq3bEqxt/w37nfmtOCnu0ZzCcBTBg8dW7GuwrCdkJxaBMTV1BiUOiT/fj5IX2AXV/z3DfN/SsRgoCmO42Od+D+PGtl8FLZdtCvVumi5qIr0TgTfAlrKBufWuuRTsUJT/byBOYwIeOgw+bcWEalH2c01bXxIfdBZnGtutNxm1chcEW6L1+dppEbUBobOKCEeMP+EE+wePbWajHRXQ+G6x8JmMVjTJXd+kbUq/3CczoWqUzuESWzhePzQk9dO+VJp6fMsxcsbX36ZtmQOlkY/OMORcKgwgrf19lBrME4YsUENNkKxH2M8HB5zV2AZ6D7xqD0hiNkTLseGvI2cIb6o8bEwpcCRgvIoBeY5tJgm8wlIIpIJ0GWFn9pguoT0W6StRvGclExGJB+38MziuyBKE+JO/dTfAcuOZC2+P2JCdFE0oUKP3qlk4D8giAC+2U++2oYF9X8wYib7d9uhCWVhjNMwD7LUeBk+n0bciAgEPPAd0kcrvZmQwIcdKelTJbY; 24:7jTxIB3cKkjFL0agc08D+1B8opqY9FScfm39N9zBVmL9loAlm7rUvjCvI1mKNEJ5YMJr9v0D0845tGJtNX44/e/5G557duhwGl515NqMl9w= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0150; 7:c3yOi6vfpcCfsqQzwR1ycQpd1M3WEJfktYmYdOB75A4TwtDkrMK1gdQrYv/Ng5DV6dnSMrpo+ZV3kK6lXsc4O6bpbKpHbaSKVuRpQ2kJhtBf199yEJeOt7BVup48ZxWNV6BU33/M1qAuBbXlsuF5fuTiiop7VuYlQtr59vCWIr8HIqqOnbS6bVtnwL0CCRDskdhEsSqTmj0soyjKeuFBr3ZQ3n0+CZcziU3EKzWk9gyChZt9qgl0LZfRgs4YNNZAo0N1SU/xR2tMO6mD6DcQzHH/4fGDfzx+VF12iknuTGdSJaUWN3TkZXke9imWYEkZjV/RxeSFC2c+DYB2o7VZZAvFlVwRUIjLQzLHBM8V7eg6MSyKyH27zrFZtjwHrQJ1MOBlcx9bAFZ10k5MjXcjLXDaBCmcWRAZ9wR8lggitb4+F2I7/zuPyhM/OtbP7UWxgLHBsOLcxusp+S50D/uIvf7FdwDjM0XTgWbYyVmWqj7pI/tBWhGgtrkzvbXfo43RO1KjwG/xkIFDN+6ONfzvvSvolo76lQxvtEFWJcxIdAOEaF7p/2cBmZOHVPw5o1L5pBaJc1MyorvngHgEx5vDbm3EDwRq0/lfDo1DhpMGSGF6ypRisGbggkDPfnZG4xHDOwx0I1sd446oBHkjkDzo47DfjPPpMZaRAb2Oc/FOFMu3cSmbtNAqZBei6N4S1ZA3gMr1CjSzS3Zl0M4WGryKwcHyxrbINwVgCSfZf2hIUj0LYFPlKF+haUNFbGue9M9xvn6943skM3EJtUFBZsMKkGvXwJQKOJOKpTNMDPaVSIQ= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0150; 20:PzQJa3kYiAxrg0WwvXYxSq50IGx1lV3xQSPABkXonOv1S9Rh1J6qM5eYb27UU4BnbHIy9aDZDPE2zmfk2N41TlH8h3QBVupTtRo7dAP0/+5Z9w+P9wM0mhBEIKQV1A3rqFmx7WFcexmKA3/1b1LiwlMl8hqZ+8wWrG3FrJRwK0Js0gTLCwbRa5YmBfynEDbEhh5EFs3QweYuRwZl8YPcrp7UG5VlLQWqbLkz494Ab4+5/Y4RADcHUJiqKfF7XbAz X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2017 01:09:59.6761 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0150 Subject: Re: [PATCH 10/12] OvmfPkg/IoMmuDxe: implement in-place decryption/encryption for Map/Unmap X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 01:07:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 8/2/17 7:13 PM, Laszlo Ersek wrote: > (CC Andrew) > > On 08/03/17 01:01, Brijesh Singh wrote: >> >> On 8/2/17 4:24 PM, Laszlo Ersek wrote: >> >> [Snip] >>> At the moment, we have the foll+ // The buffer at MapInfo->CryptedAddress comes from AllocateBuffer(). >>> // >>> MapInfo->PlainTextAddress = MapInfo->CryptedAddress; >>> - >>> // >>> - // Therefore no mapping is necessary. >>> + // Stash the crypted data. >>> // >>> - *DeviceAddress = MapInfo->PlainTextAddress; >>> - *Mapping = NO_MAPPING; >>> - FreePool (MapInfo); >>> - return EFI_SUCCESS; >>> + CommonBufferHeader = (COMMON_BUFFER_HEADER *)( >>> + (UINTN)MapInfo->CryptedAddress - EFI_PAGE_SIZE >>> + ); >> One question, per spec, is it legal for client to call Map() at some >> offset within allocated buffer ? >> >> e.g something like this: >> >> * AllocateBuffer (, 1, &Buffer); >> * MapBuffer = Buffer + 10; >> * Map (, BusMasterCommonBuffer, MappedBuffer, 10, ..) // Bascially Map >> 10 bytes from offset 10 > The input/output parameter names seem to counter-indicate such use. > Namely, AllocateBuffer() outputs a "HostAddress" param, and Map() takes > a "HostAddress" param. Plus we have sentences like this: > > Under PciIo.Map(): > >> ... only memory allocated via the AllocateBuffer() interface can be >> mapped for this type of operation ... > Under PciIo.AllocateBuffer(): > >> The AllocateBuffer() function allocates pages that are suitable for an >> EfiPciOperationBusMasterCommonBuffer or >> EfiPciOperationBusMasterCommonBuffer64 mapping. This means that the >> buffer allocated by this function must support simultaneous access by >> both the processor and a PCI Bus Master. The device address that the >> PCI Bus Master uses to access *the* buffer can be retrieved with a >> call to Map(). > This second passage says *the* buffer. (Emphasis mine above.) > >> If this is legal then we may need to build MapInfo during >> AllocateBuffer() to locate the "StashBuffer". > Right, in that case we'd have to build a list of allocated ranges (an > interval tree of sorts) in AllocateBuffer, and convert any > CommonBuffer[64] Map() call to its containing allocation with a search. > > It would be worse than that, actually... The pattern you have raised > could be taken one step further: do one AllocateBuffer(), and several > CommonBuffer[64] Map()s into it :) What should happen if those maps are > distinct? What should happen if they overlap? :) I can't even imagine > what this would mean for SEV. > > ... There are guide-like sections in the generic description of > EFI_PCI_IO_PROTOCOL; Andrew quoted them earlier: > > http://mid.mail-archive.com/A29CDE8F-C82A-4C92-ABF8-008A9BF8F230@apple.com > >> DMA Bus Master Common Buffer Operation >> ====================================== >> * Call AllocateBuffer() to allocate a common buffer. >> * Call Map() for EfiPciIoOperationBusMasterCommonBuffer. >> * Program the DMA Bus Master with the DeviceAddress returned by Map(). >> * The common buffer can now be accessed equally by the processor and >> the DMA bus master. >> * Call Unmap(). >> * Call FreeBuffer(). > Look at page 854 (printed page number: 784) in UEFI 2.7. > > Thus, I don't think the usage you raise is permitted. Sounds good. I did a quick test on SEV hardware, everything seems to be working well. I have started my stresstest and report the result tomorrow. -Brijesh