From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id F0F9EAC0A72 for ; Thu, 2 May 2024 06:33:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jNEPo6y6iDo4Q2js0MbxzwtQlp06LijW2/zTriH7Njc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:Organization:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714631627; v=1; b=WLg7V4jevX3NqvGbaaDkp4PC7xzkOTz8qFAyqZZZmXADVsyNQ3Qx+EoO6h22jB+W4XfYWw4S Ub+0ms1CRL4g1YHwPw0CqI3wPlsgPlklXWK3aiPwy3xT6EahF5FcI9MzivzdbuxTD8CLuzNWeAd SmftsBqBgAFu0yRJ/kGPwgShsoK3Cr2mHSbkO9Tfv1/pnGVP8CWWgnkUcD0kOlIQUoO0rK01NuS QVyMlHEPMK1IToj+wC+GYE/bHRJilLWEKvi7H7Xfn0aOTA1GDUy+R+/y67BYuwtB2nCqdJv6adJ UwV8U+ckEvhPB3l6pP96wzUaQbtZGoDtFmkOOp/s6spAg== X-Received: by 127.0.0.2 with SMTP id wWUGYY7687511x1o7wSaJ5GL; Wed, 01 May 2024 23:33:47 -0700 X-Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx.groups.io with SMTP id smtpd.web10.7192.1714631626457214696 for ; Wed, 01 May 2024 23:33:46 -0700 X-Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2db13ca0363so121321871fa.3 for ; Wed, 01 May 2024 23:33:46 -0700 (PDT) X-Gm-Message-State: QkSNohDgyavAZ3VmCf0Zpkfdx7686176AA= X-Google-Smtp-Source: AGHT+IHGsM0fZJ8AENw9P0+y2mXUlRT+qBrCMcGHUmpOiiWn7Oa2eeTJObz1J7AWJYkble0ZH2+9rA== X-Received: by 2002:a2e:a26e:0:b0:2e1:f255:6673 with SMTP id k14-20020a2ea26e000000b002e1f2556673mr318468ljm.13.1714631624140; Wed, 01 May 2024 23:33:44 -0700 (PDT) X-Received: from [192.168.200.106] (83.11.37.15.ipv4.supernova.orange.pl. [83.11.37.15]) by smtp.gmail.com with ESMTPSA id rv18-20020a17090710d200b00a5244a80cfcsm168262ejb.91.2024.05.01.23.33.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 May 2024 23:33:43 -0700 (PDT) Message-ID: <1a957a2a-f055-4af8-bdca-e6117a0dd5ae@linaro.org> Date: Thu, 2 May 2024 08:33:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 To: devel@edk2.groups.io, michael.d.kinney@intel.com, "rfc@edk2.groups.io" Cc: Leif Lindholm , "Andrew Fish (afish@apple.com)" References: From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 01 May 2024 23:33:46 -0700 Resent-From: marcin.juszkiewicz@linaro.org Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=WLg7V4je; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io W dniu 1.05.2024 o 19:43, Michael D Kinney via groups.io pisze: > I would like to propose that TianoCore move all code review from email > based code reviews to GitHub Pull Requests based code reviews. > > The proposed date to switch would be immediately after the next stable > tag which is currently scheduled for May 24, 2024. O yes! Fully for it! Does it mean edk2 only or edk2/edk2-platforms/edk2-non-osi and other tianocore/ repositories? > * The Pull Request submitter is required to invite the required > maintainers and reviewers to the pull request. This is the same > set of maintainers and reviewers that are required to be listed in > Cc: tags in today's process. That can be done by github action started automatically after opening PR. May require changes to GetMaintainer.py script. Would be good to have in case someone forget to add one of maintainers. Also would be nice to have a bot running PatchCheck and uncrustify on PR. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118499): https://edk2.groups.io/g/devel/message/118499 Mute This Topic: https://groups.io/mt/105847510/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-