From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.11554.1683707577813415753 for ; Wed, 10 May 2023 01:32:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NHSQCiKf; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683707576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HBD83eGk5xZqzwTAAR50UAq6ecOx+htgo51ptST9mbs=; b=NHSQCiKfLa1c9LSYG69eBmGmEqCovYifjl4PVgZLYrB8koz+LBFhWwL4hRf26/ruPfNeFK yxxCaf1IkaML4IMzPGdbuNq7FKL2fOVEs0R98WKOlN2YNmfcqBjo8jQXjX4RejJhSzpMOg H0y+e0YP9zfql/gcQ4GjLfLRulpgRQA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-27-2_CH2Lh5M1OadAhGaXBRSg-1; Wed, 10 May 2023 04:32:53 -0400 X-MC-Unique: 2_CH2Lh5M1OadAhGaXBRSg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F240D868C95; Wed, 10 May 2023 08:32:52 +0000 (UTC) Received: from [10.39.192.106] (unknown [10.39.192.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D98D914171BD; Wed, 10 May 2023 08:32:50 +0000 (UTC) Message-ID: <1a999e55-a90a-dfa4-113c-3bcd9fc15d86@redhat.com> Date: Wed, 10 May 2023 10:32:49 +0200 MIME-Version: 1.0 Subject: Re: [PATCH v2 02/12] MdeModulePkg/SataControllerDxe: Log expected errors at DEBUG_INFO level To: Pedro Falcato , devel@edk2.groups.io Cc: Jian J Wang , Liming Gao , Hao A Wu , Ray Ni References: <20230509163212.291333-1-pedro.falcato@gmail.com> <20230509163212.291333-3-pedro.falcato@gmail.com> From: "Laszlo Ersek" In-Reply-To: <20230509163212.291333-3-pedro.falcato@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/9/23 18:32, Pedro Falcato wrote: > When a UEFI_DRIVER attempts to open a protocol interface with BY_DRIVER > attribute that it already has open with BY_DRIVER attribute, > OpenProtocol() returns EFI_ALREADY_STARTED. This is not an error. The > UEFI-2.7 spec currently says, > >> EFI_ALREADY_STARTED -- Attributes is BY_DRIVER and there is an item on >> the open list with an attribute of BY_DRIVER >> whose agent handle is the same as AgentHandle. > > Downgrade the log mask for this one condition to DEBUG_INFO, in > SataControllerStart(). This will match the log mask of the other two > informative messages in this function. > > (ported from commit 5dfba97) > > Cc: Jian J Wang > Cc: Liming Gao > Cc: Hao A Wu > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Pedro Falcato > --- > .../Bus/Pci/SataControllerDxe/SataController.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) Reviewed-by: Laszlo Ersek