From: "Rebecca Cran" <rebecca@bsdio.com>
To: Yuwei Chen <yuwei.chen@intel.com>, devel@edk2.groups.io
Cc: Liming Gao <gaoliming@byosoft.com.cn>, Bob Feng <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: trim warning to error
Date: Wed, 18 Oct 2023 11:16:46 -0600 [thread overview]
Message-ID: <1aa468e7-409b-4d3b-be69-8504e61f9c30@bsdio.com> (raw)
In-Reply-To: <20230922064708.1843-1-yuwei.chen@intel.com>
Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
On 9/22/23 00:47, Yuwei Chen wrote:
> As the error is changed to warning, Trim.py will skip the build
> error when the source code have exactly issue.
> This patch change warning to error to opens the checking.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
> ---
> BaseTools/Source/Python/Trim/Trim.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/Python/Trim/Trim.py b/BaseTools/Source/Python/Trim/Trim.py
> index c479f7d2b2e7..416935df5e90 100644
> --- a/BaseTools/Source/Python/Trim/Trim.py
> +++ b/BaseTools/Source/Python/Trim/Trim.py
> @@ -281,10 +281,10 @@ def DoInclude(Source, Indent='', IncludePathList=[], LocalSearchPath=None, Inclu
> F = File.readlines()
> break
> else:
> - EdkLogger.warn("Trim", "Failed to find include file %s" % Source)
> + EdkLogger.error("Trim", "Failed to find include file %s" % Source)
> return []
> except:
> - EdkLogger.warn("Trim", FILE_OPEN_FAILURE, ExtraData=Source)
> + EdkLogger.error("Trim", FILE_OPEN_FAILURE, ExtraData=Source)
> return []
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109767): https://edk2.groups.io/g/devel/message/109767
Mute This Topic: https://groups.io/mt/101516516/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-10-18 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 6:47 [edk2-devel] [PATCH 1/1] BaseTools: trim warning to error Yuwei Chen
2023-10-18 17:16 ` Rebecca Cran [this message]
2023-10-24 1:04 ` 回复: " gaoliming via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aa468e7-409b-4d3b-be69-8504e61f9c30@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox