From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8C539941AC5 for ; Wed, 18 Oct 2023 17:17:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XdK48ZLEHPft1oIhAhUd+lhZjI/NTTSQrOF+GS2hIrg=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697649419; v=1; b=uBjcVQCgFCk15Xp8fMKIznD4+cTtgfk6wiDpF4ElnthGRWGchVKSH3dB1rGJAnww1SNZldtn q0J4AOSRRD6H6ZEEQvOfNZENIgPza9tFxZDXleUyb+kbWn0qB9o84NtFHRp+RRPSDnb3uYBg7vp LYD8GAkeeryu3hJog/Z0eIVo= X-Received: by 127.0.0.2 with SMTP id M6D9YY7687511xTYfu7EN7ea; Wed, 18 Oct 2023 10:16:59 -0700 X-Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx.groups.io with SMTP id smtpd.web11.287171.1697649417823457169 for ; Wed, 18 Oct 2023 10:16:58 -0700 X-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 1BD425C027C; Wed, 18 Oct 2023 13:16:57 -0400 (EDT) X-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 18 Oct 2023 13:16:57 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrjeeggddutdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpefhkedvkedvhfdtvdetheeuueelteejhfeiheejuefhtddutddvgedutdek veelhfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Oct 2023 13:16:55 -0400 (EDT) Message-ID: <1aa468e7-409b-4d3b-be69-8504e61f9c30@bsdio.com> Date: Wed, 18 Oct 2023 11:16:46 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: trim warning to error To: Yuwei Chen , devel@edk2.groups.io Cc: Liming Gao , Bob Feng References: <20230922064708.1843-1-yuwei.chen@intel.com> From: "Rebecca Cran" In-Reply-To: <20230922064708.1843-1-yuwei.chen@intel.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: MyVVQ388qElk36y9kNypnJgSx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=uBjcVQCg; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Rebecca Cran On 9/22/23 00:47, Yuwei Chen wrote: > As the error is changed to warning, Trim.py will skip the build > error when the source code have exactly issue. > This patch change warning to error to opens the checking. > > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Signed-off-by: Yuwei Chen > --- > BaseTools/Source/Python/Trim/Trim.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/BaseTools/Source/Python/Trim/Trim.py b/BaseTools/Source/Pyth= on/Trim/Trim.py > index c479f7d2b2e7..416935df5e90 100644 > --- a/BaseTools/Source/Python/Trim/Trim.py > +++ b/BaseTools/Source/Python/Trim/Trim.py > @@ -281,10 +281,10 @@ def DoInclude(Source, Indent=3D'', IncludePathList= =3D[], LocalSearchPath=3DNone, Inclu > F =3D File.readlines() > break > else: > - EdkLogger.warn("Trim", "Failed to find include file %s" % So= urce) > + EdkLogger.error("Trim", "Failed to find include file %s" % S= ource) > return [] > except: > - EdkLogger.warn("Trim", FILE_OPEN_FAILURE, ExtraData=3DSource) > + EdkLogger.error("Trim", FILE_OPEN_FAILURE, ExtraData=3DSource) > return [] > =20 > =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109767): https://edk2.groups.io/g/devel/message/109767 Mute This Topic: https://groups.io/mt/101516516/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-