From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id CB17E94141B for ; Wed, 6 Dec 2023 09:42:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Oq5YiAhuBMVmOtYTjElC0H6voGyrNBV7XNZiBNGbtIs=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701855771; v=1; b=eJuy1VmCl/dFN85jJvxLoRdrg3uP+Be9n+p20Rq48xRjzL+OfnpSX/UACwSQzHb48wYNsMXz Od8V5315ET8Qt19nOKibOCdjyVesZA55IgWLCIoHAcFyV++SCoWax4dnh7Lkx3oSJ59Wt7He/wB c6uW3CkPuC//yVhFV4EsmKDw= X-Received: by 127.0.0.2 with SMTP id oQ8kYY7687511x8G6ev2elx7; Wed, 06 Dec 2023 01:42:51 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.28099.1701855770549447286 for ; Wed, 06 Dec 2023 01:42:50 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E25A139F; Wed, 6 Dec 2023 01:43:36 -0800 (PST) X-Received: from [10.34.100.101] (e126645.nice.arm.com [10.34.100.101]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 275A73F762; Wed, 6 Dec 2023 01:42:49 -0800 (PST) Message-ID: <1abb34b2-0726-4068-a82d-9626d2aa0c8d@arm.com> Date: Wed, 6 Dec 2023 10:42:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions From: "PierreGondois" To: "Ni, Ray" , "devel@edk2.groups.io" Cc: "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , Sami Mujawar , Leif Lindholm References: <20231130110953.16550-1-pierre.gondois@arm.com> <20231130110953.16550-2-pierre.gondois@arm.com> <25653a17-23ba-4974-bb49-804a238cc90e@arm.com> In-Reply-To: <25653a17-23ba-4974-bb49-804a238cc90e@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: XbJonpHg47zpj1aHRv7uugNDx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=eJuy1VmC; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Ray and the MdePkg maintainers, Does this patch looks fine ? When/if this patch is accepted, I will send the other patches relying on this present patch, cf. https://edk2.groups.io/g/devel/message/111900 Regards, Pierre On 12/1/23 13:26, Pierre Gondois wrote: > Hi Ray, > I followed the way revisions are defined for ACPI tables revisions, > like for the MADT: > EFI_ACPI_x_x_MULTIPLE_APIC_DESCRIPTION_TABLE_REVISION definition >=20 > For each ACPI spec. revision, there is a matching MADT revision number. > Sometimes the table has changed and the revision is upgraded, sometimes > not and the revision stays the same. > This also means having a macro definition for each ACPI spec. header > file. I think it should be ok do to the same thing for _PSD/_CPC > revisions, >=20 > Regards, > Pierre >=20 > On 12/1/23 11:22, Ni, Ray wrote: >>> --- a/MdePkg/Include/IndustryStandard/Acpi50.h >>> +++ b/MdePkg/Include/IndustryStandard/Acpi50.h >> >>> +#define EFI_ACPI_5_0_AML_PSD_REVISION 0 >>> +#define EFI_ACPI_5_0_AML_CPC_REVISION 1 >> >> >> Do you think it's better to define EFI_ACPI_AML_PSD_REVISION and >> EFI_ACPI_AML_CPC_REVISION in Acpi50.h? >> >> So that Acpi51.h doesn't have to redefine a different macro to >> the same value? >> >>> >>> diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h >>> b/MdePkg/Include/IndustryStandard/Acpi51.h >>> index 01ef544c3a29..19dd7b4f864c 100644 >>> --- a/MdePkg/Include/IndustryStandard/Acpi51.h >>> +++ b/MdePkg/Include/IndustryStandard/Acpi51.h >> >>> +#define EFI_ACPI_5_1_AML_PSD_REVISION 0 >>> +#define EFI_ACPI_5_1_AML_CPC_REVISION 1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112105): https://edk2.groups.io/g/devel/message/112105 Mute This Topic: https://groups.io/mt/102891569/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-