From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.12503.1594220123986520385
 for <devel@edk2.groups.io>;
 Wed, 08 Jul 2020 07:55:24 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 596371FB;
	Wed,  8 Jul 2020 07:55:23 -0700 (PDT)
Received: from [192.168.1.80] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A77203F237;
	Wed,  8 Jul 2020 07:55:21 -0700 (PDT)
Subject: Re: [edk2-platform][PATCH v3 4/6] Platform/RaspberryPi: Switch RPi3 USB NIC driver to Ax88772c
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>, devel@edk2.groups.io
Cc: Pete Batard <pete@akeo.ie>, Andrei Warkentin
 <andrey.warkentin@gmail.com>, Leif Lindholm <leif@nuviainc.com>
References: <20200608133832.14100-1-Samer.El-Haj-Mahmoud@arm.com>
 <20200608133832.14100-5-Samer.El-Haj-Mahmoud@arm.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <1ae573e0-5459-3222-a058-b125df825357@arm.com>
Date: Wed, 8 Jul 2020 17:55:11 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200608133832.14100-5-Samer.El-Haj-Mahmoud@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 6/8/20 4:38 PM, Samer El-Haj-Mahmoud wrote:
> Switch the ASIX USB NIC driver used in the RPi3 to the new Ax88772c.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Pete Batard <pete@akeo.ie>
> Cc: Andrei Warkentin <andrey.warkentin@gmail.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> 
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

> ---
>   Platform/RaspberryPi/RPi3/RPi3.dsc | 2 +-
>   Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
> index 059d16a912ab..b6c568f400ef 100644
> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
> @@ -656,7 +656,7 @@ [Components.common]
>     MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf
>     MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
>     MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
> -  Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> +  Drivers/ASIX/Bus/Usb/UsbNetworking/Ax88772c/Ax88772c.inf
>   
>     #
>     # SD/MMC support
> diff --git a/Platform/RaspberryPi/RPi3/RPi3.fdf b/Platform/RaspberryPi/RPi3/RPi3.fdf
> index e854cd214153..3c569f57740b 100644
> --- a/Platform/RaspberryPi/RPi3/RPi3.fdf
> +++ b/Platform/RaspberryPi/RPi3/RPi3.fdf
> @@ -289,7 +289,7 @@ [FV.FvMain]
>     INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf
>     INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
>     INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
> -  INF Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> +  INF Drivers/ASIX/Bus/Usb/UsbNetworking/Ax88772c/Ax88772c.inf
>   
>     #
>     # SD/MMC support
>