From: <Jim.Dailey@dell.com>
To: <ruiyu.ni@Intel.com>
Cc: <jaben.carsey@intel.com>, <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ShellPkg: Create a homefilesystem environment variable
Date: Mon, 8 Oct 2018 13:58:32 +0000 [thread overview]
Message-ID: <1ae74ad2df334651b167667b07239088@ausx13mps335.AMER.DELL.COM> (raw)
In-Reply-To: <3f099bb0-8686-1daf-d283-c2910ada825e@Intel.com>
>-----Original Message-----
>From: Ni, Ruiyu [mailto:ruiyu.ni@Intel.com]
>Sent: Monday, October 8, 2018 1:42 AM
>To: Dailey, Jim; edk2-devel@lists.01.org
>Cc: jaben.carsey@intel.com
>Subject: Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable
>
>
>On 10/4/2018 12:02 AM, Jim.Dailey@dell.com wrote:
>> Create a homefilesystem environment variable whose value is the file
>> system on which the executing shell is located. For example: "FS14:".
>>
>Jim,
>Creating spec-undefined "homefilesystem" ENV variable is not a good idea
>in my opinion.
>Can you submit a Shell Spec change and change the implementation once
>the spec change is approved?
Ray,
I think you and Jaben should get together on this:
>>-----Original Message-----
>>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
>>Sent: Thursday, October 4, 2018 12:07 PM
>>To: Carsey, Jaben; Dailey, Jim; edk2-devel@lists.01.org
>>Subject: Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable
>>
>>Is it OK with the UEFI shell spec to define a shell variable called
>>"homefilesystem"? I seem to remember that edk2-specific options for
>>standard UEFI shell commands generally start with an underscore, to
>>avoid clashing with the standard namespace. Does that apply to shell
>>variables perhaps? (This is mostly for my own education.)
>>
>>> -----Original Message-----
>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Carsey, Jaben
>>> Sent: Thursday, October 4, 2018 3:54 PM
>>> To: Andrew Fish; Laszlo Ersek
>>> Cc: edk2-devel@lists.01.org
>>> Subject: Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable
>>>
>>> Laszlo,
>>>
>>> The leading "_" was required for out of spec, but built in, commands.
>>> The spec has no restrictions on environment variables except some have
>>> special meaning and may be read only.
>>>
Besides, if I were you and didn't have a lot of free time, I wouldn't unleash
me on shell spec changes! :-)
>--
>Thanks,
>Ray
Regards,
Jim
prev parent reply other threads:[~2018-10-08 13:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 16:02 [PATCH] ShellPkg: Create a homefilesystem environment variable Jim.Dailey
2018-10-03 18:15 ` Carsey, Jaben
2018-10-03 18:17 ` Carsey, Jaben
2018-10-04 17:07 ` Laszlo Ersek
2018-10-04 19:05 ` Jim.Dailey
2018-10-04 19:20 ` Laszlo Ersek
2018-10-04 19:19 ` Andrew Fish
2018-10-04 20:54 ` Carsey, Jaben
2018-10-05 11:32 ` Laszlo Ersek
2018-10-05 12:19 ` Tim Lewis
2018-10-09 4:33 ` Ni, Ruiyu
2018-10-05 15:00 ` Carsey, Jaben
2018-10-05 17:47 ` Laszlo Ersek
2018-10-08 6:42 ` Ni, Ruiyu
2018-10-08 13:58 ` Jim.Dailey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ae74ad2df334651b167667b07239088@ausx13mps335.AMER.DELL.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox