Re: [PATCH v1 2/6] DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Kun,

Thank you for this fix.

This patch looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 19/07/2022 01:22 am, Kun Qin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
>
> The content of token should be derived from the data section of the
> `CmObject` instead of the object itself.
>
> This change fixed the issue by dereferencing the token value from the
> data buffer of input CmObject.
>
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
>
> Co-authored-by: Joe Lopez <joelopez@microsoft.com>
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
>   DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c
> index 80d0aa17bc1a..84e4bb7e3bc8 100644
> --- a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c
> +++ b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c
> @@ -60,7 +60,7 @@ TokenFixerItsGroup (
>     )
>
>   {
>
>     ASSERT (CmObject != NULL);
>
> -  ((CM_ARM_ITS_GROUP_NODE *)CmObject)->Token = Token;
>
> +  ((CM_ARM_ITS_GROUP_NODE *)CmObject->Data)->Token = Token;
>
>     return EFI_SUCCESS;
>
>   }
>
>   
>