From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.59]) by mx.groups.io with SMTP id smtpd.web12.52069.1658311613861575513 for ; Wed, 20 Jul 2022 03:06:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=UwkR9IJf; spf=pass (domain: arm.com, ip: 40.107.20.59, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hvU5hk0nA2/OPw3tD1lFb52qv0WWd7AhEVaIKZ+gqxXb9cpMa1FWMgeLI5iP1CTKLxnajjdjizgV9Iof1xeHz4r8y2pUORoi7OJq1pvbxOhjXA+eiK+X35ITDR4wJrrYxq/zKuVDDsQ50ocxCQ0MkxPB5KZHRvAIkA77cWlYkEi/kGDPHNwou3YGHqSLn2e6OCcc0048o12Qp1JHfvDMKEMSmz13eZ3NUj1ZNBOgIn0L/3fDIuYFVxD4XRlBomNlTG1xgrOB6Px5dBfbAlwQWxScT4NuRY5yq1Yu/ICjZjbJ7ZYtmj5vNtvQE2eR9bNeOnjWBM3IBarhSpByptpSTw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MDCnJ5tbevDUXe9SgvI72PgpyrNM34VBYnb59u573Ag=; b=VqckurxS91V/EcfJSAT3SxC5tetycDOjQeWR8q3XbiFcRFNU2d0wft86a6r9aeYJ8sumvKsjDPQXzA9QnoHOJC44/9GzB2gI84ALX/6wJrs3J1bElBmx5yjzS1gIB/yYxKdX5+NKnJkfu8voUrZoUfUCHTKUxlkN7tDVGRY7de9I85gZ+9931qhBcsSxDTUXfXeilg3IJJamNJZaKt/DtDRIeoVbQyAYYtz2yqZu/2c146fEfJfN2WJLA5/qzzxqCUb5QCyd23zJdijk4LMSz2SslPh4AQWEiX8nGvyhN2I0BzD53RFnCaDiSQGEeCNpZIgwMUiqpk63B1PhL3qfEg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MDCnJ5tbevDUXe9SgvI72PgpyrNM34VBYnb59u573Ag=; b=UwkR9IJf+0yU9Lb9wVnqNwOfh4Y26e1GGFrsKDA+nV9sUJTM+ZDsgbkZ4rZIzBxCWFKn4Yb0iNqO25Q9isL6v18jM6zeMRiAzeJl4fIqsTeoREk3gmdVZL37o6Kra0vWcGTobWWuyhqTJF9xsAM4Wn6oNCJA/gzOrCJGc0XDtfM= Received: from FR0P281CA0145.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::18) by AS8PR08MB7720.eurprd08.prod.outlook.com (2603:10a6:20b:508::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Wed, 20 Jul 2022 10:06:51 +0000 Received: from VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:96:cafe::6a) by FR0P281CA0145.outlook.office365.com (2603:10a6:d10:96::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.9 via Frontend Transport; Wed, 20 Jul 2022 10:06:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT053.mail.protection.outlook.com (10.152.19.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Wed, 20 Jul 2022 10:06:50 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Wed, 20 Jul 2022 10:06:50 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c8a954555228f54a X-CR-MTA-TID: 64aa7808 Received: from cf5853f9f0c1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 668BEF35-9CEC-40AC-AD37-E66630603331.1; Wed, 20 Jul 2022 10:06:44 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cf5853f9f0c1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 20 Jul 2022 10:06:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HaUM91PXHPcMP7MYYzZ3RbfjLG5/vZCglrNUrxlwKp58GlR0kaear7JL0dt/JsVMjTPlWyNG6JeSbcaahXUZrdJ6Fs1UiT7A1GFUGLUTu/oyu2yJ4ntUYKHUjr4Atguu/R849MaLd+7E6G1DbOpMyHiZM3YV0bClF9JMiJ9A3d5c1rPPyRRWdfuPkzBCLY2l1DEyNbiJYdkjCi6VkEz2269qOM6SkFT4NfL23pHIUyzoIWRtWco4/Oc2FpFUy4DKQ7rAZJe22+ph/H2v2RSPrwCpx3vv2yoN+HNoZYF9hbwu9/C2079tdz11T10vOAfsTZsF+G0QwIYYz2/xlCalJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MDCnJ5tbevDUXe9SgvI72PgpyrNM34VBYnb59u573Ag=; b=OBGtzfsp0HzLncYBAcV67sUDcKuvn4uOne34HOrsEFiMZ+SgAxhE8BNQmoyRCsn5H8uSlaXFRUCulfVjDm2eg6GONX3I2na1vMaCUmQIGmSwYO4X1yIfyc4NvItGc5wLdb8UCocelkN6swPEQ/c3UePCt8X/kxNTLiFbZPphl7mtLiU0bRXOC+DJ6VkkTDFuPwjNLxSEI/4/uIYRFNpip09cxaGt9Lg+2hqRIG+kuG6f0Wt08Vfc6eLAJD17RGwMXMiBqF8fZlyl/FUx5e3319bwz8CLO4LxB1FQpO3Ta7WeFrW5DMI5xN6VUmMhyVbjSilpq5tYPy02mIJATNnbkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MDCnJ5tbevDUXe9SgvI72PgpyrNM34VBYnb59u573Ag=; b=UwkR9IJf+0yU9Lb9wVnqNwOfh4Y26e1GGFrsKDA+nV9sUJTM+ZDsgbkZ4rZIzBxCWFKn4Yb0iNqO25Q9isL6v18jM6zeMRiAzeJl4fIqsTeoREk3gmdVZL37o6Kra0vWcGTobWWuyhqTJF9xsAM4Wn6oNCJA/gzOrCJGc0XDtfM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM8PR08MB6420.eurprd08.prod.outlook.com (2603:10a6:20b:314::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 20 Jul 2022 10:06:38 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9%4]) with mapi id 15.20.5458.018; Wed, 20 Jul 2022 10:06:38 +0000 Message-ID: <1aee6984-d8ff-e9bb-987c-792af8747eb1@arm.com> Date: Wed, 20 Jul 2022 11:06:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 2/6] DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing To: Kun Qin , devel@edk2.groups.io Cc: Alexei Fedorov , Joe Lopez , nd@arm.com References: <20220719002254.1891-1-kuqin12@gmail.com> <20220719002254.1891-3-kuqin12@gmail.com> From: "Sami Mujawar" In-Reply-To: <20220719002254.1891-3-kuqin12@gmail.com> X-ClientProxiedBy: LO2P265CA0020.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::32) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: bb462c59-f0e9-4ac8-f443-08da6a37909a X-MS-TrafficTypeDiagnostic: AM8PR08MB6420:EE_|VE1EUR03FT053:EE_|AS8PR08MB7720:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xygZfkwv//Qxdf7CyljQmDJCL+NSYDhgU/TquxmDqDsk3UwBDCjJYD++Ok3BK68/A/Sj0jYsg/U+ks9bHycnSy4JQkChCJHDmg7gwd04nUoLMfiQ9SIV4J+Fx6iNYYpKr1Mvm1KNEWEk5EPXLsQL6jTpVnHh3UiiEvF28fCcWvIPG5YhviQ4G/UVcdpTW8hFgYcs8+WLMW2i7EeSGFDsQBkdUeyDbrfrBPdcX6ovkP5Izx31a4C9mGsxN1mMPTc3SebzLcFsW4rPjmU2oTJi/2QhaqG8wgFFhztMyL5iY9YKXih3QL9Xg/GOB0DHA9FlS5vGBlLL+IFfo2R+WuhaoNI+gYeVV2IBr+GxZPOFCIffoCea5WntNnAmWpBDGy/dUbZc20Ntqt8LnRl0qpqUZw/ftaQpVR8kW0s2ddQHopNOqtYTt9iqPidDtj23Gc9PWYS2fQ3iEimwWNYxslfjnpwH/SMAx9fC7eQDRJVYAmS9lChnICiwqnEXbCm2lf74MqqFdjBPL/70v5qMGmvnXkvZsG6MbLVdAahBKMc/8sQalCSZlJFqkCuGyDO08lh4o7bI9gc08vNZwQZRhXtUYxNdkLh7mSDa1aKS2lZPg8VPUDPQ4Pna3J9J9Fo9NjJ2acdLpKLSUA4unYs/r5cdICRnjViOJCUN8IK72uOpS5LTaegVdTUTOvMH+kUHtRgV8ho4anKALFiAkMM1YZH+tTOFeQG3uTY/MB9/mWPRX+Y4yXnXTpRiA1W4lDea3yi89fZ6vjwCzASi4vfrNVCH/q3HL1J4QMFU/qUcvv8aDM2vjrOFoSNMJqrAF7NUa38x21xtLXPvfe5yRknw3/Xxo/DPIrnoRkS6X562Q3Su9Pc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(366004)(376002)(136003)(396003)(39860400002)(45080400002)(66946007)(83380400001)(186003)(38100700002)(966005)(8676002)(66556008)(36756003)(316002)(31686004)(66476007)(53546011)(6506007)(6486002)(2906002)(86362001)(41300700001)(2616005)(26005)(6666004)(478600001)(54906003)(31696002)(4326008)(5660300002)(44832011)(6512007)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6420 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 25877d60-a830-4244-1412-08da6a3788a6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zXyp2OwKcUAzA5l7vPxMnPoZu+JzR2N4rW5c4aaRPQBtJtvpflcSJRx02Ugczpw827/J/J2ApAJXu880ZPykUuDQRwXBfTBAIRoEZNnXTatQ5A1pYeS7RM1h36VQGAPbxUitqDW8StSjU8fzY7lWXkY6TOS8edORln5gnO7BiZCu4pXQiS6z/I9Nj74+GEMD4eDE3ASiJ14rnhmwGtyFav819uV/7HA0KBUSiZ040T9EzXNwxUJsM8OfU6YKbgZEZ8glPzA69cPlxveuETP1np/hvuoCHKmVyJWvf0CYxHh5f4wg8RBrxpL6Xu9jX35qleBd5HqvzINrhIT1/pknz9Y5APZm6D7/bEhhQ75BrcDJjp8JmgX0/lDcTrue7tMyuXaT8JCifbwVPT/TEboOZG7CqxClXZNauYjMyW67kyGz+0YGVZtUOEONpYaBWM4Vo63Xi8TYeserH2LZqgK5QP2e32mu/wuwbOel+thqG01clb+VwaZjaFgaopHzcyW4GHZUj8gM9EafjOIvQ1ck/rpUqtFJ4DcKJzhrdCta9J9YGXeJ/bG54ihDQmvpOf2dawzm1GKpTaOO3XW3RZWUbnlmiM7MAPfrJXoy/9I7eH2IpAY424UNuCtCeOrQn7pa06SesvVUctMBsKa04xYvWlXPhwoIP/KClTOEyrC+JvQQQdNG1xBHQABkh76ReSTWg7Epkx13WFZ8nT3WM6u1s15FKHK72qcrNVnTrRzKT6gnwtQLkR35KGNIGEU1MeMWU11skZiPe7nmsX3cUJYl0CH93b/A6yNZe+rNwJV4r9b1tlZyVqCFIbegA54N05ITk60b3ZUfGarc4PafSDDvLGcnoew9tjng9s7ExI1RvwCTnKtwk3w7x7drdCECInOD X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(136003)(39860400002)(376002)(46966006)(36840700001)(40470700004)(6506007)(31686004)(53546011)(83380400001)(36860700001)(44832011)(336012)(41300700001)(6666004)(45080400002)(966005)(26005)(40480700001)(6512007)(5660300002)(186003)(478600001)(47076005)(2616005)(6486002)(40460700003)(82310400005)(316002)(8936002)(8676002)(54906003)(70586007)(4326008)(70206006)(81166007)(82740400003)(2906002)(31696002)(356005)(36756003)(86362001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 10:06:50.7093 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bb462c59-f0e9-4ac8-f443-08da6a37909a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7720 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Kun, Thank you for this fix. This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 19/07/2022 01:22 am, Kun Qin wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996 > > The content of token should be derived from the data section of the > `CmObject` instead of the object itself. > > This change fixed the issue by dereferencing the token value from the > data buffer of input CmObject. > > Cc: Sami Mujawar > Cc: Alexei Fedorov > > Co-authored-by: Joe Lopez > Signed-off-by: Kun Qin > --- > DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c > index 80d0aa17bc1a..84e4bb7e3bc8 100644 > --- a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c > +++ b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c > @@ -60,7 +60,7 @@ TokenFixerItsGroup ( > ) > > { > > ASSERT (CmObject != NULL); > > - ((CM_ARM_ITS_GROUP_NODE *)CmObject)->Token = Token; > > + ((CM_ARM_ITS_GROUP_NODE *)CmObject->Data)->Token = Token; > > return EFI_SUCCESS; > > } > > >