From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.1232.1662685414192012438 for ; Thu, 08 Sep 2022 18:03:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=Fg/jtF+p; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 86C25204A5B0; Thu, 8 Sep 2022 18:03:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 86C25204A5B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1662685413; bh=MFrrNVeFLjpKVUWMnqwFLP9SXizkLfBSVsTpX6VIkVw=; h=Date:Subject:From:To:Cc:Reply-To:References:In-Reply-To:From; b=Fg/jtF+pnoVjigzUSWUNVWYc+tT5aQZIJHp/u0i4a87u+CrPbUB5W4R0nCGF2PmaQ ds8KJ1itLlEz1HSJRr4noF6WHRc8d9XDV8sMQz29xQjIKBWFn4do8PNKDVIVJaHp6J UnNAWvkvrUMsSDPNsB/gbUwvtrvIgNRGOrKNXjPk= Message-ID: <1aeefaec-8e9a-5490-e072-29dd4fd9c2f7@linux.microsoft.com> Date: Thu, 8 Sep 2022 21:03:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [edk2-devel] [PATCH v3 0/8] Fix imbalanced debug macros From: "Michael Kubacki" To: devel@edk2.groups.io, Michael D Kinney Cc: Abner Chang , Alexei Fedorov , Ard Biesheuvel , Dandan Bi , David Woodhouse , Gerd Hoffmann , Guomin Jiang , Hao A Wu , Jian J Wang , Jiaxin Wu , Jiewen Yao , Jordan Justen , Leif Lindholm , Liming Gao , Maciej Rabeda , Nickle Wang , Qi Zhang , Rahul Kumar , Ray Ni , Sami Mujawar , Siyuan Fu Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com References: <17112B4EDBB29064.15579@groups.io> In-Reply-To: <17112B4EDBB29064.15579@groups.io> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit The patch series has now received a R-b tag for each package. No content changes were requested in v3. I rebased the branch to edk2/master, added all v3 review tags, updated Nickle's email address, and pushed the changes to update the PR - https://github.com/tianocore/edk2/pull/3171. The PR should be ready for the push tag. Mike Kinney, do you have a recommendation for who should do that for this series? Thanks, Michael On 9/2/2022 6:21 PM, Michael Kubacki wrote: > From: Michael Kubacki > > After noticing a few occurrences of DEBUG macros with a mismatched > number of arguments, I wrote a script to automatically detect this. > > This patch series is the result of matches found by the script. > > In some cases it is not obvious what was originally intended so I > have attempted to capture what I believe was the original author's > intention. > > V3 Changes: > Updated R-b tags. > 1. ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c: > - Repeated BufferSizeInBytes argument per Leif's feedback > 2. MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c: > - Fixed an additional error on Line 267 > > V2 Changes: > These additional errors were found while finishing testing of > the script. > > 1. Add DynamicTablesPkg/AcpiPpttLibArm patch for the change in > - DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c > 2. Update MdeModulePkg patch to include the change in > - MdeModulePkg/Universal/CapsulePei/UefiCapsule.c > 3. Add following to the RedfishPkg fix patch: > - RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > - RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c > 4. Add NetworkPkg patch for the change in > - NetworkPkg/TcpDxe/SockInterface.c > 5. Add OvmfPkg patch for the change in > - OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c > > Cc: Abner Chang > Cc: Alexei Fedorov > Cc: Ard Biesheuvel > Cc: Dandan Bi > Cc: David Woodhouse > Cc: Gerd Hoffmann > Cc: Guomin Jiang > Cc: Hao A Wu > Cc: Jian J Wang > Cc: Jiaxin Wu > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Liming Gao > Cc: Maciej Rabeda > Cc: Nickle Wang > Cc: Qi Zhang > Cc: Rahul Kumar > Cc: Ray Ni > Cc: Sami Mujawar > Cc: Siyuan Fu > Signed-off-by: Michael Kubacki > > Michael Kubacki (8): > ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier > FatPkg/FatPei: Remove extraneous debug message argument > MdeModulePkg: Fix imbalanced debug macros > RedfishPkg/RedfishRestExDxe: Remove extra debug macro argument > SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing debug print > specifier > DynamicTablesPkg/AcpiPpttLibArm: Fix debug macro arguments > NetworkPkg/TcpDxe: Fix debug macro arguments > OvmfPkg/LegacyBootManagerLib: Fix debug macro arguments > > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c | 4 ++-- > DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 3 +-- > FatPkg/FatPei/Gpt.c | 2 +- > MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c | 2 +- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 8 ++++---- > MdeModulePkg/Core/Dxe/Image/Image.c | 2 +- > MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.c | 2 +- > MdeModulePkg/Universal/CapsulePei/UefiCapsule.c | 2 +- > NetworkPkg/TcpDxe/SockInterface.c | 12 ++---------- > OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 6 +++--- > RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 6 +++--- > RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 2 +- > RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c | 2 +- > SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLibCommon.c | 2 +- > 15 files changed, 24 insertions(+), 33 deletions(-) >