From: "Laszlo Ersek" <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, devel@edk2.groups.io
Cc: leif.lindholm@linaro.org, philmd@redhat.com
Subject: Re: [PATCH v2] ArmVirtPkg: increase FD/FV size for NOOPT builds
Date: Thu, 12 Sep 2019 16:47:59 +0200 [thread overview]
Message-ID: <1aefae6b-7866-b153-883f-60e8212f5ae1@redhat.com> (raw)
In-Reply-To: <4be96d3b-10bf-58d4-150f-03047d9a9e70@redhat.com>
On 09/12/19 16:46, Laszlo Ersek wrote:
> On 09/11/19 18:23, Ard Biesheuvel wrote:
>> After upgrading the CI system we use for building the ArmVirtPkg
>> targets, we started seeing failures due to the NOOPT build running
>> out of space when using the CLANG38 toolchain definition combined
>> with clang 7.
>>
>> We really don't want to increase the FD/FV sizes in general to
>> accommodate this, so parameterize the relevant quantities and
>> increase them by 50% for NOOPT builds.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>> v2: implement suggestions by Laszlo on 1) how to parameterize this further,
>> and b) to avoid adding another .inc file
>> update kernel header field, as pointed out by Philippe
> (1) s/for NOOPT builds/with -D FD_SIZE_3MB/ in the commit message
(there are two instances: subject line, and commit message body)
next prev parent reply other threads:[~2019-09-12 14:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 16:23 [PATCH v2] ArmVirtPkg: increase FD/FV size for NOOPT builds Ard Biesheuvel
2019-09-12 14:46 ` Laszlo Ersek
2019-09-12 14:47 ` Laszlo Ersek [this message]
2019-09-12 14:53 ` Ard Biesheuvel
2019-09-12 15:20 ` Philippe Mathieu-Daudé
2019-09-12 16:50 ` Ard Biesheuvel
2019-09-12 17:05 ` Philippe Mathieu-Daudé
2019-09-12 17:13 ` Ard Biesheuvel
2019-09-12 17:14 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aefae6b-7866-b153-883f-60e8212f5ae1@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox