From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 12 Sep 2019 07:48:04 -0700 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 58A2FC04B2DD; Thu, 12 Sep 2019 14:48:04 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-26.rdu2.redhat.com [10.10.121.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5780C1001944; Thu, 12 Sep 2019 14:48:00 +0000 (UTC) Subject: Re: [PATCH v2] ArmVirtPkg: increase FD/FV size for NOOPT builds From: "Laszlo Ersek" To: Ard Biesheuvel , devel@edk2.groups.io Cc: leif.lindholm@linaro.org, philmd@redhat.com References: <20190911162354.22107-1-ard.biesheuvel@linaro.org> <4be96d3b-10bf-58d4-150f-03047d9a9e70@redhat.com> Message-ID: <1aefae6b-7866-b153-883f-60e8212f5ae1@redhat.com> Date: Thu, 12 Sep 2019 16:47:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4be96d3b-10bf-58d4-150f-03047d9a9e70@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 12 Sep 2019 14:48:04 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/12/19 16:46, Laszlo Ersek wrote: > On 09/11/19 18:23, Ard Biesheuvel wrote: >> After upgrading the CI system we use for building the ArmVirtPkg >> targets, we started seeing failures due to the NOOPT build running >> out of space when using the CLANG38 toolchain definition combined >> with clang 7. >> >> We really don't want to increase the FD/FV sizes in general to >> accommodate this, so parameterize the relevant quantities and >> increase them by 50% for NOOPT builds. >> >> Signed-off-by: Ard Biesheuvel >> --- >> v2: implement suggestions by Laszlo on 1) how to parameterize this further, >> and b) to avoid adding another .inc file >> update kernel header field, as pointed out by Philippe > (1) s/for NOOPT builds/with -D FD_SIZE_3MB/ in the commit message (there are two instances: subject line, and commit message body)