From: Laszlo Ersek <lersek@redhat.com>
To: Jian J Wang <jian.j.wang@intel.com>, edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Ruiyu Ni <ruiyu.ni@intel.com>, Jiewen Yao <jiewen.yao@intel.com>
Subject: Re: [PATCH v2 0/2] clarify NXE enabling logic
Date: Thu, 20 Sep 2018 13:31:13 +0200 [thread overview]
Message-ID: <1b04877e-adc5-1a38-83de-5176438fcaec@redhat.com> (raw)
In-Reply-To: <20180920060247.7764-1-jian.j.wang@intel.com>
On 09/20/18 08:02, Jian J Wang wrote:
>> v2 changes:
>> Incorporates review comments from Laszlo and Star.
>
> BZ#1116: https://bugzilla.tianocore.org/show_bug.cgi?id=1116
>
> Test:
> a. try all related PCDs combinations and check the page table attributes
> b. boot to shell on real intel platform with valid PCD setting combinations
> (IA32/X64)
> c. boot to fedora26, ubuntu18.04, windows 7 and windows 10 on OVMF emulated
> platform (X64)
>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
>
> Jian J Wang (2):
> MdeModulePkg/MdeModulePkg.dec/.uni: clarify PCDs usage
> MdeModulePkg/DxeIpl: support more NX related PCDs
>
> MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 2 ++
> MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c | 4 ++--
> MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 30 +++++++++++++++++++++++-
> MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.h | 24 +++++++++++++++++++
> MdeModulePkg/MdeModulePkg.dec | 20 ++++++++++++----
> MdeModulePkg/MdeModulePkg.uni | 13 ++++++----
> 6 files changed, 81 insertions(+), 12 deletions(-)
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
prev parent reply other threads:[~2018-09-20 11:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 6:02 [PATCH v2 0/2] clarify NXE enabling logic Jian J Wang
2018-09-20 6:02 ` [PATCH v2 1/2] MdeModulePkg/MdeModulePkg.dec/.uni: clarify PCDs usage Jian J Wang
2018-09-21 5:49 ` Zeng, Star
2018-09-20 6:02 ` [PATCH v2 2/2] MdeModulePkg/DxeIpl: support more NX related PCDs Jian J Wang
2018-09-21 6:00 ` Zeng, Star
2018-09-21 8:42 ` Zeng, Star
2018-09-21 10:14 ` Laszlo Ersek
2018-09-25 3:23 ` Wang, Jian J
2018-09-20 11:31 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b04877e-adc5-1a38-83de-5176438fcaec@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox