public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "INDIA\\sivaramann" <emergingsiva@gmail.com>
To: devel@edk2.groups.io
Cc: Sivaraman <sivaramann@ami.com>
Subject: [PATCH v2] NetworkPkg:UEFIPXEBC
Date: Thu, 24 Jun 2021 13:03:29 +0530	[thread overview]
Message-ID: <1b052eda1c038b2d9e3502c679e0014db143a39b.1624516592.git.sivaramann@ami.com> (raw)

Issue on the PxeBcDhcp4CallBack() functions of UEFIPXEBC Driver.
In this function any non allowed events are recieved as input it
will exit in beginning itself. But the switch case handling the
default and Dhcp4SendRequest which is not reachable.

Signed-off-by: Sivaraman <sivaramann@ami.com>
---
 NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c
index fb63cf61a9..e85176f9bb 100644
--- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c
+++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c
@@ -1256,19 +1256,10 @@ PxeBcDhcp4CallBack (
 
     //
     // Cache the DHCPv4 discover packet to mode data directly.
-    // It need to check SendGuid as well as Dhcp4SendRequest.
+    // It need to check SendGuid.
     //
     CopyMem (&Mode->DhcpDiscover.Dhcpv4, &Packet->Dhcp4, Packet->Length);
 
-  case Dhcp4SendRequest:
-    if (Packet->Length > PXEBC_DHCP4_PACKET_MAX_SIZE) {
-      //
-      // If the to be sent packet exceeds the maximum length, abort the DHCP process.
-      //
-      Status = EFI_ABORTED;
-      break;
-    }
-
     if (Mode->SendGUID) {
       //
       // Send the system Guid instead of the MAC address as the hardware address if required.
@@ -1332,6 +1323,7 @@ PxeBcDhcp4CallBack (
     break;
 
   default:
+    ASSERT (FALSE);
     break;
   }
 
-- 
2.28.0.windows.1


             reply	other threads:[~2021-06-24  7:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24  7:33 INDIA\sivaramann [this message]
2021-06-25 14:35 ` [edk2-devel] [PATCH v2] NetworkPkg:UEFIPXEBC Maciej Rabeda
2021-06-28  4:46   ` [EXTERNAL] " Sivaraman Nainar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b052eda1c038b2d9e3502c679e0014db143a39b.1624516592.git.sivaramann@ami.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox