From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mx.groups.io with SMTP id smtpd.web11.4200.1624520013248077586 for ; Thu, 24 Jun 2021 00:33:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ECE0yiWL; spf=pass (domain: gmail.com, ip: 209.85.215.172, mailfrom: emergingsiva@gmail.com) Received: by mail-pg1-f172.google.com with SMTP id e33so4023312pgm.3 for ; Thu, 24 Jun 2021 00:33:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ufiGo/d4DPKtrsl4N5yFl+04zs2ipNiLmHe6k67E4Rw=; b=ECE0yiWLg5DRTibUAFXw2OLGAxqYeXtShU7K4uifkqh6qy5dzjkvsHp1nlQ6BhLfck NHzPBMZiM7ral8YEAgKIaEoi2BGoXv+6Ad87E493LiAa6MK7nhuvbGU9OEIrLz/dKScn SCSm1BpI7+h1l2MvnaOXjdHmgyhwHdAItVw8uxljBNdADpUiC7zWT67+CziBpzqoSclX pcXXqqmYT6kF8GRgPeA1Z/MVo/UtulqGvL84AGprU5PMHtF1lXH0b6jgoI6+sE4CbyLy ymFQfwLkQZHRpvgAFCtCj1bjD2xm7Aj4hjuPI1g5LE28U1R1VN2Rx0+8ruF+EJUdcnLi T1zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ufiGo/d4DPKtrsl4N5yFl+04zs2ipNiLmHe6k67E4Rw=; b=PxbrMPUE4U1EMrKXaOjuZDJ/Ti2y20qkj/9a6zhBhESSpoblBaGEKzz+Py2ybZ+ep+ aXpnDeC6RD1/QqkX0anF65KT/Pk2GjL3R+PC8zEpVDzdenvqWeTssOJ8qhu0371PF4DJ EYSMuICZSEiP2o16pjJbULtzyjdQ/tNlTTM02rW65RHWUl2fY8GU09pYKUCFBQzUcWA3 o2MvoXzU1HwfAc7/wAwMLmAYnuray83H+R40iI8IB2mH+dQxsabB5Z6W9ZhXwGWp1Vrv 09keDJ4TxMetyQ6aLN7517OHJnjug+NUV51sgrCDFF1Gbz0aD9PfkRoKBzzapI8bAb7i k8mw== X-Gm-Message-State: AOAM530+0gLTG5kVtnSEVpfeMwMt5w9mPfY+QKWFIaaFzt7i+YmeHUI+ +PO/tDDAfAw4yY+OLImzwQ7G6tHvyeOKwA== X-Google-Smtp-Source: ABdhPJxEc/Q5D9uNErjyPHpEm9tJS1zhkB7d1lHR/VXoytutjHRZT919i2qVLXCC99whlOrLjh6ukA== X-Received: by 2002:a63:104d:: with SMTP id 13mr3584938pgq.318.1624520012419; Thu, 24 Jun 2021 00:33:32 -0700 (PDT) Return-Path: Received: from UTILFW-8301.in.megatrends.com ([171.78.178.148]) by smtp.gmail.com with ESMTPSA id cq4sm4319858pjb.1.2021.06.24.00.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 00:33:32 -0700 (PDT) From: "INDIA\\sivaramann" X-Google-Original-From: "INDIA\\sivaramann" To: devel@edk2.groups.io Cc: Sivaraman Subject: [PATCH v2] NetworkPkg:UEFIPXEBC Date: Thu, 24 Jun 2021 13:03:29 +0530 Message-Id: <1b052eda1c038b2d9e3502c679e0014db143a39b.1624516592.git.sivaramann@ami.com> X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Issue on the PxeBcDhcp4CallBack() functions of UEFIPXEBC Driver. In this function any non allowed events are recieved as input it will exit in beginning itself. But the switch case handling the default and Dhcp4SendRequest which is not reachable. Signed-off-by: Sivaraman --- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c b/NetworkPkg/UefiPxeBcDxe= /PxeBcDhcp4.c index fb63cf61a9..e85176f9bb 100644 --- a/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c +++ b/NetworkPkg/UefiPxeBcDxe/PxeBcDhcp4.c @@ -1256,19 +1256,10 @@ PxeBcDhcp4CallBack ( =0D //=0D // Cache the DHCPv4 discover packet to mode data directly.=0D - // It need to check SendGuid as well as Dhcp4SendRequest.=0D + // It need to check SendGuid.=0D //=0D CopyMem (&Mode->DhcpDiscover.Dhcpv4, &Packet->Dhcp4, Packet->Length);= =0D =0D - case Dhcp4SendRequest:=0D - if (Packet->Length > PXEBC_DHCP4_PACKET_MAX_SIZE) {=0D - //=0D - // If the to be sent packet exceeds the maximum length, abort the DH= CP process.=0D - //=0D - Status =3D EFI_ABORTED;=0D - break;=0D - }=0D -=0D if (Mode->SendGUID) {=0D //=0D // Send the system Guid instead of the MAC address as the hardware a= ddress if required.=0D @@ -1332,6 +1323,7 @@ PxeBcDhcp4CallBack ( break;=0D =0D default:=0D + ASSERT (FALSE);=0D break;=0D }=0D =0D --=20 2.28.0.windows.1