Re: [Patch 1/5] Build Spec: Add !error statement support

[Laszlo Ersek <lersek@redhat.com>]

Hello Yonghong,

On 05/31/18 02:56, Yonghong Zhu wrote:
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
>  8_pre-build_autogen_stage/82_auto-generation_process.md | 6 ++++++
>  README.md                                               | 3 ++-
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/8_pre-build_autogen_stage/82_auto-generation_process.md b/8_pre-build_autogen_stage/82_auto-generation_process.md
> index 8f8f29b..abfa55c 100644
> --- a/8_pre-build_autogen_stage/82_auto-generation_process.md
> +++ b/8_pre-build_autogen_stage/82_auto-generation_process.md
> @@ -1058,10 +1058,16 @@ hash value file into the directory specified by binary-destination at the build
>  When --hash and --binary-source are specified, build tool will try to get the binary
>  files from the binary source directory at the build phase. If the cached binary has
>  the same hash value, it will be directly used. Otherwise, build tool will compile the
>  source files and generate the binary files.
>  
> +#### 8.2.4.16 !error Statement
> +
> +The DSC and FDF file can use `!error` statement. The argument of this statement is an
> +error message, it causes build tool to stop at the location where the statement is
> +encountered and error message following the `!error` statement is output as a message.
> +
>  ### 8.2.5 Post processing
>  
>  Once all files are parsed, the build tools will do following work for each EDK
>  II module:
>  
> diff --git a/README.md b/README.md
> index 18e46c9..9ca8733 100644
> --- a/README.md
> +++ b/README.md
> @@ -223,6 +223,7 @@ Copyright (c) 2008-2017, Intel Corporation. All rights reserved.
>  |            | [#775](https://bugzilla.tianocore.org/show_bug.cgi?id=775) Build spec: Add description about auto detect thread number                                                                                                                                                                                                                                              |               |
>  |            | Add Flexible PCD value format into spec                                                                                                                                                                                                                                                                                                                             |               |
>  |            | Update PCD value and SKU, DefaultStore info in build report                                                                                                                                                                                                                                                                                                         |               |
>  |            | Clarify structure PCD field value assignment precedence                                                                                                                                                                                                                                                                                                             |               |
>  |            | Update description for build handles PCDs for SKU support                                                                                                                                                                                                                                                                                                           |               |
> -|            | Add statement about module scoped `<Pcd*>` section override scope                                                                                                                                                                                                                                                                                                            |               |
> +|            | Add statement about module scoped `<Pcd*>` section override scope                                                                                                                                                                                                                                                                                                   |               |
> +|            | Add !error statement section                                                                                                                                                                                                                                                                                                                                        |               |
> 

I think the correct TianoCore BZ is not 775, but 701; compare:

https://bugzilla.tianocore.org/show_bug.cgi?id=775
"Allow build tools to auto-detect MAX_CONCURRENT_THREAD_NUMBER"

https://bugzilla.tianocore.org/show_bug.cgi?id=701
"RFE: please introduce !error directive"

Thanks!
Laszlo