From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C06AD20985994 for ; Thu, 31 May 2018 03:27:19 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E5E21CB9CF; Thu, 31 May 2018 10:27:18 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-203.rdu2.redhat.com [10.10.120.203]) by smtp.corp.redhat.com (Postfix) with ESMTP id D7D0C112D19B; Thu, 31 May 2018 10:27:17 +0000 (UTC) To: Yonghong Zhu , edk2-devel@lists.01.org Cc: Michael Kinney , Kevin W Shaw , Liming Gao References: <1527728184-1736-1-git-send-email-yonghong.zhu@intel.com> From: Laszlo Ersek Message-ID: <1b2e8a42-2bf9-bba8-5e2f-35d7c929f0f8@redhat.com> Date: Thu, 31 May 2018 12:27:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1527728184-1736-1-git-send-email-yonghong.zhu@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 31 May 2018 10:27:18 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 31 May 2018 10:27:18 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [Patch 1/5] Build Spec: Add !error statement support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 May 2018 10:27:20 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hello Yonghong, On 05/31/18 02:56, Yonghong Zhu wrote: > Cc: Liming Gao > Cc: Michael Kinney > Cc: Kevin W Shaw > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu > --- > 8_pre-build_autogen_stage/82_auto-generation_process.md | 6 ++++++ > README.md | 3 ++- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/8_pre-build_autogen_stage/82_auto-generation_process.md b/8_pre-build_autogen_stage/82_auto-generation_process.md > index 8f8f29b..abfa55c 100644 > --- a/8_pre-build_autogen_stage/82_auto-generation_process.md > +++ b/8_pre-build_autogen_stage/82_auto-generation_process.md > @@ -1058,10 +1058,16 @@ hash value file into the directory specified by binary-destination at the build > When --hash and --binary-source are specified, build tool will try to get the binary > files from the binary source directory at the build phase. If the cached binary has > the same hash value, it will be directly used. Otherwise, build tool will compile the > source files and generate the binary files. > > +#### 8.2.4.16 !error Statement > + > +The DSC and FDF file can use `!error` statement. The argument of this statement is an > +error message, it causes build tool to stop at the location where the statement is > +encountered and error message following the `!error` statement is output as a message. > + > ### 8.2.5 Post processing > > Once all files are parsed, the build tools will do following work for each EDK > II module: > > diff --git a/README.md b/README.md > index 18e46c9..9ca8733 100644 > --- a/README.md > +++ b/README.md > @@ -223,6 +223,7 @@ Copyright (c) 2008-2017, Intel Corporation. All rights reserved. > | | [#775](https://bugzilla.tianocore.org/show_bug.cgi?id=775) Build spec: Add description about auto detect thread number | | > | | Add Flexible PCD value format into spec | | > | | Update PCD value and SKU, DefaultStore info in build report | | > | | Clarify structure PCD field value assignment precedence | | > | | Update description for build handles PCDs for SKU support | | > -| | Add statement about module scoped `` section override scope | | > +| | Add statement about module scoped `` section override scope | | > +| | Add !error statement section | | > I think the correct TianoCore BZ is not 775, but 701; compare: https://bugzilla.tianocore.org/show_bug.cgi?id=775 "Allow build tools to auto-detect MAX_CONCURRENT_THREAD_NUMBER" https://bugzilla.tianocore.org/show_bug.cgi?id=701 "RFE: please introduce !error directive" Thanks! Laszlo