From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web12.1249.1583179196878768099 for ; Mon, 02 Mar 2020 11:59:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fauBgcUJ; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583179196; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WBCmVp3WW2OELsDGfNEdQr6FtlaLqW3/3v//K8qoM3c=; b=fauBgcUJykbhxDJpqWiamSqhb//11be0qPfYR0t694qsQ2QekjVcq1Ovzej//T9y0SLZV0 nJ547snWZ6NnLctWZsf5jDjYnnO1GVtfzBgkNk8Jnc9mk8wNEYj+18ULW8wicUkPTNFPAn KlpA1gpjdrr2xhYSEP3JgUvpcTgG+Ic= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-435-2ME26ILiO9CK4gC8-plpXg-1; Mon, 02 Mar 2020 14:59:49 -0500 X-MC-Unique: 2ME26ILiO9CK4gC8-plpXg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 54A47107ACC4; Mon, 2 Mar 2020 19:59:47 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-197.ams2.redhat.com [10.36.117.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id C026D5C1B0; Mon, 2 Mar 2020 19:59:44 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 00/16] OvmfPkg: support VCPU hotplug with -D SMM_REQUIRE From: "Laszlo Ersek" To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: edk2-devel-groups-io , Ard Biesheuvel , Eric Dong , Hao A Wu , Igor Mammedov , Jian J Wang , Jiewen Yao , Jordan Justen , Michael Kinney , Ray Ni , Boris Ostrovsky Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20200226221156.29589-1-lersek@redhat.com> Message-ID: <1b3d032c-0a47-e641-bb07-df200a0ca3f0@redhat.com> Date: Mon, 2 Mar 2020 20:59:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200226221156.29589-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 02/26/20 23:11, Laszlo Ersek wrote: > Supersedes: <20200223172537.28464-1-lersek@redhat.com> > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1512 > Repo: https://github.com/lersek/edk2.git > Branch: vcpu_hotplug_smm_bz_1512_v2 > > V1 was posted at: > > * [edk2-devel] [PATCH 00/16] > OvmfPkg: support VCPU hotplug with -D SMM_REQUIRE > > https://edk2.groups.io/g/devel/message/54734 > http://mid.mail-archive.com/20200223172537.28464-1-lersek@redhat.com > > New in v2: > > - Document (in patch#11) and implement (in patch#12) the "combined" > approach described here: > > http://mid.mail-archive.com/111145fc-be3d-2a9a-a126-c14345a8a8a4@redhat.com > https://edk2.groups.io/g/devel/message/54754 > > The idea is basically to make the SMM Monarch wait not just until the > hot-added CPU hits the normal RAM Post-SMM Pen (which is safe wrt. > ordering, but can be attacked by the OS), but *also* until the > hot-added CPU is just about to execute RSM first (which is a bit less > safe wrt. ordering, but cannot be attacked by the OS). > > - Pick up Ard's conditional A-b for the other patches, which have not > been modified. > > - Rebase to master, and retest. Thanks everyone for the feedback! I plan to push this series soon after the hard feature freeze ends, and edk2-stable202002 is tagged. I have three questions / remarks regarding that: - Phil, please tell me if you'd like me to hold the series for longer. (You seem to have reached the end of the series, and I'm unsure about the skipped patches -- maybe you want to skip them, maybe you need more time for them.) - I've talked to Igor about ordering the merging of the firmware set vs. the merging of the QEMU patches. Igor made the great point that in this case, QEMU is the user / consumer (ACPI payload) of the firmware feature, and so the firmware stuff should go in first. I hadn't thought of that, but he convinced me. The QEMU PoC patch is available, Boris has tested the patches against each other, and this OVMF set in itself does not regress anything functional. (Note that, while several patches in the series *do* affect code paths that are independent of CPU hotplug, I also regression-tested those.) - Once the set is "in", I'll mark TianoCore#1512 as one of the new features (for the first stable tag *after* edk2-stable202002) at . Thanks Laszlo